-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Deno. How to get about implementing platform-deno? #1806
Comments
The main hurdle I can see so far is that |
I'm not sure I understand how and why |
As you mentioned, Deno is not 100% compat with Node. Hence, to prove that I've also recently opened a PR to add a test matrix that includes Note that we also had to introduce compat code to make the |
Deno is on my list of things to do :) The current plan:
For the first item, feedback is more than welcome from devs who have maintained cross-platform packages. |
A quick google search revealed another package struggling with vitest on deno and attempting a polyfill approach: https://github.com/fabian-hiller/valibot/pull/179/files Might be worth a shot. Although we might have to adjust some of our test utils in |
in
This is tricky, we can import @effect/platform from npm without a problem or use https://esm.sh for it, but I don't see how we would add / integrate it to the existing test suite. Deno has it's own test runner and behaves differently than say NodeJS built-in test runner or
Is @fubhy What is this bun compat layer you mentioned? |
With some trial and error, the test suite for "effect" is working with deno in this PR: #1579 Will need to add the import map generation to our gen script. |
@tim-smart just did a quick glance on the PR, looks yummy, so essentially allowing importing TS extensions, it "just works"? |
I think the testing story is covered now that deno 1.38 supports re-using packages installed by pnpm and vitest seems to work out of the box this way. @tim-smart just merged #1579 |
FYI: The linked denoland/deno#18546 has been closed as resolved as of denoland/deno#24334, and I can't wait to get to help with |
I decided to take a stab at writing this (in userland), and I've got |
🥁 Introducing Supports the Footnotes
|
I'm making good progress! I still need to iron out some wrinkles in If this interests you, feel free to reach out and/or contribute! I'll probably quit posting over here so I don't disturb people who only care about 1st party solutions until that's a possibility. If you want to stay updated, you can subscribe over on lishaduck/effect-utils#1. |
I would be keen on getting platform-deno up and running as node compat is not 100% in Deno.
This would make Effect natively available in Deno.
@tim-smart @gcanti @fubhy @mikearnaldi
Any plans on supporting Deno so far?
What hurdles do we seen in implementing a
platorm-deno
?The text was updated successfully, but these errors were encountered: