Jz vest 7 course tile #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuan-edutrigger
requested changes
Nov 15, 2023
lms/static/sass/views/_homepage.scss
Outdated
| @@ -28,7 +28,7 @@ $learn-more-horizontal-position: calc(50% - 100px); // calculate the left positi | |||
| @include transition(all $tmg-f3 linear 0s); | |||
|
|
|||
| position: relative; | |||
| border-bottom: 3px solid $action-primary-bg; | |||
| // border-bottom: 3px solid $action-primary-bg; | |||
There was a problem hiding this comment.
Remove this if you don't need it
lms/static/sass/views/_homepage.scss
Outdated
| @@ -81,55 +81,96 @@ $learn-more-horizontal-position: calc(50% - 100px); // calculate the left positi | |||
| } | |||
|
|
|||
| .course-info { | |||
| height: $course-info-height; | |||
| height: ($baseline*5.5); | |||
There was a problem hiding this comment.
If we are going to use this later, create this as a variable as well
There was a problem hiding this comment.
And I see you used lots of $baseline times something, try to make things consistent
|
chuan-edutrigger
requested changes
Nov 23, 2023
edit course component
shURenZHOUluxun
force-pushed
the
jz-vest-7-course-tile
branch
from
531ada8 to
02e3c7d
Compare
adjust icon in course.html
shURenZHOUluxun
force-pushed
the
jz-vest-7-course-tile
branch
from
02e3c7d to
26a5875
Compare
edit course css
* refactor: mfe_context response to serialize object keys to camelcase (openedx#31930) * test: add tests for MFE Context API serializser (openedx#32179) * fix: empty pipelineUserDetail object pipelineUserDetail object should be empty when pipeline is not running --------- Co-authored-by: Shahbaz Shabbir <[email protected]>
…dx#33150) This is a backport from the master branch: openedx#30954 The course is visible on the main page right after creation. So anonymous users can see them and access the course about page for the courses without valid data (e.g. they will see the default course overview) When courses list filtering is processed it checks the `see_exists` permission for the anonymous user. Actually, `see_exists` means `can_load` OR `can_enroll`. `can_load` is False in our case because the course start in the future. But `can_enroll` returns True because the course's enrollment_start and enrollment_end dates are blank: ``` enrollment_start = courselike.enrollment_start or datetime.min.replace(tzinfo=UTC) enrollment_end = courselike.enrollment_end or datetime.max.replace(tzinfo=UTC) if enrollment_start < now < enrollment_end: debug("Allow: in enrollment period") return ACCESS_GRANTED ``` Set the enrollment_start the same as a course start by default if the CREATE_COURSE_WITH_DEFAULT_ENROLLMENT_START_DATE feature toggle is enabled (default is False).
Co-authored-by: Edward Zarecor <[email protected]>
Co-authored-by: Usama Sadiq <[email protected]>
Fixed the Course Card Image is absent on FB post after sharing by user. Commit for Palm release.
…a256` (openedx#33345) --------- Co-authored-by: Muhammad Soban Javed <[email protected]> Co-authored-by: Robert Raposa <[email protected]> Co-authored-by: Muhammad Soban Javed <[email protected]>
delete unused uwsgi.ini
shURenZHOUluxun
force-pushed
the
jz-vest-7-course-tile
branch
from
26a5875 to
3e1dbf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit UI for course tile component