-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr/117 remove leaflet #445
Conversation
@bwbohl Could you have a look at this? I am not sure how to check if everything's working fine after removing all leaflet content - I mean it wasn't in use anyway, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to test this PR with the clarinet quintet data I grabbed from the pipeline build.
First I was hit by the error #443 reported by @roewenstrunk so I had to merge his fix into this branch. Then I was able to take a look and it all seemed to work (i.e. I did no systematic tests).
6162596
to
c42a787
Compare
I rebased this branch to bring it up to date with current dev. Please make sure to
|
c42a787
to
f1ffd99
Compare
I see that Lines 38 to 43 in 7b21287
|
0b322c3
to
661f224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works with my data. The changes all seem correct.
Description, Context and related Issue
Removed all leaflet files and content because Edirom does not support leaflet anymore.
Refs #117
How Has This Been Tested?
(...)
Types of changes