Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr/366 remove unused xql #442

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Ftr/366 remove unused xql #442

merged 2 commits into from
Oct 11, 2024

Conversation

daniel-jettka
Copy link
Contributor

Description, Context and related Issue

Removing another unused xql which I missed while cleaning up before

Refs #366

How Has This Been Tested?

Built, deployed, manual visual check

Types of changes

  • cleanup

Checklist

  • I have performed a self-review of my code
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

Copy link
Member

@roewenstrunk roewenstrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe to delete the file. The called XSLT is also not present any more. @bwbohl, you did some changes to the file. What do you think?

@bwbohl
Copy link
Member

bwbohl commented Oct 11, 2024

The changes I did were only when I updated all XQuery files to have a more consistent formatting. When doing so I did not check whether the files were actually being called. So it’s a go from me.

@bwbohl bwbohl added this to the 1.0.0 milestone Oct 11, 2024
@bwbohl bwbohl linked an issue Oct 11, 2024 that may be closed by this pull request
1 task
@bwbohl bwbohl merged commit c96595d into develop Oct 11, 2024
1 check passed
@bwbohl bwbohl deleted the ftr/366-remove-unused-xql branch October 11, 2024 09:29
@daniel-jettka daniel-jettka linked an issue Oct 24, 2024 that may be closed by this pull request
Diginaut pushed a commit to korngold-werkausgabe/Edirom-Online_EWK-WA that referenced this pull request Dec 16, 2024
removed unused getRendering.xql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove unused xql files
3 participants