Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #436

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

krHERO
Copy link
Member

@krHERO krHERO commented Oct 9, 2024

Description

as agreed at the edirom community meeting 9.10.2024, we do not want to have tasks but (optional) bullet points.

Types of changes

  • Improvement

as agreed at the edirom community meeting 9.10.2024, we do not want to have tasks but (optional) bullet points.
@krHERO krHERO added this to the 1.0.0 milestone Oct 9, 2024
@krHERO krHERO requested a review from peterstadler October 9, 2024 13:37
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several points are still unclear to and would benefit from further explanation.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@krHERO
Copy link
Member Author

krHERO commented Nov 6, 2024

Several points are still unclear to and would benefit from further explanation.

thanks for the points you pointed out in your first review.
could you please have a look again, i changed the stuff, we discussed recently. thanks

Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, many thanks!

@krHERO krHERO merged commit 54656de into Edirom:develop Nov 7, 2024
3 checks passed
@krHERO krHERO deleted the ftr-pull_request_template branch November 13, 2024 20:18
Diginaut pushed a commit to korngold-werkausgabe/Edirom-Online_EWK-WA that referenced this pull request Dec 16, 2024
this commit adresses remarks of the review of @peterstadler

refs Edirom#436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants