Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing "error page" if no edition exists (prevents failing) #429

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

riedde
Copy link
Contributor

@riedde riedde commented Sep 18, 2024

Description, Context and related Issue

HTML page added for this case. It is analog to the page of multiple editions, but with a message that no edition exists. If no edition is found the controller will lead to this page. This prevents a total fail of the app and looks much better ;-)

Refs #335

How Has This Been Tested?

On local machine with docker and exist-db 6.2.0.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

@riedde riedde requested a review from bwbohl September 18, 2024 06:26
add/index.xql Outdated Show resolved Hide resolved
@riedde riedde added this to the 1.0.0 milestone Oct 9, 2024
@krHERO
Copy link
Member

krHERO commented Oct 9, 2024

consensus community meeting 9.10.2024: catch it in index.xql (no templating) with text like "no edition file found"

@riedde riedde requested a review from peterstadler October 9, 2024 16:01
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested locally and I can confirm that the EOL now smoothly handles 0 to 2 editions

@peterstadler peterstadler merged commit 8742faa into develop Oct 10, 2024
1 check passed
@peterstadler peterstadler deleted the fix/335-fail-if-no-edition branch October 10, 2024 21:24
@peterstadler peterstadler linked an issue Oct 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Gently fail Edirom Online if no Edition is available in database
3 participants