Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed improvement for getAnnotationsOnPage #427

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

peterstadler
Copy link
Member

Description, Context and related Issue

This PR improves the performance of the getAnnotationsOnPage endpoint

How Has This Been Tested?

Testing was done with a recent development version of getAnnotationsOnPage.xql vs the improved version presented here. As test data served the clarinet quintet and the improvement was monitored with Monex. I simply issued the following request five times: http://localhost:8080/exist/apps/Edirom-Online/data/xql/getAnnotationsOnPage.xql?_dc=1726123824958&uri=xmldb%3Aexist%3A%2F%2F%2Fdb%2Fapps%2Fweber-klarinettenquintett-eol-emeritus%2Fsources%2Fsource-1.xml&pageId=facsimile-20010010&lang=de&edition=xmldb%3Aexist%3A%2F%2F%2Fdb%2Fapps%2Fweber-klarinettenquintett-eol-emeritus%2Fedition.xml

before

Bildschirmfoto 2024-09-12 um 08 53 33

after

Bildschirmfoto 2024-09-12 um 08 52 45

Types of changes

  • performance improvement

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bwbohl
Copy link
Member

bwbohl commented Sep 12, 2024

great work!

@peterstadler peterstadler added this to the 1.0.0 milestone Sep 12, 2024
@bwbohl bwbohl merged commit 8111bd7 into develop Sep 12, 2024
1 check passed
@bwbohl bwbohl deleted the speed-up-getAnnotations branch September 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants