Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace proprietary exist:serialize options #418

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Conversation

peterstadler
Copy link
Member

leftovers from #414 spotted by @bwbohl

Refs #362

To discuss

The current output method of add/controller.xql ("method=xhtml media-type=application/xhtml+html") seems incorrect to me. In fact, it returns a <dispatch> element so it should be considered "method=xml media-type=application/xml". Looking at various eXist apps (eXide, Monex, etc.), those never state the output method explicitly, so I assume they are relying on the default "xml". Only the Dashboard app has something different, yet I consider this an error?
https://github.com/eXist-db/dashboard/blob/35ca2c9d5efc6ac27b28a6bfdb4f499bb622a2d8/controller.xql#L5-L7

Nevertheless, I'm not 100% sure so I copied over the existing media type and output method and put it here for discussion.

Copy link
Member

@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fixing the leftovers!

I think you’re completely right that the serialization options are not appropriate for the controller.xql

@bwbohl bwbohl added this to the 1.0.0 milestone Sep 9, 2024
@peterstadler
Copy link
Member Author

Hi @bwbohl , why are you adding all these merge commits (that will apparently be included in the history)?
I don't think they are necessary here since there were no conflicts, right? If you want a clean history, I recommend to rebase the branch. That will require a force push so should better be done by the PR opener (if he/she is not unresponsive).

@bwbohl
Copy link
Member

bwbohl commented Sep 10, 2024

Hi @bwbohl , why are you adding all these merge commits (that will apparently be included in the history)? I don't think they are necessary here since there were no conflicts, right? If you want a clean history, I recommend to rebase the branch. That will require a force push so should better be done by the PR opener (if he/she is not unresponsive).

There’s a button – I click the button … sorry

The controller serialisation question is clear from what you stated above. Please don't hesitate to remove the serialisation.

@peterstadler
Copy link
Member Author

peterstadler commented Sep 10, 2024

The controller serialisation question is clear from what you stated above. Please don't hesitate to remove the serialisation.

Done!

Copy link
Member

@bwbohl bwbohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks

@bwbohl bwbohl merged commit d3f4ce4 into develop Sep 10, 2024
1 check passed
@bwbohl bwbohl deleted the fix-362-leftovers branch September 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants