Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

js-test.js functions used in string parameters #9

Open
dmorejon opened this issue Aug 14, 2020 · 0 comments
Open

js-test.js functions used in string parameters #9

dmorejon opened this issue Aug 14, 2020 · 0 comments

Comments

@dmorejon
Copy link
Contributor

dmorejon commented Aug 14, 2020

There are instances of js-test.js functions used in stringified parameters. These parameters are parsed and then passed to testharness.js directly, which would cause problems since they use the old functions. Example:

shouldBeTrue("areArraysEqual(index.keyPath, ['c', 'd'])");

This would be transformed as: assert_true(areArraysEqual(index.keyPath, ['c', 'd']);.
Running this test in the testharness.js framework would fail, since areArraysEqual is a js-test.js function.

This is likely very hard to do correctly and not common the chromium source so this is low priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant