Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product tags #67

Closed
wants to merge 22 commits into from
Closed

Add product tags #67

wants to merge 22 commits into from

Conversation

RayMMond
Copy link
Member

@RayMMond RayMMond commented Jun 26, 2020

Resolve #64, #63.

@RayMMond RayMMond changed the title Add product tags [wip]Add product tags Jun 26, 2020
@RayMMond RayMMond changed the title [wip]Add product tags [WIP] Add product tags Jun 26, 2020
@RayMMond RayMMond marked this pull request as draft June 26, 2020 09:04
@RayMMond RayMMond changed the title [WIP] Add product tags Add product tags Jun 26, 2020
@gdlcf88
Copy link
Member

gdlcf88 commented Jun 26, 2020

Hi @RayMMond, could you please also implement these features?

  • MVC UI: ProductTags select in create product modal and edit product modal.
  • MVC UI: Tag management pages.

@RayMMond
Copy link
Member Author

  1. I'm working on that.
  2. It needs Add store's owner #68 to handle permission correctly.

@gdlcf88
Copy link
Member

gdlcf88 commented Jun 27, 2020

It needs #68 to handle permission correctly

Product management pages are for store-side admin too, #68 doesn't affect the implementation of the tag management pages.

@gdlcf88 gdlcf88 marked this pull request as ready for review July 13, 2020 20:47
@gdlcf88
Copy link
Member

gdlcf88 commented Jul 13, 2020

Hi @RayMMond, I see this PR has been around for some time, could you please finish the rest of the work?

Some tips:

  1. Difference between ParentId and ParentCategoryId in Category model? #63 has been done by 518d3b0, so the migration files and some code changes in this PR should be handle.
  2. Modules of EasyAbp do not need the auto API controller anymore, so we should create a ProductTagController for ProductTagAppService, you can do it with AbpHelper's new controller generation feature. (refer to 6b3dfa8#diff-2404d1e57687ecd2ff7b6869aca7108a)
  3. Should finish ProductTag's management pages, I can help you if you need it.

@RayMMond
Copy link
Member Author

@gdlcf88 Sorry~ super busy last two weeks 😂 , I will try to finish this PR this weekend.
About management pages, honestly, I'm not vary good at MVCs, but I still wanna try it first, so If I can't finish it by the end of week, I will ask for help 😄

@wakuflair
Copy link
Member

Is there any possibility that extract "tag" feature into separate module?

RayMMond and others added 7 commits July 18, 2020 17:24
Close EasyAbp#63: Remove ParentCategoryId
Change CategoryParentCategoryId to CategoryParentId
Add product tag app services.
Make project tag app service public
create tag related mvc ui.
@RayMMond
Copy link
Member Author

RayMMond commented Jul 18, 2020

@gdlcf88 I think I have finished this PR, you can review it now. 😃

@RayMMond
Copy link
Member Author

@wakuflair I think tag feature could be a plugin module, but I haven't checked the code of plugins.
What do you think @gdlcf88 ?

@gdlcf88
Copy link
Member

gdlcf88 commented Jul 18, 2020

@wakuflair I think tag feature could be a plugin module, but I haven't checked the code of plugins.
What do you think @gdlcf88 ?

Agree.

I think it will depend on the unfinished design of EShop.Plugins module. Think about this: how to insert widgets of the ProductTag plugin into the product management page?

Maybe there are some other works that should be done:

  1. Make EShop.Products.Web depends on EShop.Plugins.Web
  2. Design some "plugins hooks", for example:
    • Load extra entries in the action dropdown menu of the product list page.
    • Load extra widgets in the product's create/edit/(detail)/createSku/editSku/(skuDetail) modals. (refer to abp's Login.cshtml)

Does anyone else have a better idea?

@RayMMond
Copy link
Member Author

@gdlcf88 @wakuflair maybe the tag feature should be implemented in another PR?

@gdlcf88
Copy link
Member

gdlcf88 commented Jul 18, 2020

@gdlcf88 @wakuflair maybe the tag feature should be implemented in another PR?

If the above consideration is reasonable, creating a new PR based on the latest dev branch may be better. 🤣

@RayMMond RayMMond mentioned this pull request Aug 3, 2020
@RayMMond
Copy link
Member Author

Make product tag as plugin, close this.

@RayMMond RayMMond closed this Aug 15, 2020
@RayMMond RayMMond mentioned this pull request Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of store's categories
3 participants