-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product tags #67
Add product tags #67
Conversation
Hi @RayMMond, could you please also implement these features?
|
|
Hi @RayMMond, I see this PR has been around for some time, could you please finish the rest of the work? Some tips:
|
@gdlcf88 Sorry~ super busy last two weeks 😂 , I will try to finish this PR this weekend. |
Is there any possibility that extract "tag" feature into separate module? |
Close EasyAbp#63: Remove ParentCategoryId
Change CategoryParentCategoryId to CategoryParentId
Add product tag app services.
Make project tag app service public
create tag related mvc ui.
@gdlcf88 I think I have finished this PR, you can review it now. 😃 |
@wakuflair I think tag feature could be a plugin module, but I haven't checked the code of plugins. |
Agree. I think it will depend on the unfinished design of EShop.Plugins module. Think about this: how to insert widgets of the ProductTag plugin into the product management page? Maybe there are some other works that should be done:
Does anyone else have a better idea? |
@gdlcf88 @wakuflair maybe the tag feature should be implemented in another PR? |
If the above consideration is reasonable, creating a new PR based on the latest dev branch may be better. 🤣 |
Close EasyAbp#63: Remove ParentCategoryId
Change CategoryParentCategoryId to CategoryParentId
Add product tag app services.
Make project tag app service public
create tag related mvc ui.
Make product tag as plugin, close this. |
Resolve #64, #63.