Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][API] Fix periods to seconds transform #197

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

fjugipe
Copy link
Contributor

@fjugipe fjugipe commented Oct 2, 2024

  • Fix a bug when transforming periods to seconds when the transformed period is longer than P1D
  • Update test data-loader to be on par with ingest logic

@fjugipe fjugipe added bug Something isn't working API:EDR Label for API issue and PR related to EDR labels Oct 2, 2024
@fjugipe fjugipe requested a review from Teddy-1000 October 2, 2024 06:54
Copy link

github-actions bot commented Oct 2, 2024

API Unit Test Coverage Report
FileStmtsMissCoverMissing
\_\_init\_\_.py00100% 
datastore_pb2.py655220%34–85
datastore_pb2_grpc.py542750%15–16, 19, 65–80, 121–123, 128–130, 135–137, 142–144, 148–173, 219, 246, 273, 300
export_metrics.py100100% 
grpc_getter.py201145%15–19, 23–26, 30–32, 36–38
locustfile.py15150%1–31
main.py43784%45, 50, 60, 70–71, 81–82
metadata_endpoints.py653152%45–54, 58, 85, 100–219, 223
response_classes.py50100% 
utilities.py1744674%20, 38, 45, 67–70, 78–89, 94–101, 121, 125, 127, 155, 161, 179, 193–194, 198, 214–218, 222–228, 232–234, 264, 268, 290, 295
custom_geo_json
   edr_feature_collection.py60100% 
formatters
   \_\_init\_\_.py110100% 
   covjson.py59198%91
   geojson.py21290%27, 52
openapi
   custom_dimension_examples.py40100% 
   edr_query_parameter_descriptions.py110100% 
   openapi_examples.py130100% 
routers
   \_\_init\_\_.py00100% 
   edr.py101496%348–349, 438–439
   feature.py471960%99–132, 148–153, 159–181
TOTAL72421570% 

API Unit Test Coverage Summary

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 1.941s ⏱️

@fjugipe fjugipe merged commit 4945d72 into main Oct 2, 2024
8 checks passed
@fjugipe fjugipe deleted the fix_query_duration_parsing branch October 2, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API:EDR Label for API issue and PR related to EDR bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants