From 1312be10f6a8298d98f7c04f35333a0fdcf4c35f Mon Sep 17 00:00:00 2001
From: Lukas Phaf <lukas.phaf@knmi.nl>
Date: Wed, 27 Mar 2024 12:03:45 +0100
Subject: [PATCH] Change /locations to first get all unique parameters, and
 then the actual stations, making the connection only by parameter_name.

---
 api/routers/edr.py | 42 ++++++++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 18 deletions(-)

diff --git a/api/routers/edr.py b/api/routers/edr.py
index 4ea52b4d..11594bf1 100644
--- a/api/routers/edr.py
+++ b/api/routers/edr.py
@@ -1,4 +1,5 @@
 # For developing:    uvicorn main:app --reload
+import logging
 from collections import defaultdict
 from typing import Annotated
 from typing import DefaultDict
@@ -20,6 +21,7 @@
 from geojson_pydantic import Feature
 from geojson_pydantic import Point
 from grpc_getter import get_obs_request
+from grpc_getter import get_ts_ag_request
 from shapely import buffer
 from shapely import geometry
 from shapely import wkt
@@ -29,6 +31,11 @@
 from utilities import validate_bbox
 from utilities import verify_parameter_names
 
+
+logger = logging.getLogger(__name__)
+logger.setLevel(logging.INFO)
+
+
 router = APIRouter(prefix="/collections/observations")
 
 response_fields_needed_for_data_api = [
@@ -56,17 +63,27 @@
 async def get_locations(
     bbox: Annotated[str | None, Query(example="5.0,52.0,6.0,52.1")] = None
 ) -> EDRFeatureCollection:  # Hack to use string
+    # TODO: Remove duplication between `/collections` endpoint
+    # Get all unique parameters
+    ts_request = dstore.GetTSAGRequest(attrs=["parameter_name", "standard_name", "unit", "level", "period", "function"])
+    ts_response = await get_ts_ag_request(ts_request)
+    # logger.info(ts_response.ByteSize())
+
+    # Sadly, this is a different parameter as in the /locations endpoint, due to an error in the EDR spec
+    # See: https://github.com/opengeospatial/ogcapi-environmental-data-retrieval/issues/427
+    all_parameters: Dict[str, Parameter] = {}
+
+    for group in ts_response.groups:
+        ts = group.combo
+        parameter = make_parameter(ts)
+        all_parameters[ts.parameter_name] = parameter
+
     ts_request = dstore.GetObsRequest(
         temporal_latest=True,
         included_response_fields=[
             "parameter_name",
             "platform",
             "geo_point",
-            "standard_name",
-            "unit",
-            "level",
-            "period",
-            "function",
         ],
     )
     # Add spatial area to the time series request if bbox exists.
@@ -78,28 +95,17 @@ async def get_locations(
         )
 
     ts_response = await get_obs_request(ts_request)
+    # logger.info(ts_response.ByteSize())
 
     platform_parameters: DefaultDict[str, Set[str]] = defaultdict(set)
     platform_coordinates: Dict[str, Set[Tuple[float, float]]] = defaultdict(set)
-    all_parameters: Dict[str, Parameter] = {}
     for obs in ts_response.observations:
-        parameter = make_parameter(obs.ts_mdata)
         platform_parameters[obs.ts_mdata.platform].add(obs.ts_mdata.parameter_name)
         # Take last point
         platform_coordinates[obs.ts_mdata.platform].add(
             (obs.obs_mdata[-1].geo_point.lon, obs.obs_mdata[-1].geo_point.lat)
         )
-        # Check for inconsistent parameter definitions between stations
-        # TODO: How to handle those?
-        if obs.ts_mdata.parameter_name in all_parameters and all_parameters[obs.ts_mdata.parameter_name] != parameter:
-            raise HTTPException(
-                status_code=500,
-                detail={
-                    "parameter": f"Parameter with name {obs.ts_mdata.parameter_name} "
-                    f"has multiple definitions:\n{all_parameters[obs.ts_mdata.parameter_name]}\n{parameter}"
-                },
-            )
-        all_parameters[obs.ts_mdata.parameter_name] = parameter
+        # TODO: How to check for inconsistent parameter definitions between stations
 
     # Check for multiple coordinates on one station
     for station_id in platform_parameters.keys():