Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more graceful handling of retrieve of unknown ID #9

Open
alaniwi opened this issue Feb 4, 2020 · 2 comments
Open

more graceful handling of retrieve of unknown ID #9

alaniwi opened this issue Feb 4, 2020 · 2 comments

Comments

@alaniwi
Copy link

alaniwi commented Feb 4, 2020

A retrieve of an unknown erratum id, for example:

https://errata.es-doc.org/1/issue/retrieve?uid=01234567-89ab-cdef-0123-456789abcdef

fails with an HTTP 500 status, with content:

{"errorCode": 999, "errorMessage": "'NoneType' object has no attribute 'to_dict'", "errorType": "AttributeError", "errorField": "--"}

It would probably be better to fail with a 400 ("bad request") in one form or another.

@AtefBN
Copy link
Member

AtefBN commented Feb 5, 2020

I agree Alan, I'll note this to be part of the errata coding sprint @momipsl and I will be holding end of this month.

@alaniwi
Copy link
Author

alaniwi commented Feb 5, 2020

@AtefBN Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants