Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to compose pipelines that fetch the code version that activated the build #57

Closed
orviz opened this issue Apr 15, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request in staging Changes applied to the staging app

Comments

@orviz
Copy link
Contributor

orviz commented Apr 15, 2021

JePL allows to fetch the code version that triggered the build (instead of a fixed version defined in config:project_repos) and use that for the validation of the given criterion. This is done by removing the repos property within sqa_criteria:<criterion>, and currently supported by the jpl-validator.

Unfortunately, this feature is not yet documented in JePL, there is an issue for that: indigo-dc/jenkins-pipeline-library#142

@orviz orviz added the enhancement New feature or request label Apr 15, 2021
@orviz
Copy link
Contributor Author

orviz commented Apr 22, 2021

@orviz
Copy link
Contributor Author

orviz commented Apr 22, 2021

There is an additional feature that can be added in the web and performed by the API. In the event of having such type of non-repo definitions for a given criterion (basically what this issue is dealing), it is known that the "Run pipeline" feature will not have the code in the (*.sqaaas) repository, and thus the pipeline execution will not succeed.

One solution for this is that whenever the "Run pipeline" is requested by the user, the web warns about this fact and provides the possibility to fetch the code from the upstream repository the pipeline is meant to be added. This will mimic the future execution of the pipeline in the appropriate environment.

Associated API server issue: https://github.com/EOSC-synergy/sqaaas-api-server/issues/48

@dianamariand92 dianamariand92 added the in staging Changes applied to the staging app label May 20, 2021
@dianamariand92
Copy link
Collaborator

Pushed changes to the master branch (production web).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in staging Changes applied to the staging app
Projects
None yet
Development

No branches or pull requests

2 participants