-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement optional hot module replacement (HMR) support #24
Comments
Hmm, I think that would be very helpful! I'm a bit overwhelmed at the moment so this will have to go on the backlog for now. You are welcome to open a PR! |
Svelte-HMR have a many operations in JS... think it’s may doing esbuild slowed..🤔 & I’m not sure how it’s implementing properly... but may be I will try 🤓 |
I'm actually going to reopen this issue because I want to track people's interest. When I have time, this would be a good weekend project, if you don't get to it first. |
👌🏻Optional HMR may be good 🤓 |
Would be great to have. Sadly, do not have free time atm too. but could help with it |
In the interest of heading towards a |
I think HMR would be a worthwhile addition as, in my opinion, this is whatis holding esbuild back the most. HMR would be a great addition to have for DX, just look at vite. This could be useful to take a look at on how this would be implemented: https://github.com/remorses/bundless/blob/master/plugins/svelte/src/index.ts |
Thanks for the ping, now I'm actually looking at this issue again :) Supposedly Svelte 5 will have built-in HMR support. Still need to scope out exactly what is necessary to get that working within esbuild. As mentioned above, this probably won't land in |
rixo/svelte-hmr - https://github.com/rixo/svelte-hmr
intrnl/vite-plugin-svelte - https://github.com/intrnl/vite-plugin-svelte/blob/trunk/lib/index.js (like example)
The text was updated successfully, but these errors were encountered: