Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing to apply PR patch should be reported in PR #212

Open
boegel opened this issue Sep 6, 2023 · 3 comments
Open

failing to apply PR patch should be reported in PR #212

boegel opened this issue Sep 6, 2023 · 3 comments

Comments

@boegel
Copy link
Contributor

boegel commented Sep 6, 2023

When setting up the working directory for jobs, the PR patch that is used may fail to apply because of recent changes in the target branch (see for example EESSI/software-layer#321 (comment)):

[20230906-T07:10:52] run_cmd(): Error running 'git apply 321.diff' in '/mnt/shared/home/bot/eessi-bot-software-layer/jobs/2023.09/pr_321/event_7f6fa000-4c84-11ee-97ce-9db16087e54d/run_000/linux_x86_64_generic/eessi-2023.06-software
           stdout ''
           stderr 'error: patch failed: configure_easybuild:26
error: configure_easybuild: patch does not apply
'

This implies that the PR should be synced with the target branch first.

The bot should post a comment in the PR when it fails to prepare the working directory for build jobs, now this is failing silently (no build jobs are being submitted, and it's unclear why).

@boegel
Copy link
Contributor Author

boegel commented Sep 8, 2023

Same problem occurred in EESSI/software-layer#330 because EESSI/software-layer#329 got merged before build was (re-)triggered, because both are touching .github/workflows/test_eessi.yml

@trz42
Copy link
Contributor

trz42 commented Sep 17, 2023

I don't think it's a bug, but letting the bot report the result of the failing patch is certainly a worthwhile improvement.

@trz42 trz42 added enhancement and removed bug labels Sep 17, 2023
@Neves-P
Copy link
Member

Neves-P commented Oct 26, 2023

I've got the bot running now up to a point where I should be able to replicate this on my end, so I can start working on this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants