Added an indirection level to allow tests to specify different configs #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tkael
added
the
10. work unit (user unaffected)
richardbuckle
added
the
needs thought
|
Added "Needs thought" while we discuss in Discord. |
|
Confirmed that Hooda's branch includes a basic config service. Still a ways to go in refining it before it'll be ready for release, but that refinement could very probably include something like this. |
Tkael
approved these changes
Oct 30, 2020
Tkael
added
on hold
and removed
needs thought
|
I don't think this is a good way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a variable in Constants to be used from tests code.
So we can avoid re-using our gaming environments to do debugging and running tests.
For an example of usage, see https://github.com/GioVAX/EDDI/blob/1781-Part2/Tests/MainWindowResponderTests.cs#L17