Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseCircuit.predict() won't take float as input #277

Open
Yugal0 opened this issue Aug 9, 2023 · 0 comments · May be fixed by #304
Open

BaseCircuit.predict() won't take float as input #277

Yugal0 opened this issue Aug 9, 2023 · 0 comments · May be fixed by #304

Comments

@Yugal0
Copy link

Yugal0 commented Aug 9, 2023

BaseCiruit.predict() only accepts a nd.array as an input,
hence the frequency data need to be compulsory supplied as an array
But If I want to predict the impedance at a particular frequency, then BaseCircuit.predict() should also accept a single float value instead of forcing me to write it as an array containing a single element. or exampl
For example-
from impedance.models.circuits import CustomCircuit
RC_parallel=CustomCircuit("p(R0,C0)",initial_guess=[1e2,1e-3])

print(RC_parallel.predict([9]))
and
print(RC_parallel.predict(9))

should both be valid.

But as of now, the print(RC_parallel.predict(9)) gives error.

@adrianusler adrianusler linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant