Skip to content

Commit

Permalink
Add non-MPI remove feature
Browse files Browse the repository at this point in the history
  • Loading branch information
streeve committed Sep 24, 2024
1 parent eed7164 commit 06f7620
Show file tree
Hide file tree
Showing 5 changed files with 176 additions and 0 deletions.
1 change: 1 addition & 0 deletions core/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ set(HEADERS_PUBLIC
Cabana_ParameterPack.hpp
Cabana_ParticleInit.hpp
Cabana_ParticleList.hpp
Cabana_Remove.hpp
Cabana_Slice.hpp
Cabana_SoA.hpp
Cabana_Sort.hpp
Expand Down
1 change: 1 addition & 0 deletions core/src/Cabana_Core.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <Cabana_ParameterPack.hpp>
#include <Cabana_ParticleInit.hpp>
#include <Cabana_ParticleList.hpp>
#include <Cabana_Remove.hpp>
#include <Cabana_Slice.hpp>
#include <Cabana_SoA.hpp>
#include <Cabana_Sort.hpp>
Expand Down
102 changes: 102 additions & 0 deletions core/src/Cabana_Remove.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
/****************************************************************************
* Copyright (c) 2018-2023 by the Cabana authors *
* All rights reserved. *
* *
* This file is part of the Cabana library. Cabana is distributed under a *
* BSD 3-clause license. For the licensing terms see the LICENSE file in *
* the top-level directory. *
* *
* SPDX-License-Identifier: BSD-3-Clause *
****************************************************************************/

/*!
\file Cabana_Remove.hpp
\brief Remove particles (without using MPI)
*/
#ifndef CABANA_REMOVE_HPP
#define CABANA_REMOVE_HPP

#include <Cabana_AoSoA.hpp>
#include <Cabana_DeepCopy.hpp>
#include <Cabana_Slice.hpp>

#include <Kokkos_Core.hpp>
#include <iostream>
namespace Cabana
{
//---------------------------------------------------------------------------//
/*
\brief Filter out empty/unneeded particles.
\param exec_space Kokkos execution space.
\param num_keep The total number of particles in the compaction section to
keep.
\param num_particles_ignore The number of particles to ignore (which precede
those which may be kept/removed).
\param keep_particle Boolean Kokkos View of particles to keep (true) or remove
(false).
\param particles The AoSoA containing particles.
\param shrink_to_fit Whether to remove additional AoSoA capacity or not.
*/
template <class ExecutionSpace, class KeepView, class ParticleAoSoA>
void remove( const ExecutionSpace& exec_space, const int num_keep,
const KeepView& keep_particle, ParticleAoSoA& particles,
const int num_particles_ignore = 0,
const bool shrink_to_fit = true )
{
using memory_space = typename KeepView::memory_space;

// Determine the empty particle positions in the compaction zone.
int num_particles = particles.size();
// This View is either empty indices to be filled or the created particle
// indices, depending on the ratio of allocated space to the number
// created.
Kokkos::View<int*, memory_space> indices(
Kokkos::ViewAllocateWithoutInitializing( "empty_or_filled" ),
std::min( num_particles - num_particles_ignore - num_keep, num_keep ) );

int new_num_particles = num_particles_ignore + num_keep;
// parallel_scan will break if not keeping any particles.
if ( num_keep > 0 )
{
Kokkos::parallel_scan(
"Cabana::remove::FindEmpty",
Kokkos::RangePolicy<ExecutionSpace>( exec_space, 0, num_keep ),
KOKKOS_LAMBDA( const int i, int& count, const bool final_pass ) {
std::cout << i << std::endl;
if ( !keep_particle( i ) )
{
if ( final_pass )
{
indices( count ) = i + num_particles_ignore;
}
++count;
}
} );
Kokkos::fence();

// Compact the list so the it only has real particles.
Kokkos::parallel_scan(
"Cabana::remove::RemoveEmpty",
Kokkos::RangePolicy<ExecutionSpace>( exec_space, new_num_particles,
num_particles ),
KOKKOS_LAMBDA( const int i, int& count, const bool final_pass ) {
if ( keep_particle( i - num_particles_ignore ) )
{
if ( final_pass )
{
particles.setTuple( indices( count ),
particles.getTuple( i ) );
}
++count;
}
} );
}

particles.resize( new_num_particles );
if ( shrink_to_fit )
particles.shrinkToFit();
}

} // end namespace Cabana

#endif // end CABANA_REMOVE_HPP
1 change: 1 addition & 0 deletions core/unit_test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ set(SERIAL_TESTS
ParameterPack
ParticleInit
ParticleList
Remove
Slice
Sort
Tuple
Expand Down
71 changes: 71 additions & 0 deletions core/unit_test/tstRemove.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
/****************************************************************************
* Copyright (c) 2018-2023 by the Cabana authors *
* All rights reserved. *
* *
* This file is part of the Cabana library. Cabana is distributed under a *
* BSD 3-clause license. For the licensing terms see the LICENSE file in *
* the top-level directory. *
* *
* SPDX-License-Identifier: BSD-3-Clause *
****************************************************************************/

#include <Cabana_AoSoA.hpp>
#include <Cabana_DeepCopy.hpp>
#include <Cabana_Remove.hpp>

#include <Kokkos_Core.hpp>

#include <gtest/gtest.h>

namespace Test
{

void testRemove()
{
int num_particle = 200;
Cabana::AoSoA<Cabana::MemberTypes<int>, TEST_MEMSPACE> aosoa(
"remove", num_particle );
// Purposely using zero-init here.
Kokkos::View<int*, TEST_MEMSPACE> keep_particle( "keep", num_particle );

auto keep_slice = Cabana::slice<0>( aosoa, "slice" );
Kokkos::parallel_for(
"init", Kokkos::RangePolicy<TEST_EXECSPACE>( 0, num_particle ),
KOKKOS_LAMBDA( const int p ) {
if ( p % 2 )
{
keep_slice( p ) = 1;
keep_particle( p ) = 1;
}
else
{
keep_slice( p ) = 0;
}
} );

// Remove only odd particles.
int new_num_particle = num_particle / 2;
std::cout << aosoa.size() << std::endl;
Cabana::remove( TEST_EXECSPACE{}, new_num_particle, keep_particle, aosoa );
std::cout << aosoa.size() << std::endl;
EXPECT_EQ( aosoa.size(), new_num_particle );

// Remove the rest.
Kokkos::resize( keep_particle, new_num_particle );
keep_slice = Cabana::slice<0>( aosoa, "slice" );
Kokkos::parallel_for(
"init", Kokkos::RangePolicy<TEST_EXECSPACE>( 0, new_num_particle ),
KOKKOS_LAMBDA( const int p ) {
keep_particle( p ) = 1;
keep_slice( p ) = 0;
} );

std::cout << aosoa.size() << std::endl;
Cabana::remove( TEST_EXECSPACE{}, 0, keep_particle, aosoa );
std::cout << aosoa.size() << std::endl;
EXPECT_EQ( aosoa.size(), 0 );
}

TEST( TEST_CATEGORY, remove_test ) { testRemove(); }

} // namespace Test

0 comments on commit 06f7620

Please sign in to comment.