Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_name required #114

Open
rajeeja opened this issue Jan 12, 2023 · 5 comments
Open

model_name required #114

rajeeja opened this issue Jan 12, 2023 · 5 comments

Comments

@rajeeja
Copy link
Contributor

rajeeja commented Jan 12, 2023

With the updates in candle_lib model_name is a required hyperparameter. Breaks UNO and might other Benchmarks also.

@jmohdyusof
Copy link
Contributor

jmohdyusof commented Jan 12, 2023

Yes, I have updated all the benchmarks to comply. Did you find an error? First line of uno_default_model.txt is model_name

@rajeeja
Copy link
Contributor Author

rajeeja commented Jan 12, 2023

Gotcha. Not all .txt files were changed. I was using uno_auc_model.txt in my fork. https://github.com/rajeeja/Benchmarks/tree/AUCstd1

@jmohdyusof
Copy link
Contributor

OK, I basically just swept all the xxx_default_model.txt files, I would have missed any secondary .txt files (most benchmarks do not have more than the default_model). I can sweep the others. We also need to fix the path issue

@rajeeja
Copy link
Contributor Author

rajeeja commented Jan 12, 2023

Is --config_file broken?

@jmohdyusof
Copy link
Contributor

It is because Tom wanted non-default files to be in data_dir. I am working with Cristina to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants