Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring around TimetableItemList #719

Open
takahirom opened this issue Oct 3, 2021 · 0 comments
Open

Refactoring around TimetableItemList #719

takahirom opened this issue Oct 3, 2021 · 0 comments

Comments

@takahirom
Copy link
Member

Kind (Required)

  • Improvement

Overview (Required)

Currently, I am using List for TimetableItemList.
However, I would like to use "favorites" in TimetableItemList. Currently, we are using timetableContents.favorites.contains(timetableItemId).
For example, TimetableItemList has a pair of TimetableItem and isFavorited.
TimetableItemList(timetableItems, favorites).get(0) returns Pair<TimetableItem, Boolean>

https://github.com/DroidKaigi/conference-app-2021/blob/main/model/src/commonMain/kotlin/io/github/droidkaigi/feeder/TimetableContents.kt#L8

Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant