Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use navigation scoped ViewModel #609

Closed
takahirom opened this issue Sep 8, 2021 · 2 comments · Fixed by #614
Closed

Use navigation scoped ViewModel #609

takahirom opened this issue Sep 8, 2021 · 2 comments · Fixed by #614
Assignees

Comments

@takahirom
Copy link
Member

takahirom commented Sep 8, 2021

Kind (Required)

  • Improvement

Overview (Required)

  • Currently, we are using application-scoped ViewModel. But it is not scalable. So we want to migrate to navigation scoped ViewModel
  • Basically, it's easy because you just replace the ViewModel that was provided with Factory.
  • See the pull request below for more information.

#608

Please apply navigation scope ViewModel to these ViewModels

staffViewModelProviderValue(viewModel<RealStaffViewModel>()),
contributorViewModelProviderValue(fakeContributorViewModel()),
fmPlayerViewModelProviderValue(viewModel<RealFmPlayerViewModel>()),

Links

@tmk815
Copy link
Contributor

tmk815 commented Sep 13, 2021

🙋‍♂️

@takahirom
Copy link
Member Author

Thanks! Assigned 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants