From 79e3cac3975a81a08860b8de96e3e25f75ec9d5e Mon Sep 17 00:00:00 2001
From: "Ahmad K. Bawaneh" <ahmad.bawaneh@dominokit.com>
Date: Fri, 26 Jul 2024 18:09:26 +0300
Subject: [PATCH] fix #945 Select inner divs overlap outer divs height

---
 .../java/org/dominokit/domino/ui/forms/ValueBox.java     | 4 +++-
 .../domino/ui/public/css/forms/domino-ui-forms.css       | 9 +++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/ValueBox.java b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/ValueBox.java
index cd82c6622..575ce933c 100644
--- a/domino-ui/src/main/java/org/dominokit/domino/ui/forms/ValueBox.java
+++ b/domino-ui/src/main/java/org/dominokit/domino/ui/forms/ValueBox.java
@@ -28,6 +28,7 @@
 import java.util.Optional;
 import java.util.function.Consumer;
 import jsinterop.base.Js;
+import org.dominokit.domino.ui.grid.flex.FlexAlign;
 import org.dominokit.domino.ui.grid.flex.FlexItem;
 import org.dominokit.domino.ui.grid.flex.FlexLayout;
 import org.dominokit.domino.ui.style.Color;
@@ -211,7 +212,7 @@ public T setFieldStyle(FieldStyle fieldStyle) {
 
   private void layout() {
 
-    fieldInnerContainer = FlexLayout.create();
+    fieldInnerContainer = FlexLayout.create().css("field-inner-cntr");
     fieldInnerContainer.appendChild(
         inputContainer.css("field-input-cntr").setFlexGrow(1).appendChild(inputElement));
 
@@ -219,6 +220,7 @@ private void layout() {
         fieldContainer.appendChild(
             fieldInnerContainer.apply(
                 self -> {
+                  self.setAlignItems(FlexAlign.STRETCH);
                   mandatoryAddOn = createMandatoryAddOn();
                   if (nonNull(mandatoryAddOn)) {
                     self.appendChild(DominoElement.of(mandatoryAddOn).css("field-mandatory-addon"));
diff --git a/domino-ui/src/main/resources/org/dominokit/domino/ui/public/css/forms/domino-ui-forms.css b/domino-ui/src/main/resources/org/dominokit/domino/ui/public/css/forms/domino-ui-forms.css
index 7f3f3ba02..4e958f2f1 100644
--- a/domino-ui/src/main/resources/org/dominokit/domino/ui/public/css/forms/domino-ui-forms.css
+++ b/domino-ui/src/main/resources/org/dominokit/domino/ui/public/css/forms/domino-ui-forms.css
@@ -151,10 +151,15 @@
     color: #F44336;
 }
 
+.field-inner-cntr {
+    height: 100%;
+}
+
 .field-group .field-input-cntr {
     position: relative;
     background-color: inherit;
     width: 100%;
+    height:100%;
 }
 
 .field-cntr .flex-layout,
@@ -176,7 +181,7 @@
 .field-group.lined.d-select .field-cntr .flex-layout {
     position: relative;
     bottom: 4px;
-    align-items: center;
+    align-items: stretch;
 }
 
 .table-cm-filter .field-group.lined.dui-datebox .field-cntr .flex-layout,
@@ -244,7 +249,7 @@
 }
 
 .field-group .select-button {
-    height: 35px;
+    height: 100%;
     line-height: 35px;
 }