From 3085b48dc91601cb3cebcb138bd5574ed4be85d5 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Thu, 21 Nov 2024 22:13:45 +0100
Subject: [PATCH 01/45] FIX Debug v21

---
 htdocs/compta/resultat/clientfourn.php | 4 ++--
 htdocs/compta/tva/quadri_detail.php    | 8 ++++----
 htdocs/core/lib/tax.lib.php            | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/htdocs/compta/resultat/clientfourn.php b/htdocs/compta/resultat/clientfourn.php
index c300817bfa46c..efbde5c60dd69 100644
--- a/htdocs/compta/resultat/clientfourn.php
+++ b/htdocs/compta/resultat/clientfourn.php
@@ -258,9 +258,9 @@
 print '<tr class="liste_titre">';
 
 if ($modecompta == 'BOOKKEEPING') {
-	print_liste_field_titre("PredefinedGroups", $_SERVER["PHP_SELF"], 'f.thirdparty_code,f.rowid', '', $param, '', $sortfield, $sortorder, 'width200 ');
+	print_liste_field_titre("PredefinedGroups", $_SERVER["PHP_SELF"], 'f.thirdparty_code,f.rowid', '', $param, '', $sortfield, $sortorder, '');
 } else {
-	print_liste_field_titre("", $_SERVER["PHP_SELF"], '', '', $param, '', $sortfield, $sortorder, 'width200 ');
+	print_liste_field_titre("", $_SERVER["PHP_SELF"], '', '', $param, '', $sortfield, $sortorder, '');
 }
 print_liste_field_titre('');
 if ($modecompta == 'BOOKKEEPING') {
diff --git a/htdocs/compta/tva/quadri_detail.php b/htdocs/compta/tva/quadri_detail.php
index 441c6bee6cd2a..ffc0adcd26567 100644
--- a/htdocs/compta/tva/quadri_detail.php
+++ b/htdocs/compta/tva/quadri_detail.php
@@ -51,6 +51,7 @@
 $invoice_type = GETPOSTISSET('invoice_type') ? GETPOST('invoice_type', 'alpha') : '';
 $vat_rate_show = GETPOSTISSET('vat_rate_show') ? GETPOST('vat_rate_show', 'alphanohtml') : -1;
 
+// Set $date_start_xxx and $date_end_xxx...
 include DOL_DOCUMENT_ROOT . '/compta/tva/initdatesforvat.inc.php';
 
 $min = price2num(GETPOST("min", "alpha"));
@@ -299,7 +300,7 @@
 
 		foreach ($x_paye[$my_paye_rate]['facid'] as $id => $dummy) {
 			// ExpenseReport
-			if ($x_paye[$my_paye_rate]['ptype'][$id] == 'ExpenseReportPayment') {
+			if ($x_paye[$my_paye_rate]['ptype'][$id] === 'ExpenseReportPayment') {
 				$expensereport->id = $x_paye[$my_paye_rate]['facid'][$id];
 				$expensereport->ref = $x_paye[$my_paye_rate]['facnum'][$id];
 				$expensereport->type = $x_paye[$my_paye_rate]['type'][$id];
@@ -417,7 +418,7 @@
 			print "<tr>";
 			print '<td class="tax_rate" colspan="' . ($span + 1) . '">';
 			print $langs->trans('Rate') . ' : ' . vatrate($rate) . '%';
-			print ' - <a href="' . DOL_URL_ROOT . '/compta/tva/quadri_detail.php?invoice_type=customer';
+			print ' - <a class="reposition" href="' . DOL_URL_ROOT . '/compta/tva/quadri_detail.php?invoice_type=customer';
 			if ($invoice_type != 'customer' || !GETPOSTISSET('vat_rate_show') || GETPOST('vat_rate_show') != $rate) {
 				print '&amp;vat_rate_show=' . urlencode($rate);
 			}
@@ -657,7 +658,7 @@
 			print "<tr>";
 			print '<td class="tax_rate" colspan="' . ($span + 1) . '">';
 			print $langs->trans('Rate') . ' : ' . vatrate($rate) . '%';
-			print ' - <a href="' . DOL_URL_ROOT . '/compta/tva/quadri_detail.php?invoice_type=supplier';
+			print ' - <a class="reposition" href="' . DOL_URL_ROOT . '/compta/tva/quadri_detail.php?invoice_type=supplier';
 			if ($invoice_type != 'supplier' || !GETPOSTISSET('vat_rate_show') || GETPOST('vat_rate_show') != $rate) {
 				print '&amp;vat_rate_show=' . urlencode($rate);
 			}
@@ -728,7 +729,6 @@
 						$type = 1;
 					}
 
-
 					print '<tr class="oddeven">';
 
 					// Ref
diff --git a/htdocs/core/lib/tax.lib.php b/htdocs/core/lib/tax.lib.php
index 9632a893acd06..62c375ed81b15 100644
--- a/htdocs/core/lib/tax.lib.php
+++ b/htdocs/core/lib/tax.lib.php
@@ -1154,8 +1154,8 @@ function tax_by_rate($type, $db, $y, $q, $date_start, $date_end, $modetax, $dire
 		$sql = "SELECT d.rowid, d.product_type as dtype, e.rowid as facid, d.$f_rate as rate, d.vat_src_code as vat_src_code, d.total_ht as total_ht, d.total_ttc as total_ttc, d.total_tva as total_vat, e.note_private as descr,";
 		$sql .= " d.total_localtax1 as total_localtax1, d.total_localtax2 as total_localtax2, ";
 		$sql .= " e.date_debut as date_start, e.date_fin as date_end, e.fk_user_author,";
-		$sql .= " e.ref as facnum, e.total_ttc as ftotal_ttc, e.date_create, d.fk_c_type_fees as type,";
-		$sql .= " p.fk_bank as payment_id, p.amount as payment_amount, p.rowid as pid, e.ref as pref";
+		$sql .= " e.ref as facnum, e.ref as pref, e.total_ttc as ftotal_ttc, e.date_create, d.fk_c_type_fees as type,";
+		$sql .= " p.fk_bank as payment_id, p.amount as payment_amount, p.rowid as pid";
 		$sql .= " FROM ".MAIN_DB_PREFIX."expensereport as e";
 		$sql .= " LEFT JOIN ".MAIN_DB_PREFIX."expensereport_det as d ON d.fk_expensereport = e.rowid";
 		$sql .= " LEFT JOIN ".MAIN_DB_PREFIX."payment_expensereport as p ON p.fk_expensereport = e.rowid";
@@ -1178,7 +1178,7 @@ function tax_by_rate($type, $db, $y, $q, $date_start, $date_end, $modetax, $dire
 		$sql .= " AND (d.product_type = -1";
 		$sql .= " OR e.date_debut is NOT null OR e.date_fin IS NOT NULL)"; // enhance detection of service
 		if (getDolGlobalString('MAIN_NOT_INCLUDE_ZERO_VAT_IN_REPORTS')) {
-			$sql .= " AND (d.".$f_rate." <> 0 OR d.total_tva <> 0)";
+			$sql .= " AND (d.".$db->sanitize($f_rate)." <> 0 OR d.total_tva <> 0)";
 		}
 		$sql .= " ORDER BY e.rowid";
 

From ef41ebb864d36e56d39d9f45d5ad7bedbc660e12 Mon Sep 17 00:00:00 2001
From: daGrumpf <64209003+daGrumpf-bxp@users.noreply.github.com>
Date: Fri, 22 Nov 2024 13:07:23 +0100
Subject: [PATCH 02/45] PR#28448 broke qty float on xpedition same correction
 as #31794 (#32055)

---
 htdocs/expedition/card.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/htdocs/expedition/card.php b/htdocs/expedition/card.php
index d16c964d4cb87..6f5c3ed47770c 100644
--- a/htdocs/expedition/card.php
+++ b/htdocs/expedition/card.php
@@ -357,7 +357,7 @@
 				}
 			} else {
 				//shipment line for product with no batch management and no multiple stock location
-				if (GETPOSTINT($qty) > 0) {
+				if (GETPOSTFLOAT($qty) > 0) {
 					$totalqty += price2num(GETPOST($qty, 'alpha'), 'MS');
 					$subtotalqty = price2num(GETPOST($qty, 'alpha'), 'MS');
 				}
@@ -401,7 +401,7 @@
 							}
 						}
 					} else {
-						if (GETPOSTINT($qty) > 0 || getDolGlobalString('SHIPMENT_GETS_ALL_ORDER_PRODUCTS')) {
+						if (GETPOSTFLOAT($qty) > 0 || getDolGlobalString('SHIPMENT_GETS_ALL_ORDER_PRODUCTS')) {
 							$ent = "entl".$i;
 							$idl = "idl".$i;
 							$entrepot_id = is_numeric(GETPOSTINT($ent)) ? GETPOSTINT($ent) : GETPOSTINT('entrepot_id');
@@ -412,7 +412,7 @@
 								$entrepot_id = 0;
 							}
 
-							$ret = $object->addline($entrepot_id, GETPOSTINT($idl), price2num(GETPOSTINT($qty), 'MS'), $array_options[$i]);
+							$ret = $object->addline($entrepot_id, GETPOSTINT($idl), price2num(GETPOSTFLOAT($qty), 'MS'), $array_options[$i]);
 							if ($ret < 0) {
 								setEventMessages($object->error, $object->errors, 'errors');
 								$error++;
@@ -671,7 +671,7 @@
 						$batch = "batchl".$detail_batch->fk_expeditiondet."_".$detail_batch->fk_origin_stock;
 						$qty = "qtyl".$detail_batch->fk_expeditiondet.'_'.$detail_batch->id;
 						$batch_id = GETPOSTINT($batch);
-						$batch_qty = GETPOSTINT($qty);
+						$batch_qty = GETPOSTFLOAT($qty);
 						if (!empty($batch_id)) {
 							if ($lotStock->fetch($batch_id) > 0 && $line->fetch($detail_batch->fk_expeditiondet) > 0) {	// $line is ExpeditionLine
 								if ($lines[$i]->entrepot_id != 0) {
@@ -708,7 +708,7 @@
 					$batch = "batchl".$line_id."_0";
 					$qty = "qtyl".$line_id."_0";
 					$batch_id = GETPOSTINT($batch);
-					$batch_qty = GETPOSTINT($qty);
+					$batch_qty = GETPOSTFLOAT($qty);
 					$lineIdToAddLot = 0;
 					if ($batch_qty > 0 && !empty($batch_id)) {
 						if ($lotStock->fetch($batch_id) > 0) {

From a2aa730c9a09028f4fdb97a36a9f392b084f6604 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:05:45 +0100
Subject: [PATCH 03/45] Debug v21

---
 htdocs/compta/facture/prelevement.php | 1 +
 htdocs/core/class/html.form.class.php | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/htdocs/compta/facture/prelevement.php b/htdocs/compta/facture/prelevement.php
index 25eb5c6f53271..0bcfe471ea530 100644
--- a/htdocs/compta/facture/prelevement.php
+++ b/htdocs/compta/facture/prelevement.php
@@ -786,6 +786,7 @@
 					$title = $langs->trans("NewPaymentByBankTransfer");
 				}
 
+				print '<!-- for to select BAN -->';
 				print '<form method="POST" action="'.$_SERVER["PHP_SELF"].'">';
 				print '<input type="hidden" name="token" value="'.newToken().'" />';
 				print '<input type="hidden" name="id" value="'.$object->id.'" />';
diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index 218c5822d66bf..f5014e51c4dfe 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -5214,7 +5214,7 @@ public function select_comptes($selected = '', $htmlname = 'accountid', $status
 	}
 
 	/**
-	 *  Return a HTML select list of bank accounts customer
+	 * Return a HTML select list of bank accounts customer
 	 *
 	 * @param int|''	 	$selected 		Id account preselected
 	 * @param string 		$htmlname 		Name of select zone
@@ -5238,7 +5238,7 @@ public function selectRib($selected = '', $htmlname = 'ribcompanyid', $filtre =
 
 		$sql = "SELECT rowid, label, bank, status, iban_prefix, bic";
 		$sql .= " FROM " . $this->db->prefix() . "societe_rib";
-		$sql.=  " WHERE 1=1";
+		$sql.=  " WHERE type = 'ban'";
 		if ($filtre) {	// TODO Support USF
 			$sql .= " AND " . $filtre;
 		}

From 1a7b8faef4732a1ef7b32389e7dbeed34b0a6c58 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:09:44 +0100
Subject: [PATCH 04/45] Typo

---
 htdocs/compta/facture/prelevement.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/compta/facture/prelevement.php b/htdocs/compta/facture/prelevement.php
index 0bcfe471ea530..503c21af370f0 100644
--- a/htdocs/compta/facture/prelevement.php
+++ b/htdocs/compta/facture/prelevement.php
@@ -786,7 +786,7 @@
 					$title = $langs->trans("NewPaymentByBankTransfer");
 				}
 
-				print '<!-- for to select BAN -->';
+				print '<!-- form to select BAN -->';
 				print '<form method="POST" action="'.$_SERVER["PHP_SELF"].'">';
 				print '<input type="hidden" name="token" value="'.newToken().'" />';
 				print '<input type="hidden" name="id" value="'.$object->id.'" />';

From ed2353b33753456e350b86667eb6cf2eb2d62ca3 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:13:35 +0100
Subject: [PATCH 05/45] Fix typo

---
 htdocs/core/class/html.form.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index f5014e51c4dfe..4d6ad716352fe 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -5164,7 +5164,7 @@ public function select_comptes($selected = '', $htmlname = 'accountid', $status
 				if ($status == 0) {
 					$out .= '<option class="opacitymedium" value="-1">' . $langs->trans("NoActiveBankAccountDefined") . '</span>';
 				} else {
-					$out .= '<option class="opacitymedium" value="-1">' . $langs->trans("NoBankAccountFound") . '</span>';
+					$out .= '<option class="opacitymedium" value="-1">' . $langs->trans("NoBankAccountDefined") . '</span>';
 				}
 			} else {
 				if (!empty($useempty) && !is_numeric($useempty)) {

From c5ea16ad6ca4f76968256bb84fb163e69fc661e3 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:14:57 +0100
Subject: [PATCH 06/45] Fix lang

---
 htdocs/core/class/html.form.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index 4d6ad716352fe..10bcc201e4c8f 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -5138,7 +5138,7 @@ public function select_comptes($selected = '', $htmlname = 'accountid', $status
 
 		$out = '';
 
-		$langs->load("admin");
+		$langs->loadLangs(array("admin", "banks"));
 		$num = 0;
 
 		$sql = "SELECT rowid, label, bank, clos as status, currency_code";

From b9976a24294997a83134be26af8c7ed50c316565 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:18:43 +0100
Subject: [PATCH 07/45] Fix trans

---
 dev/translation/ignore_translation_keys.lst | 1 -
 htdocs/core/class/html.form.class.php       | 4 ++--
 htdocs/langs/en_US/banks.lang               | 2 +-
 htdocs/loan/card.php                        | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/dev/translation/ignore_translation_keys.lst b/dev/translation/ignore_translation_keys.lst
index d870ff1504b07..9a34c97bc3f19 100644
--- a/dev/translation/ignore_translation_keys.lst
+++ b/dev/translation/ignore_translation_keys.lst
@@ -580,7 +580,6 @@ NewProperty
 NoActiveEstablishmentDefined
 NoAddMember
 NoAuthorityURLDefined
-NoBankAccountFound
 NoCurrencyRateSelected
 NoEntriesToShow
 NoEstablishmentFound
diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index 10bcc201e4c8f..d88f4ee65b29a 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -5233,7 +5233,7 @@ public function selectRib($selected = '', $htmlname = 'ribcompanyid', $filtre =
 
 		$out = '';
 
-		$langs->load("admin");
+		$langs->loadLangs(array("admin", "banks"));
 		$num = 0;
 
 		$sql = "SELECT rowid, label, bank, status, iban_prefix, bic";
@@ -5252,7 +5252,7 @@ public function selectRib($selected = '', $htmlname = 'ribcompanyid', $filtre =
 			$out .= '<select id="select' . $htmlname . '" class="flat selectbankaccount' . ($morecss ? ' ' . $morecss : '') . '" name="' . $htmlname . '"' . ($moreattrib ? ' ' . $moreattrib : '') . '>';
 
 			if ($num == 0) {
-				$out .= '<option class="opacitymedium" value="-1">' . $langs->trans("NoBankAccountFound") . '</span>';
+				$out .= '<option class="opacitymedium" value="-1">' . $langs->trans("NoBankAccountDefined") . '</span>';
 			} else {
 				if (!empty($useempty) && !is_numeric($useempty)) {
 					$out .= '<option value="-1">'.$langs->trans($useempty).'</option>';
diff --git a/htdocs/langs/en_US/banks.lang b/htdocs/langs/en_US/banks.lang
index fc5a428396503..c382df055c0c8 100644
--- a/htdocs/langs/en_US/banks.lang
+++ b/htdocs/langs/en_US/banks.lang
@@ -188,7 +188,7 @@ BankColorizeMovementDesc=If this function is enable, you can choose specific bac
 BankColorizeMovementName1=Background color for debit movement
 BankColorizeMovementName2=Background color for credit movement
 IfYouDontReconcileDisableProperty=If you don't make the bank reconciliations on some bank accounts, disable the property "%s" on them to remove this warning.
-NoBankAccountDefined=No bank account defined
+NoBankAccountDefined=No bank account found
 NoRecordFoundIBankcAccount=No record found in bank account. Commonly, this occurs when a record has been deleted manually from the list of transaction in the bank account (for example during a reconciliation of the bank account). Another reason is that the payment was recorded when the module "%s" was disabled.
 AlreadyOneBankAccount=Already one bank account defined
 SEPAXMLPlacePaymentTypeInformationInCreditTransfertransactionInformation=SEPA file variant
diff --git a/htdocs/loan/card.php b/htdocs/loan/card.php
index 413f32e12575a..acc4c969e4d4d 100644
--- a/htdocs/loan/card.php
+++ b/htdocs/loan/card.php
@@ -53,7 +53,7 @@
  */
 
 // Load translation files required by the page
-$langs->loadLangs(array("bills", "compta", "loan"));
+$langs->loadLangs(array("banks", "bills", "compta", "loan"));
 
 $id = GETPOSTINT('id');
 $action = GETPOST('action', 'aZ09');

From 7a12b15376bfbb12c7c1cf8ec8514180c7e70ecb Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:25:05 +0100
Subject: [PATCH 08/45] Fix regression

---
 htdocs/societe/paymentmodes.php | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/htdocs/societe/paymentmodes.php b/htdocs/societe/paymentmodes.php
index 0bb7a1001fa89..3963932e622c4 100644
--- a/htdocs/societe/paymentmodes.php
+++ b/htdocs/societe/paymentmodes.php
@@ -177,8 +177,7 @@
 		}
 
 		if (!$error) {
-			$cbClassName = get_class($companybankaccount);
-			$cbClassName::$oldcopy = dol_clone($companybankaccount, 2);
+			$companybankaccount->oldcopy = dol_clone($companybankaccount, 2);
 
 			$companybankaccount->socid           = $object->id;
 
@@ -255,8 +254,7 @@
 
 		$companypaymentmode->fetch($id);
 		if (!$error) {
-			$cbClassName = get_class($companybankaccount);
-			$cbClassName::$oldcopy = dol_clone($companybankaccount, 2);
+			$companypaymentmode->oldcopy = dol_clone($companybankaccount, 2);
 
 			$companypaymentmode->fk_soc          = $object->id;
 

From 64540fe5f41e2739ba3aa63cc92acb561f0327db Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 19:34:05 +0100
Subject: [PATCH 09/45] Fix regression

---
 htdocs/societe/paymentmodes.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/societe/paymentmodes.php b/htdocs/societe/paymentmodes.php
index 3963932e622c4..5e3dfee76c3a7 100644
--- a/htdocs/societe/paymentmodes.php
+++ b/htdocs/societe/paymentmodes.php
@@ -254,7 +254,7 @@
 
 		$companypaymentmode->fetch($id);
 		if (!$error) {
-			$companypaymentmode->oldcopy = dol_clone($companybankaccount, 2);
+			$companypaymentmode->oldcopy = dol_clone($companypaymentmode, 2);
 
 			$companypaymentmode->fk_soc          = $object->id;
 

From c9d0842102933638ed87de3bbb1e1a92f93968a7 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Tue, 26 Nov 2024 21:22:41 +0100
Subject: [PATCH 10/45] Debug v21 - Placeholder management code for product is
 now completed

---
 htdocs/core/class/html.form.class.php     | 27 +++++-----
 htdocs/core/tpl/objectline_create.tpl.php | 61 +++++++++++++----------
 2 files changed, 50 insertions(+), 38 deletions(-)

diff --git a/htdocs/core/class/html.form.class.php b/htdocs/core/class/html.form.class.php
index d88f4ee65b29a..d4157ac59c001 100644
--- a/htdocs/core/class/html.form.class.php
+++ b/htdocs/core/class/html.form.class.php
@@ -2630,7 +2630,7 @@ public function select_dolresources_forevent($action = '', $htmlname = 'userid',
 	 *  @param		array<string,string|string[]>	$ajaxoptions			Options for ajax_autocompleter
 	 *  @param      int			$socid					Thirdparty Id (to get also price dedicated to this customer)
 	 *  @param		string|int<0,1>	$showempty			'' to not show empty line. Translation key to show an empty line. '1' show empty line with no text.
-	 * 	@param		int			$forcecombo				Force to use combo box
+	 * 	@param		int			$forcecombo				Force to use combo box.
 	 *  @param      string      $morecss                Add more css on select
 	 *  @param      int<0,1>	$hidepriceinlabel       1=Hide prices in label
 	 *  @param      string      $warehouseStatus        Warehouse status filter to count the quantity in stock. Following comma separated filter options can be used
@@ -2641,7 +2641,6 @@ public function select_dolresources_forevent($action = '', $htmlname = 'userid',
 	 *  @param		int<0,1> 	$nooutput				No print if 1, return the output into a string
 	 *  @param		int<-1,1>	$status_purchase		Purchase status: -1=No filter on purchase status, 0=Products not on purchase, 1=Products on purchase
 	 *  @param		int 		$warehouseId 			Filter by Warehouses Id where there is real stock
-	 *
 	 *  @return		void|string
 	 */
 	public function select_produits($selected = 0, $htmlname = 'productid', $filtertype = '', $limit = 0, $price_level = 0, $status = 1, $finished = 2, $selected_input_value = '', $hidelabel = 0, $ajaxoptions = array(), $socid = 0, $showempty = '1', $forcecombo = 0, $morecss = '', $hidepriceinlabel = 0, $warehouseStatus = '', $selected_combinations = null, $nooutput = 0, $status_purchase = -1, $warehouseId = 0)
@@ -2666,7 +2665,7 @@ public function select_produits($selected = 0, $htmlname = 'productid', $filtert
 		}
 
 		if (!empty($conf->use_javascript_ajax) && getDolGlobalString('PRODUIT_USE_SEARCH_TO_SELECT')) {
-			$placeholder = '';
+			$placeholder = (is_numeric($showempty) ? '' : 'placeholder="'.dolPrintHTML($showempty).'"');
 
 			if ($selected && empty($selected_input_value)) {
 				require_once DOL_DOCUMENT_ROOT . '/product/class/product.class.php';
@@ -2688,6 +2687,7 @@ public function select_produits($selected = 0, $htmlname = 'productid', $filtert
 			if ((int) $warehouseId > 0) {
 				$urloption .= '&warehouseid=' . (int) $warehouseId;
 			}
+
 			$out .= ajax_autocompleter((string) $selected, $htmlname, DOL_URL_ROOT . '/product/ajax/products.php', $urloption, getDolGlobalInt('PRODUIT_USE_SEARCH_TO_SELECT'), getDolGlobalInt('PRODUCT_SEARCH_AUTO_SELECT_IF_ONLY_ONE', 1), $ajaxoptions);
 
 			if (isModEnabled('variants') && is_array($selected_combinations)) {
@@ -2774,6 +2774,7 @@ public function select_produits($selected = 0, $htmlname = 'productid', $filtert
 					$out .= img_picto($langs->trans("Search"), 'search');
 				}
 			}
+
 			$out .= '<input type="text" class="minwidth100' . ($morecss ? ' ' . $morecss : '') . '" name="search_' . $htmlname . '" id="search_' . $htmlname . '" value="' . $selected_input_value . '"' . $placeholder . ' ' . (getDolGlobalString('PRODUCT_SEARCH_AUTOFOCUS') ? 'autofocus' : '') . ' />';
 			if ($hidelabel == 3) {
 				$out .= img_picto($langs->trans("Search"), 'search');
@@ -2794,16 +2795,16 @@ public function select_produits($selected = 0, $htmlname = 'productid', $filtert
 	/**
 	 *  Return list of BOM for customer in Ajax if Ajax activated or go to select_produits_list
 	 *
-	 * @param string	$selected Preselected BOM id
-	 * @param string	$htmlname Name of HTML select field (must be unique in page).
-	 * @param int		$limit Limit on number of returned lines
-	 * @param int		$status Sell status -1=Return all bom, 0=Draft BOM, 1=Validated BOM
-	 * @param int		$type type of the BOM (-1=Return all BOM, 0=Return disassemble BOM, 1=Return manufacturing BOM)
-	 * @param string|int<0,1>	$showempty	'' to not show empty line. Translation key to show an empty line. '1' show empty line with no text.
-	 * @param string	$morecss Add more css on select
-	 * @param string	$nooutput No print, return the output into a string
-	 * @param int		$forcecombo Force to use combo box
-	 * @param string[]	$TProducts Add filter on a defined product
+	 * @param string			$selected 		Preselected BOM id
+	 * @param string			$htmlname 		Name of HTML select field (must be unique in page).
+	 * @param int				$limit 			Limit on number of returned lines
+	 * @param int				$status 		Sell status -1=Return all bom, 0=Draft BOM, 1=Validated BOM
+	 * @param int				$type 			Type of the BOM (-1=Return all BOM, 0=Return disassemble BOM, 1=Return manufacturing BOM)
+	 * @param string|int<0,1>	$showempty		'' to not show empty line. Translation key to show an empty line. '1' show empty line with no text.
+	 * @param string			$morecss 		Add more css on select
+	 * @param string			$nooutput 		No print, return the output into a string
+	 * @param int				$forcecombo 	Force to use combo box
+	 * @param string[]			$TProducts 		Add filter on a defined product
 	 * @return void|string
 	 */
 	public function select_bom($selected = '', $htmlname = 'bom_id', $limit = 0, $status = 1, $type = 0, $showempty = '1', $morecss = '', $nooutput = '', $forcecombo = 0, $TProducts = [])
diff --git a/htdocs/core/tpl/objectline_create.tpl.php b/htdocs/core/tpl/objectline_create.tpl.php
index e859b3bc5f3ba..8b58ba7879bab 100644
--- a/htdocs/core/tpl/objectline_create.tpl.php
+++ b/htdocs/core/tpl/objectline_create.tpl.php
@@ -203,43 +203,48 @@
 					$forceall = 3;
 				}
 			}
+
 			// Free line
-			echo '<span class="prod_entry_mode_free">';
-			// Show radio free line
+			$labelforempty = 1;
+			print '<span class="prod_entry_mode_free">';
+			// Show radio for the non predefined product
 			if ($forceall >= 0 && (isModEnabled("product") || isModEnabled("service"))) {
-				echo '<label for="prod_entry_mode_free">';
-				echo '<input type="radio" class="prod_entry_mode_free" name="prod_entry_mode" id="prod_entry_mode_free" value="free"';
+				print '<label for="prod_entry_mode_free">';
+				print '<input type="radio" class="prod_entry_mode_free" name="prod_entry_mode" id="prod_entry_mode_free" value="free"';
 				//echo (GETPOST('prod_entry_mode')=='free' ? ' checked' : ((empty($forceall) && (!isModEnabled('product') || !isModEnabled('service')))?' checked':'') );
-				echo((GETPOST('prod_entry_mode', 'alpha') == 'free' || getDolGlobalString('MAIN_FREE_PRODUCT_CHECKED_BY_DEFAULT')) ? ' checked' : '');
-				echo '> ';
+				print((GETPOST('prod_entry_mode', 'alpha') == 'free' || getDolGlobalString('MAIN_FREE_PRODUCT_CHECKED_BY_DEFAULT')) ? ' checked' : '');
+				print '> ';
 				// Show type selector
-				echo '<span class="textradioforitem">'.$langs->trans("FreeLineOfType").'</span>';
-				echo '</label>';
-				echo ' ';
+				//print '<span class="textradioforitem">'.$langs->trans("FreeLineOfType").'</span>';
+				$labelforempty = $langs->trans("FreeLineOfType");
+				print '</label>';
+				//print ' ';
 			} else {
 				echo '<input type="hidden" id="prod_entry_mode_free" name="prod_entry_mode" value="free">';
 				// Show type selector
 				if ($forceall >= 0) {
 					if (!isModEnabled('product') || !isModEnabled('service')) {
-						echo $langs->trans("Type");
+						$labelforempty = $langs->trans("Type");
 					} else {
-						echo $langs->trans("FreeLineOfType");
+						$labelforempty = $langs->trans("FreeLineOfType");
 					}
-					echo ' ';
+					//print ' ';
 				}
 			}
-			$form->select_type_of_lines(GETPOSTISSET("type") ? GETPOST("type", 'alpha', 2) : -1, 'type', 1, 1, $forceall, '');
-			echo '</span>';
+
+			$form->select_type_of_lines(GETPOSTISSET("type") ? GETPOST("type", 'alpha', 2) : -1, 'type', $labelforempty, 1, $forceall, '');
+			print '</span>';
 		}
 		// Predefined product/service
 		if (isModEnabled("product") || isModEnabled("service")) {
+			print '<span class="nowraponall">';
 			if ($forceall >= 0 && $freelines) {
-				echo '<br><span class="prod_entry_mode_predef paddingtop">';
+				print '<br><span class="prod_entry_mode_predef paddingtop">';
 			} else {
-				echo '<span class="prod_entry_mode_predef">';
+				print '<span class="prod_entry_mode_predef">';
 			}
-			echo '<label for="prod_entry_mode_predef">';
-			echo '<input type="radio" class="prod_entry_mode_predef" name="prod_entry_mode" id="prod_entry_mode_predef" value="predef"'.(GETPOST('prod_entry_mode') == 'predef' ? ' checked' : '').'> ';
+			print '<label for="prod_entry_mode_predef">';
+			print '<input type="radio" class="prod_entry_mode_predef" name="prod_entry_mode" id="prod_entry_mode_predef" value="predef"'.(GETPOST('prod_entry_mode') == 'predef' ? ' checked' : '').'> ';
 			$labelforradio = '';
 			if (empty($conf->dol_optimize_smallscreen)) {
 				if (isModEnabled("product") && !isModEnabled('service')) {
@@ -252,9 +257,11 @@
 			} else {
 				$labelforradio = $langs->trans('PredefinedItem');
 			}
-			print '<span class="textradioforitem">'.$labelforradio.'</span>';
-			echo '</label>';
-			echo ' ';
+			if (empty($senderissupplier)) {		// TODO Move this into the placeholder
+				//print '<span class="textradioforitem">'.$labelforradio.'</span>';
+			}
+			print '</label>';
+			//print ' ';
 			$filtertype = '';
 			if (!empty($object->element) && $object->element == 'contrat' && !getDolGlobalString('CONTRACT_SUPPORT_PRODUCTS')) {
 				$filtertype = '1';
@@ -267,9 +274,9 @@
 				}
 				if (getDolGlobalString('ENTREPOT_EXTRA_STATUS')) {
 					// hide products in closed warehouse, but show products for internal transfer
-					$form->select_produits(GETPOST('idprod'), 'idprod', $filtertype, getDolGlobalInt('PRODUIT_LIMIT_SIZE'), $buyer->price_level, $statustoshow, 2, '', 1, array(), $buyer->id, '1', 0, 'maxwidth500 widthcentpercentminusx', 0, $statuswarehouse, GETPOST('combinations', 'array'));
+					$form->select_produits(GETPOST('idprod'), 'idprod', $filtertype, getDolGlobalInt('PRODUIT_LIMIT_SIZE'), $buyer->price_level, $statustoshow, 2, '', 1, array(), $buyer->id, $labelforradio, 0, 'maxwidth500 widthcentpercentminusx', 0, $statuswarehouse, GETPOST('combinations', 'array'));
 				} else {
-					$form->select_produits(GETPOST('idprod'), 'idprod', $filtertype, getDolGlobalInt('PRODUIT_LIMIT_SIZE'), $buyer->price_level, $statustoshow, 2, '', 1, array(), $buyer->id, '1', 0, 'maxwidth500 widthcentpercentminusx', 0, '', GETPOST('combinations', 'array'));
+					$form->select_produits(GETPOST('idprod'), 'idprod', $filtertype, getDolGlobalInt('PRODUIT_LIMIT_SIZE'), $buyer->price_level, $statustoshow, 2, '', 1, array(), $buyer->id, $labelforradio, 0, 'maxwidth500 widthcentpercentminusx', 0, '', GETPOST('combinations', 'array'));
 				}
 				if (getDolGlobalString('MAIN_AUTO_OPEN_SELECT2_ON_FOCUS_FOR_CUSTOMER_PRODUCTS')) {
 					?>
@@ -305,7 +312,9 @@
 					);
 					$alsoproductwithnosupplierprice = 1;
 				}
-				$form->select_produits_fournisseurs($object->socid, GETPOST('idprodfournprice'), 'idprodfournprice', '', '', $ajaxoptions, 1, $alsoproductwithnosupplierprice, 'minwidth100 maxwidth500 widthcentpercentminusx');
+
+				$form->select_produits_fournisseurs($object->socid, GETPOST('idprodfournprice'), 'idprodfournprice', '', '', $ajaxoptions, 1, $alsoproductwithnosupplierprice, 'minwidth100 maxwidth500 widthcentpercentminusx', $labelforradio);
+
 				if (getDolGlobalString('MAIN_AUTO_OPEN_SELECT2_ON_FOCUS_FOR_SUPPLIER_PRODUCTS')) {
 					?>
 				<script>
@@ -365,7 +374,9 @@
 						}
 					}
 				}
-			} ?>
+			}
+			print '</span>';
+			?>
 			<script>
 				$(document).ready(function(){
 					$("#dropdownAddProductAndService .dropdown-toggle").on("click", function(event) {

From c83d362bc17cb07468a500194cb5b774e1aa6e40 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 12:26:04 +0100
Subject: [PATCH 11/45] Fix edit of amount on public payment page

---
 htdocs/public/payment/newpayment.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/htdocs/public/payment/newpayment.php b/htdocs/public/payment/newpayment.php
index 885186e83711c..21e67dde87e50 100644
--- a/htdocs/public/payment/newpayment.php
+++ b/htdocs/public/payment/newpayment.php
@@ -1673,11 +1673,11 @@
 	if (empty($amount) && getDolGlobalString('MEMBER_NEWFORM_AMOUNT')) {
 		$amount = getDolGlobalString('MEMBER_NEWFORM_AMOUNT');
 	}
-	// - If not set, we accept to have amount defined as parameter (for backward compatibility).
-	//if (empty($amount)) {
-	//	$amount = (GETPOST('amount') ? price2num(GETPOST('amount', 'alpha'), 'MT', 2) : '');
-	//}
-	// - If a min is set, we take it into account
+	// - If a new amount was posted from the form
+	if ($caneditamount && GETPOSTISSET('newamount') && GETPOSTFLOAT('newamount', 'MT') > 0) {
+	    $amount = GETPOSTFLOAT('newamount', 'MT');
+	}
+	// - If a min is set or an amount from the posted form, we take them into account
 	$amount = max(0, (float) $amount, (float) getDolGlobalInt("MEMBER_MIN_AMOUNT"));
 
 	// Amount

From c280593d7f65b43409c475e1f776e62c2da904e4 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 16:21:23 +0100
Subject: [PATCH 12/45] Debug v21 - test if command exist

---
 dev/initdemo/initdemo.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/dev/initdemo/initdemo.sh b/dev/initdemo/initdemo.sh
index ef30d8686f169..190ee88df634d 100755
--- a/dev/initdemo/initdemo.sh
+++ b/dev/initdemo/initdemo.sh
@@ -51,6 +51,13 @@ then
 fi
 
 
+# ----------------------------- check if dialog available
+command -v dialog >/dev/null 2>&1 || {
+	echo "Error: command dialog not found. On Linux, you can install it with: apt install dialog"
+	exit
+}
+
+
 # ----------------------------- if no params on command line
 if [ "$passwd" = "" ]
 then

From 22bd6bd108ea02b053193012d010456c5702d5b8 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 16:22:17 +0100
Subject: [PATCH 13/45] Fix initdemo

---
 dev/initdemo/README.md   | 2 +-
 dev/initdemo/initdemo.sh | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/dev/initdemo/README.md b/dev/initdemo/README.md
index de796d3606601..3ec1de227f076 100644
--- a/dev/initdemo/README.md
+++ b/dev/initdemo/README.md
@@ -10,7 +10,7 @@ Init demo
 
 The script `initdemo.sh` will erase the current database with data from `dev/initdemo/mysqldump_dolibarr_x.y.z.sql` and copy files from `documents_demo` to the official document directory.
 
-You many to execute `chmod 700 initdemo.sh`
+You may need to execute `chmod 700 initdemo.sh`
 then run `./initdemo.sh` to launch the Graphical User Interface.
 
 After loading the demo files, the admin login may be one of the following:
diff --git a/dev/initdemo/initdemo.sh b/dev/initdemo/initdemo.sh
index 190ee88df634d..59a11351760d6 100755
--- a/dev/initdemo/initdemo.sh
+++ b/dev/initdemo/initdemo.sh
@@ -186,17 +186,19 @@ fi
 if [ "$passwd" != "" ]
 then
 	export passwd="-p$passwd"
+	export passwdshown="-p*****"
 fi
 #echo "mysql -P$port -u$admin $passwd $base < $mydir/$dumpfile"
 #mysql -P$port -u$admin $passwd $base < $mydir/$dumpfile
 #echo "drop old table"
+echo "drop table"
 echo "drop table if exists llx_accounting_account;" | mysql "-P$port" "-u$admin" "$passwd" "$base"
-echo "mysql -P$port -u$admin -p***** $base < '$mydir/$dumpfile'"
+echo "mysql -P$port -u$admin $passwdshown $base < '$mydir/$dumpfile'"
 mysql "-P$port" "-u$admin" "$passwd" "$base" < "$mydir/$dumpfile"
 export res=$?
 
 if [ $res -ne 0 ]; then
-	echo "Error to load database dump with mysql -P$port -u$admin -p***** $base < '$mydir/$dumpfile'"
+	echo "Error to load database dump with: mysql -P$port -u$admin $passwdshown $base < '$mydir/$dumpfile'"
 	exit
 fi
 

From 07cadc9a84217e9ac742a2e27835951dfc0c01ab Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 16:58:16 +0100
Subject: [PATCH 14/45] Debug v21

---
 htdocs/ticket/index.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/ticket/index.php b/htdocs/ticket/index.php
index 0187ae7504bbc..b3e5b8cb33228 100644
--- a/htdocs/ticket/index.php
+++ b/htdocs/ticket/index.php
@@ -404,7 +404,7 @@
 
 				// Creation date
 				print '<td class="center nowraponall">';
-				print dol_print_date($db->jdate($objp->datec), 'dayhour');
+				print dol_print_date($db->jdate($objp->datec), 'dayhourreduceformat');
 				print "</td>";
 
 				// Subject

From 82e2a87861946ea2d770066557553f884574e87e Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 17:04:04 +0100
Subject: [PATCH 15/45] Debug v21

---
 htdocs/comm/action/list.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/comm/action/list.php b/htdocs/comm/action/list.php
index 064ca39d86dfb..db077fa32a55c 100644
--- a/htdocs/comm/action/list.php
+++ b/htdocs/comm/action/list.php
@@ -308,7 +308,7 @@
 llxHeader('', $title, $help_url, '', 0, 0, '', '', '', 'bodyforlist');
 
 // Define list of all external calendars
-$listofextcals = array();
+// $listofextcals = array(); Not used yet in lists 
 
 $param = '';
 if (!empty($contextpage) && $contextpage != $_SERVER["PHP_SELF"]) {
@@ -494,7 +494,7 @@
 		} else {
 			if (is_array($actioncode)) {
 				$sql .= " AND c.code IN (".$db->sanitize("'".implode("','", $actioncode)."'", 1).")";
-			} else {
+			} elseif ($actioncode !== '-1') {
 				$sql .= " AND c.code IN (".$db->sanitize("'".implode("','", explode(',', $actioncode))."'", 1).")";
 			}
 		}

From 6d9ac0c14fc6d89aa0ae348e4a0347d6af72e5d6 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 17:09:17 +0100
Subject: [PATCH 16/45] Update README.md

---
 dev/setup/pre-commit/README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev/setup/pre-commit/README.md b/dev/setup/pre-commit/README.md
index 5dd6defd12a43..f0852e28adb9c 100644
--- a/dev/setup/pre-commit/README.md
+++ b/dev/setup/pre-commit/README.md
@@ -27,8 +27,8 @@ the project: `pre-commit-config.yaml`.
    If you do not have python installed, install [python](https://www.python.org) first.\
    `sudo apt install python3`
    
-   If you do not have [`pip`](https://pypi.org/project/pip), install that as well.\\
-    `sudo apt install pip`
+   If you do not have [`pip`](https://pypi.org/project/pip), install that as well.\
+   `sudo apt install pip`
 
    Then you can install pre-commit tool: 
    `python3 -m pip install pre-commit`

From cf026077429a6c4faa93c2062dbcb4790f3b1b9c Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 17:09:33 +0100
Subject: [PATCH 17/45] Update README.md

---
 dev/setup/pre-commit/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/setup/pre-commit/README.md b/dev/setup/pre-commit/README.md
index f0852e28adb9c..ab830e9270c32 100644
--- a/dev/setup/pre-commit/README.md
+++ b/dev/setup/pre-commit/README.md
@@ -30,7 +30,7 @@ the project: `pre-commit-config.yaml`.
    If you do not have [`pip`](https://pypi.org/project/pip), install that as well.\
    `sudo apt install pip`
 
-   Then you can install pre-commit tool: 
+   Then you can install pre-commit tool:\
    `python3 -m pip install pre-commit`
 
 2. In your local git clone of the project, run `pre-commit install` to add the hooks 

From 461d26dd0fba9430fff94042a074059571e106cc Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 18:27:10 +0100
Subject: [PATCH 18/45] Try to fix phan

---
 htdocs/core/class/commonobject.class.php | 2 +-
 htdocs/core/lib/functions.lib.php        | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 8fe7db58b7281..66f9af18511e1 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -177,7 +177,7 @@ abstract class CommonObject
 	private $linkedObjectsFullLoaded = array();
 
 	/**
-	 * @var ?static		To store a cloned copy of the object before editing it (to keep track of its former properties)
+	 * @var ?mixed		To store a cloned copy of the object before editing it (to keep track of its former properties)
 	 */
 	public $oldcopy;
 
diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index c2800d3ef84c3..275614c37a053 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -1548,11 +1548,9 @@ function dol_get_object_properties($obj, $properties = [])
  *  With native = 1: Use PHP clone. Property that are reference are same pointer. This means $this->db of new object is still valid but point to same this->db than original object.
  *  With native = 2: Property that are reference are different memory area in the new object (full isolation clone). Only scalar and array values are cloned. This means method are not availables and $this->db of new object is not valid.
  *
- *  @template T
- *
- * 	@param	T		$object		Object to clone
- *  @param	int		$native		0=Full isolation method, 1=Native PHP method, 2=Full isolation method keeping only scalar and array properties (recommended)
- *	@return T					Clone object
+ * 	@param	T		          $object		Object to clone
+ *  @param	int		          $native		0=Full isolation method, 1=Native PHP method, 2=Full isolation method keeping only scalar and array properties (recommended)
+ *	@return T                				Clone object
  *  @see https://php.net/manual/language.oop5.cloning.php
  *  @phan-suppress PhanTypeExpectedObjectPropAccess
  */

From 25a7e9ef156c86d9978d25e62a8850fe6cafb5eb Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 18:52:49 +0100
Subject: [PATCH 19/45] Try to fix phan

---
 htdocs/core/lib/functions.lib.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 275614c37a053..e091cba2db12e 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -1548,6 +1548,8 @@ function dol_get_object_properties($obj, $properties = [])
  *  With native = 1: Use PHP clone. Property that are reference are same pointer. This means $this->db of new object is still valid but point to same this->db than original object.
  *  With native = 2: Property that are reference are different memory area in the new object (full isolation clone). Only scalar and array values are cloned. This means method are not availables and $this->db of new object is not valid.
  *
+ *  @template T
+ *
  * 	@param	T		          $object		Object to clone
  *  @param	int		          $native		0=Full isolation method, 1=Native PHP method, 2=Full isolation method keeping only scalar and array properties (recommended)
  *	@return T                				Clone object

From 23ca75c27fa866c13b5461664516e71bc6581863 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 19:03:12 +0100
Subject: [PATCH 20/45] Try to fix phan

---
 .pre-commit-config.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index e6953f0457828..5969bff770f26 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -18,7 +18,7 @@ repos:
       #      git commit -a -m "My message" --no-verify
       #      (Recommendation: run git commit -a .. once, then with `--no-verify`)
       - id: no-commit-to-branch
-        args: [--branch, develop, --pattern, \d+.0]
+        args: [--branch, develop, --pattern, \d+.0,--no-color]
       # This checks that xml files are correct
       - id: check-xml
         exclude: |

From a810b9be45a4e8f5a17043c64ef7696b9e5688e4 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 19:19:25 +0100
Subject: [PATCH 21/45] Fix precommit

---
 .pre-commit-config.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 5969bff770f26..e6953f0457828 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -18,7 +18,7 @@ repos:
       #      git commit -a -m "My message" --no-verify
       #      (Recommendation: run git commit -a .. once, then with `--no-verify`)
       - id: no-commit-to-branch
-        args: [--branch, develop, --pattern, \d+.0,--no-color]
+        args: [--branch, develop, --pattern, \d+.0]
       # This checks that xml files are correct
       - id: check-xml
         exclude: |

From e901cbdfa82efeae7080fb29d1c2e42bf050166e Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 20:14:12 +0100
Subject: [PATCH 22/45] Test

---
 htdocs/core/lib/functions.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index e091cba2db12e..930f8cca6cb62 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -1591,7 +1591,7 @@ function dol_clone($object, $native = 2)
 }
 
 /**
- *	Optimize a size for some browsers (phone, smarphone, ...)
+ *	Optimize a size for some browsers (phone, smarphone...)
  *
  * 	@param	int		$size		Size we want
  * 	@param	string	$type		Type of optimizing:

From f28928daeb740cc33ce76031fb205519e2061359 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 20:29:04 +0100
Subject: [PATCH 23/45] Test

---
 htdocs/core/lib/functions.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 930f8cca6cb62..95a301141b103 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -122,7 +122,7 @@ function str_contains($haystack, $needle)
 
 
 /**
- * Return the full path of the directory where a module (or an object of a module) stores its files,
+ * Return the full path of the directory where a module (or an object of a module) stores its files.
  * Path may depends on the entity if a multicompany module is enabled.
  *
  * @param 	CommonObject 	$object 	Dolibarr common object
@@ -132,7 +132,7 @@ function str_contains($haystack, $needle)
  * @return 	string|null					The path of the relative directory of the module, ending with /
  * @since Dolibarr V18
  */
-function getMultidirOutput($object, $module = '', $forobject = 0, $mode = 'output')
+function getMultidirOutput($object, $odule = '', $forobject = 0, $mode = 'output')
 {
 	global $conf;
 

From 10bc40dbb659428d61c1d4760d792036f883628c Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:00:49 +0100
Subject: [PATCH 24/45] Update README.md

---
 dev/setup/pre-commit/README.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dev/setup/pre-commit/README.md b/dev/setup/pre-commit/README.md
index ab830e9270c32..d4bbb8013f553 100644
--- a/dev/setup/pre-commit/README.md
+++ b/dev/setup/pre-commit/README.md
@@ -96,4 +96,6 @@ CI also runs pre-commit to help maintain code quality.
 
 Note:
 Code for precommits are saved into:
+.cache/pre-commit/repo*/pre_commit_hooks/php-*.sh
+and
 .cache/pre-commit/repo*/py_env-python3/lib/python*/site-packages/pre_commit_hooks/no_commit_to_branch.py

From 998da221a2f489c42f5ad03a96361f7e12628f92 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:03:30 +0100
Subject: [PATCH 25/45] Test

---
 htdocs/core/lib/functions.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 95a301141b103..07afd265d8ca3 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -1,7 +1,7 @@
 <?php
 /* Copyright (C) 2000-2007	Rodolphe Quiedeville		<rodolphe@quiedeville.org>
  * Copyright (C) 2003		Jean-Louis Bergamo			<jlb@j1b.org>
- * Copyright (C) 2004-2022	Laurent Destailleur			<eldy@users.sourceforge.net>
+ * Copyright (C) 2004-2024	Laurent Destailleur			<eldy@users.sourceforge.net>
  * Copyright (C) 2004		Sebastien Di Cintio			<sdicintio@ressource-toi.org>
  * Copyright (C) 2004		Benoit Mortier				<benoit.mortier@opensides.be>
  * Copyright (C) 2004		Christophe Combelles		<ccomb@free.fr>
@@ -132,7 +132,7 @@ function str_contains($haystack, $needle)
  * @return 	string|null					The path of the relative directory of the module, ending with /
  * @since Dolibarr V18
  */
-function getMultidirOutput($object, $odule = '', $forobject = 0, $mode = 'output')
+function getMultidirOutput($object, $module = '', $forobject = 0, $mode = 'output')
 {
 	global $conf;
 

From 92c1af15a7ed59af3bb55448cf1484cebf724f3c Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:03:59 +0100
Subject: [PATCH 26/45] Test

---
 htdocs/core/lib/functions.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 07afd265d8ca3..01e906dbc5402 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -125,7 +125,7 @@ function str_contains($haystack, $needle)
  * Return the full path of the directory where a module (or an object of a module) stores its files.
  * Path may depends on the entity if a multicompany module is enabled.
  *
- * @param 	CommonObject 	$object 	Dolibarr common object
+ * @param 	CommonObject 	$object 	Dolibarr common object.
  * @param 	string 			$module 	Override object element, for example to use 'mycompany' instead of 'societe'
  * @param	int				$forobject	Return the more complete path for the given object instead of for the module only.
  * @param	string			$mode		'output' (full main dir) or 'outputrel' (relative dir) or 'temp' (for temporary files) or 'version' (dir for archived files)

From fbb4c3d0257b5e5ee575dc8bb287ca588af80121 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:11:28 +0100
Subject: [PATCH 27/45] Try to fix phan

---
 htdocs/adherents/class/adherent.class.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index 7ad5ee54ee71b..96e9d4f052885 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -830,6 +830,8 @@ public function update($user, $notrigger = 0, $nosyncuser = 0, $nosyncuserpass =
 		$sql .= " WHERE rowid = ".((int) $this->id);
 
 		// If we change the type of membership, we set also label of new type
+		'@phan-var-force Adherent $oldcopy';
+		/** @var Adherent $oldcopy */
 		if (!empty($this->oldcopy) && $this->typeid != $this->oldcopy->typeid) {
 			$sql2 = "SELECT libelle as label";
 			$sql2 .= " FROM ".MAIN_DB_PREFIX."adherent_type";

From ea9f88a58380be705151a1ab5b808aa77d35c419 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:17:51 +0100
Subject: [PATCH 28/45] Merge branch 'develop' of
 git@github.com:Dolibarr/dolibarr.git into develop

---
 htdocs/comm/action/list.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/comm/action/list.php b/htdocs/comm/action/list.php
index db077fa32a55c..475c580400ffb 100644
--- a/htdocs/comm/action/list.php
+++ b/htdocs/comm/action/list.php
@@ -308,7 +308,7 @@
 llxHeader('', $title, $help_url, '', 0, 0, '', '', '', 'bodyforlist');
 
 // Define list of all external calendars
-// $listofextcals = array(); Not used yet in lists 
+// $listofextcals = array(); Not used yet in lists
 
 $param = '';
 if (!empty($contextpage) && $contextpage != $_SERVER["PHP_SELF"]) {

From a6e8fbc89929cf198a5ad04128257c4fd9c3e76e Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:26:23 +0100
Subject: [PATCH 29/45] Test

---
 htdocs/adherents/class/adherent.class.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index 96e9d4f052885..2b28e9487cd95 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -830,8 +830,8 @@ public function update($user, $notrigger = 0, $nosyncuser = 0, $nosyncuserpass =
 		$sql .= " WHERE rowid = ".((int) $this->id);
 
 		// If we change the type of membership, we set also label of new type
-		'@phan-var-force Adherent $oldcopy';
-		/** @var Adherent $oldcopy */
+		'@phan-var-force Adherent $this->oldcopy';
+		/** @var Adherent $this->oldcopy */
 		if (!empty($this->oldcopy) && $this->typeid != $this->oldcopy->typeid) {
 			$sql2 = "SELECT libelle as label";
 			$sql2 .= " FROM ".MAIN_DB_PREFIX."adherent_type";

From c1d6e0411c548f061e09125b91c78e1e4c6ae80a Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:31:14 +0100
Subject: [PATCH 30/45] Test

---
 htdocs/adherents/class/adherent.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index 2b28e9487cd95..ca9dd3b295bdf 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -829,7 +829,7 @@ public function update($user, $notrigger = 0, $nosyncuser = 0, $nosyncuserpass =
 		$sql .= ", fk_user_mod = ".($user->id > 0 ? $user->id : 'null'); // Can be null because member can be create by a guest
 		$sql .= " WHERE rowid = ".((int) $this->id);
 
-		// If we change the type of membership, we set also label of new type
+		// If we change the type of membership, we set also label of new type.
 		'@phan-var-force Adherent $this->oldcopy';
 		/** @var Adherent $this->oldcopy */
 		if (!empty($this->oldcopy) && $this->typeid != $this->oldcopy->typeid) {

From 6eb8870992b2709e120eb2a931d0595da25958e6 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:35:48 +0100
Subject: [PATCH 31/45] Test

---
 htdocs/adherents/class/adherent.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index ca9dd3b295bdf..ab1287a07dd6c 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -43,7 +43,7 @@
 
 
 /**
- *		Class to manage members of a foundation
+ *		Class to manage members of a foundation.
  */
 class Adherent extends CommonObject
 {

From 13ad68d8bff91fec27143c71c04d2cd19e1f6fdd Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:46:16 +0100
Subject: [PATCH 32/45] Try fix phan phpstan

---
 htdocs/adherents/class/adherent.class.php | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index ab1287a07dd6c..486f1b1295ff7 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -315,6 +315,11 @@ class Adherent extends CommonObject
 	 */
 	public $invoice;
 
+	/**
+	 * @var Adherent	To store a copy before update or delete
+	 */
+	public $oldcopy;
+
 
 	/**
 	 * @var array<string,array{type:string,label:string,enabled:int<0,2>|string,position:int,notnull?:int,visible:int<-2,5>|string,noteditable?:int<0,1>,default?:string,index?:int,foreignkey?:string,searchall?:int<0,1>,isameasure?:int<0,1>,css?:string,csslist?:string,help?:string,showoncombobox?:int<0,2>,disabled?:int<0,1>,arrayofkeyval?:array<int|string,string>,comment?:string,validate?:int<0,1>}>  Array with all fields and their property. Do not use it as a static var. It may be modified by constructor.
@@ -829,9 +834,8 @@ public function update($user, $notrigger = 0, $nosyncuser = 0, $nosyncuserpass =
 		$sql .= ", fk_user_mod = ".($user->id > 0 ? $user->id : 'null'); // Can be null because member can be create by a guest
 		$sql .= " WHERE rowid = ".((int) $this->id);
 
-		// If we change the type of membership, we set also label of new type.
-		'@phan-var-force Adherent $this->oldcopy';
-		/** @var Adherent $this->oldcopy */
+		// If we change the type of membership, we set also label of new type..
+		'@phan-var-force Adherent $oldcopy';
 		if (!empty($this->oldcopy) && $this->typeid != $this->oldcopy->typeid) {
 			$sql2 = "SELECT libelle as label";
 			$sql2 .= " FROM ".MAIN_DB_PREFIX."adherent_type";

From 353633cef8e4d5ec614a4ed011f90c03683db702 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Wed, 27 Nov 2024 21:59:20 +0100
Subject: [PATCH 33/45] Revert to use instead #32123

---
 htdocs/adherents/class/adherent.class.php | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index 486f1b1295ff7..95cfbe2e55e05 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -315,11 +315,6 @@ class Adherent extends CommonObject
 	 */
 	public $invoice;
 
-	/**
-	 * @var Adherent	To store a copy before update or delete
-	 */
-	public $oldcopy;
-
 
 	/**
 	 * @var array<string,array{type:string,label:string,enabled:int<0,2>|string,position:int,notnull?:int,visible:int<-2,5>|string,noteditable?:int<0,1>,default?:string,index?:int,foreignkey?:string,searchall?:int<0,1>,isameasure?:int<0,1>,css?:string,csslist?:string,help?:string,showoncombobox?:int<0,2>,disabled?:int<0,1>,arrayofkeyval?:array<int|string,string>,comment?:string,validate?:int<0,1>}>  Array with all fields and their property. Do not use it as a static var. It may be modified by constructor.

From 13b8f5feffc4edeaa769507933bb4e1e0936908f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?=
 <frederic34@users.noreply.github.com>
Date: Wed, 27 Nov 2024 21:59:41 +0100
Subject: [PATCH 34/45] keep only commonobject property oldcopy (#32123)

* clean properties

* clean properties

* clean properties

* clean properties

* clean phpcs

* clean phan

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
---
 build/phpstan/phpstan-baseline.neon             | 6 ------
 htdocs/asset/class/asset.class.php              | 6 ------
 htdocs/comm/propal/class/propal.class.php       | 5 -----
 htdocs/compta/facture/class/facture.class.php   | 5 -----
 htdocs/contact/class/contact.class.php          | 7 -------
 htdocs/core/class/comment.class.php             | 5 -----
 htdocs/core/class/commonobject.class.php        | 2 +-
 htdocs/product/class/product.class.php          | 5 -----
 htdocs/product/stock/class/productlot.class.php | 4 ----
 htdocs/product/stock/movement_list.php          | 3 +--
 htdocs/projet/class/project.class.php           | 5 -----
 htdocs/public/payment/newpayment.php            | 2 +-
 htdocs/resource/class/dolresource.class.php     | 5 -----
 htdocs/societe/class/societe.class.php          | 5 -----
 htdocs/societe/paymentmodes.php                 | 6 +++---
 htdocs/ticket/class/ticket.class.php            | 6 ------
 htdocs/user/class/user.class.php                | 5 -----
 htdocs/user/class/usergroup.class.php           | 5 -----
 18 files changed, 6 insertions(+), 81 deletions(-)

diff --git a/build/phpstan/phpstan-baseline.neon b/build/phpstan/phpstan-baseline.neon
index d8806427808e7..027b03a0df4bc 100644
--- a/build/phpstan/phpstan-baseline.neon
+++ b/build/phpstan/phpstan-baseline.neon
@@ -27870,12 +27870,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/product/stock/movement_list.php
 
-		-
-			message: '#^Variable \$whClass might not be defined\.$#'
-			identifier: variable.undefined
-			count: 1
-			path: ../../htdocs/product/stock/movement_list.php
-
 		-
 			message: '#^If condition is always false\.$#'
 			identifier: if.alwaysFalse
diff --git a/htdocs/asset/class/asset.class.php b/htdocs/asset/class/asset.class.php
index ca2060ac4b207..6454ef43b84f8 100644
--- a/htdocs/asset/class/asset.class.php
+++ b/htdocs/asset/class/asset.class.php
@@ -231,12 +231,6 @@ class Asset extends CommonObject
 	 */
 	public $status;
 
-	/**
-	 * @var static object oldcopy
-	 */
-	public $oldcopy;
-
-
 	/**
 	 * @var AssetDepreciationOptions	Used for computed fields of depreciation options class.
 	 */
diff --git a/htdocs/comm/propal/class/propal.class.php b/htdocs/comm/propal/class/propal.class.php
index ac6d62da82cfd..57e8bb3b0b9b2 100644
--- a/htdocs/comm/propal/class/propal.class.php
+++ b/htdocs/comm/propal/class/propal.class.php
@@ -122,11 +122,6 @@ class Propal extends CommonObject
 	 */
 	public $ref_customer;
 
-	/**
-	 * @var static oldcopy with propal properties
-	 */
-	public $oldcopy;
-
 	/**
 	 * Status of the quote
 	 * @var int
diff --git a/htdocs/compta/facture/class/facture.class.php b/htdocs/compta/facture/class/facture.class.php
index e63c86551cc69..7f7eb71398b8c 100644
--- a/htdocs/compta/facture/class/facture.class.php
+++ b/htdocs/compta/facture/class/facture.class.php
@@ -248,11 +248,6 @@ class Facture extends CommonInvoice
 	 */
 	public $tab_next_situation_invoice = array();
 
-	/**
-	 * @var static object oldcopy
-	 */
-	public $oldcopy;
-
 	/**
 	 * @var float percentage of retainage
 	 */
diff --git a/htdocs/contact/class/contact.class.php b/htdocs/contact/class/contact.class.php
index 5fc553e999434..410ea6093183a 100644
--- a/htdocs/contact/class/contact.class.php
+++ b/htdocs/contact/class/contact.class.php
@@ -343,13 +343,6 @@ class Contact extends CommonObject
 	public $ip;
 	// END MODULEBUILDER PROPERTIES
 
-
-	/**
-	 * Old copy
-	 * @var static
-	 */
-	public $oldcopy; // To contain a clone of this when we need to save old properties of object
-
 	/**
 	 * @var array<int,array{id:int,socid:int,element:string,source:string,code:string,label:string}> roles
 	 */
diff --git a/htdocs/core/class/comment.class.php b/htdocs/core/class/comment.class.php
index c1e3f61379d23..9bb732e0a4269 100644
--- a/htdocs/core/class/comment.class.php
+++ b/htdocs/core/class/comment.class.php
@@ -76,11 +76,6 @@ class Comment extends CommonObject
 
 	public $comments = array();
 
-	/**
-	 * @var static 	Object oldcopy
-	 */
-	public $oldcopy;
-
 
 	/**
 	 *  Constructor
diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 66f9af18511e1..8fe7db58b7281 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -177,7 +177,7 @@ abstract class CommonObject
 	private $linkedObjectsFullLoaded = array();
 
 	/**
-	 * @var ?mixed		To store a cloned copy of the object before editing it (to keep track of its former properties)
+	 * @var ?static		To store a cloned copy of the object before editing it (to keep track of its former properties)
 	 */
 	public $oldcopy;
 
diff --git a/htdocs/product/class/product.class.php b/htdocs/product/class/product.class.php
index 0eff9ebfbd320..558a6e285b6b0 100644
--- a/htdocs/product/class/product.class.php
+++ b/htdocs/product/class/product.class.php
@@ -71,11 +71,6 @@ class Product extends CommonObject
 	 */
 	public $fk_element = 'fk_product';
 
-	/**
-	 * @var static
-	 */
-	public $oldcopy;
-
 	/**
 	 * @var array<string, array<string>>	List of child tables. To test if we can delete object.
 	 */
diff --git a/htdocs/product/stock/class/productlot.class.php b/htdocs/product/stock/class/productlot.class.php
index 61e7daeef71e5..86bd74c950343 100644
--- a/htdocs/product/stock/class/productlot.class.php
+++ b/htdocs/product/stock/class/productlot.class.php
@@ -848,7 +848,6 @@ public function createFromClone(User $user, $fromid)
 	 */
 	public function loadStatsExpedition($socid = 0)
 	{
-		// phpcs:enable
 		global $user, $hookmanager, $action;
 
 		$sql = "SELECT COUNT(DISTINCT exp.fk_soc) as nb_customers, COUNT(DISTINCT exp.rowid) as nb,";
@@ -923,7 +922,6 @@ public function loadStatsExpedition($socid = 0)
 	 */
 	public function loadStatsSupplierOrder($socid = 0)
 	{
-		// phpcs:enable
 		global $user, $hookmanager, $action;
 
 		$sql = "SELECT COUNT(DISTINCT cf.fk_soc) as nb_customers, COUNT(DISTINCT cf.rowid) as nb,";
@@ -998,7 +996,6 @@ public function loadStatsSupplierOrder($socid = 0)
 	 */
 	public function loadStatsReception($socid = 0)
 	{
-		// phpcs:enable
 		global $user, $hookmanager, $action;
 
 		$sql = "SELECT COUNT(DISTINCT recep.fk_soc) as nb_customers, COUNT(DISTINCT recep.rowid) as nb,";
@@ -1072,7 +1069,6 @@ public function loadStatsReception($socid = 0)
 	 */
 	public function loadStatsMo($socid = 0)
 	{
-		// phpcs:enable
 		global $user, $hookmanager, $action;
 
 		$error = 0;
diff --git a/htdocs/product/stock/movement_list.php b/htdocs/product/stock/movement_list.php
index 86986da7ed437..e5cabbe26d51b 100644
--- a/htdocs/product/stock/movement_list.php
+++ b/htdocs/product/stock/movement_list.php
@@ -333,8 +333,7 @@
 }
 
 if ($action == 'update_extras' && $permissiontoadd) {
-	$whClass = get_class($whClass);
-	$whClass::$oldcopy = dol_clone($tmpwarehouse, 2);
+	$tmpwarehouse->oldcopy = dol_clone($tmpwarehouse, 2);  // @phan-suppress-current-line PhanTypeMismatchProperty
 
 	// Fill array 'array_options' with data from update form
 	$ret = $extrafields->setOptionalsFromPost(null, $tmpwarehouse, GETPOST('attribute', 'restricthtml'));
diff --git a/htdocs/projet/class/project.class.php b/htdocs/projet/class/project.class.php
index d1cdb65323498..993e6a07e68bc 100644
--- a/htdocs/projet/class/project.class.php
+++ b/htdocs/projet/class/project.class.php
@@ -246,11 +246,6 @@ class Project extends CommonObject
 	 */
 	public $email_msgid;
 
-	/**
-	 * @var ?static
-	 */
-	public $oldcopy;
-
 	/**
 	 * @var array<int,int> Used to store workload details of a projet (array[day])
 	 */
diff --git a/htdocs/public/payment/newpayment.php b/htdocs/public/payment/newpayment.php
index aef2adf13efc0..6549601154234 100644
--- a/htdocs/public/payment/newpayment.php
+++ b/htdocs/public/payment/newpayment.php
@@ -1707,7 +1707,7 @@
 	}
 	// - If a new amount was posted from the form
 	if ($caneditamount && GETPOSTISSET('newamount') && GETPOSTFLOAT('newamount', 'MT') > 0) {
-	    $amount = GETPOSTFLOAT('newamount', 'MT');
+		$amount = GETPOSTFLOAT('newamount', 'MT');
 	}
 	// - If a min is set or an amount from the posted form, we take them into account
 	$amount = max(0, (float) $amount, (float) getDolGlobalInt("MEMBER_MIN_AMOUNT"));
diff --git a/htdocs/resource/class/dolresource.class.php b/htdocs/resource/class/dolresource.class.php
index 40955b2f77c31..75a96e391f61c 100644
--- a/htdocs/resource/class/dolresource.class.php
+++ b/htdocs/resource/class/dolresource.class.php
@@ -131,11 +131,6 @@ class Dolresource extends CommonObject
 	 */
 	public $cache_code_type_resource;
 
-	/**
-	 * @var static Clone of object before changing it
-	 */
-	public $oldcopy;
-
 
 	/**
 	 *  Constructor
diff --git a/htdocs/societe/class/societe.class.php b/htdocs/societe/class/societe.class.php
index 5c244c10b62e2..e1e66ac6edfe1 100644
--- a/htdocs/societe/class/societe.class.php
+++ b/htdocs/societe/class/societe.class.php
@@ -133,11 +133,6 @@ class Societe extends CommonObject
 	 */
 	public $restrictiononfksoc = 1;
 
-	/**
-	 * @var static To store a cloned copy of object before to edit it and keep track of old properties
-	 */
-	public $oldcopy;
-
 	/**
 	 * array of supplier categories
 	 * @var string[]
diff --git a/htdocs/societe/paymentmodes.php b/htdocs/societe/paymentmodes.php
index 5e3dfee76c3a7..595943b584568 100644
--- a/htdocs/societe/paymentmodes.php
+++ b/htdocs/societe/paymentmodes.php
@@ -177,7 +177,7 @@
 		}
 
 		if (!$error) {
-			$companybankaccount->oldcopy = dol_clone($companybankaccount, 2);
+			$companybankaccount->oldcopy = dol_clone($companybankaccount, 2);  // @phan-suppress-current-line PhanTypeMismatchProperty
 
 			$companybankaccount->socid           = $object->id;
 
@@ -254,7 +254,7 @@
 
 		$companypaymentmode->fetch($id);
 		if (!$error) {
-			$companypaymentmode->oldcopy = dol_clone($companypaymentmode, 2);
+			$companypaymentmode->oldcopy = dol_clone($companypaymentmode, 2);  // @phan-suppress-current-line PhanTypeMismatchProperty
 
 			$companypaymentmode->fk_soc          = $object->id;
 
@@ -311,7 +311,7 @@
 			// Ajout
 			$companybankaccount = new CompanyBankAccount($db);
 
-			$companybankaccount->socid           = $object->id;
+			$companybankaccount->socid = $object->id;
 
 			$companybankaccount->fetch_thirdparty();
 
diff --git a/htdocs/ticket/class/ticket.class.php b/htdocs/ticket/class/ticket.class.php
index 848abcb41517b..56cfb53ef9a94 100644
--- a/htdocs/ticket/class/ticket.class.php
+++ b/htdocs/ticket/class/ticket.class.php
@@ -246,17 +246,11 @@ class Ticket extends CommonObject
 	 */
 	public $ip;
 
-	/**
-	 * @var static 	Save the ticket before an update operation (for triggers)
-	 */
-	public $oldcopy;
-
 	/**
 	 * @var Ticket[] Array of Tickets
 	 */
 	public $lines;
 
-
 	/**
 	 * @var string Regex pour les images
 	 */
diff --git a/htdocs/user/class/user.class.php b/htdocs/user/class/user.class.php
index f0b2ea132fa83..975cbefb98aeb 100644
--- a/htdocs/user/class/user.class.php
+++ b/htdocs/user/class/user.class.php
@@ -75,11 +75,6 @@ class User extends CommonObject
 	 */
 	public $id = 0;
 
-	/**
-	 * @var static old copy of User
-	 */
-	public $oldcopy;
-
 	/**
 	 * @var int
 	 * @deprecated Use $status
diff --git a/htdocs/user/class/usergroup.class.php b/htdocs/user/class/usergroup.class.php
index e5232ca2e4ba3..f885c05951d46 100644
--- a/htdocs/user/class/usergroup.class.php
+++ b/htdocs/user/class/usergroup.class.php
@@ -125,11 +125,6 @@ class UserGroup extends CommonObject
 	 */
 	public $all_permissions_are_loaded;
 
-	/**
-	 * @var static
-	 */
-	public $oldcopy; // To contains a clone of this when we need to save old properties of object
-
 	public $fields = array(
 		'rowid' => array('type' => 'integer', 'label' => 'TechnicalID', 'enabled' => 1, 'visible' => -2, 'notnull' => 1, 'index' => 1, 'position' => 1, 'comment' => 'Id'),
 		'entity' => array('type' => 'integer', 'label' => 'Entity', 'enabled' => 1, 'visible' => 0, 'notnull' => 1, 'default' => '1', 'index' => 1, 'position' => 5),

From d2d592ebd6236fc825e9c5557b12ab4ad2ddf8e4 Mon Sep 17 00:00:00 2001
From: David Beniamine <david.beniamine@tetras-libre.fr>
Date: Wed, 27 Nov 2024 22:03:41 +0100
Subject: [PATCH 35/45] Make sure that thirdparty is actually loaded before
 using it's country for lang (#32107)

---
 htdocs/adherents/class/adherent.class.php | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/htdocs/adherents/class/adherent.class.php b/htdocs/adherents/class/adherent.class.php
index 95cfbe2e55e05..eee7fde0377f4 100644
--- a/htdocs/adherents/class/adherent.class.php
+++ b/htdocs/adherents/class/adherent.class.php
@@ -3105,11 +3105,14 @@ public function sendReminderForExpiredSubscription($daysbeforeendlist = '10', $f
 						$nbko++;
 						$listofmembersko[$adherent->id] = $adherent->id;
 					} else {
-						$adherent->fetch_thirdparty();
-
-						// Language code to use ($languagecodeformember) is default language of thirdparty, if no thirdparty, the language found from country of member then country of thirdparty, and if still not found we use the language of company.
-						$languagefromcountrycode = getLanguageCodeFromCountryCode($adherent->country_code ? $adherent->country_code : $adherent->thirdparty->country_code);
-						$languagecodeformember = (empty($adherent->thirdparty->default_lang) ? ($languagefromcountrycode ? $languagefromcountrycode : $mysoc->default_lang) : $adherent->thirdparty->default_lang);
+						$thirdpartyres = $adherent->fetch_thirdparty();
+						if ($thirdpartyres === -1 ) {
+							$languagecodeformember = $mysoc->default_lang;
+						} else {
+							// Language code to use ($languagecodeformember) is default language of thirdparty, if no thirdparty, the language found from country of member then country of thirdparty, and if still not found we use the language of company.
+							$languagefromcountrycode = getLanguageCodeFromCountryCode($adherent->country_code ? $adherent->country_code : $adherent->thirdparty->country_code);
+							$languagecodeformember = (empty($adherent->thirdparty->default_lang) ? ($languagefromcountrycode ? $languagefromcountrycode : $mysoc->default_lang) : $adherent->thirdparty->default_lang);
+						}
 
 						// Send reminder email
 						$outputlangs = new Translate('', $conf);

From d434cd4b50e77fd1ccecdbfefdac68a9027ed62d Mon Sep 17 00:00:00 2001
From: Zephyriony <142790847+zephyriony@users.noreply.github.com>
Date: Thu, 28 Nov 2024 11:06:44 +0100
Subject: [PATCH 36/45] FIX Bug page_y url (#32119)

* FIX Bug page_y url

In some cases, 'reposition' modified the url by assigning variables other than page_y, for example :
https://XXX/ticket/card.php?id=2158&action=dellink&token=e88288a7e4488ebafb81a80fa5f58913&dellinkid=20308.60009765625.60009765625&page_y=2113.60009765625

* Update lib_foot.js.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
---
 htdocs/core/js/lib_foot.js.php | 60 ++++++++++++++++------------------
 1 file changed, 28 insertions(+), 32 deletions(-)

diff --git a/htdocs/core/js/lib_foot.js.php b/htdocs/core/js/lib_foot.js.php
index 7bf2a7eff0de7..11ddbf7fbe513 100644
--- a/htdocs/core/js/lib_foot.js.php
+++ b/htdocs/core/js/lib_foot.js.php
@@ -242,38 +242,34 @@
 // Code to manage reposition
 print "\n/* JS CODE TO ENABLE reposition management (does not work if a redirect is done after action of submission) */\n";
 print '
-	jQuery(document).ready(function() {
-				/* If page_y set, we set scrollbar with it */
-				page_y=getParameterByName(\'page_y\', 0);				/* search in GET parameter */
-				if (page_y == 0) page_y = jQuery("#page_y").text();		/* search in POST parameter that is filed at bottom of page */
-				if (page_y > 0)
-				{
-					console.log("page_y found is "+page_y);
-					$(\'html, body\').scrollTop(page_y);
-				}
-
-				/* Set handler to add page_y param on output (click on href links or submit button) */
-				jQuery(".reposition").click(function() {
-					var page_y = $(document).scrollTop();
-
-					if (page_y > 0)
-					{
-						if (this.href)
-						{
-							console.log("We click on tag with .reposition class. this.ref was "+this.href);
-							var hrefarray = this.href.split("#", 2);
-							hrefarray[0]=hrefarray[0].replace(/&page_y=(\d+)/, \'\');		/* remove page_y param if already present */
-							this.href=hrefarray[0]+\'&page_y=\'+page_y;
-							console.log("We click on tag with .reposition class. this.ref is now "+this.href);
-						}
-						else
-						{
-							console.log("We click on tag with .reposition class but element is not an <a> html tag, so we try to update input form field with name=page_y with value "+page_y);
-							jQuery("input[type=hidden][name=page_y]").val(page_y);
-						}
-					}
-				});
-	});'."\n";
+    jQuery(document).ready(function() {
+		/* If page_y set, we set scrollbar with it */
+        page_y = getParameterByName("page_y", 0);				/* search in GET parameter */
+        if (page_y == 0) page_y = jQuery("#page_y").text();		/* search in POST parameter that is filed at bottom of page */
+        if (page_y > 0) {
+			console.log("page_y found is "+page_y);
+            jQuery("html, body").scrollTop(page_y);
+        }
+
+		/* Set handler to add page_y param on output (click on href links or submit button) */
+        jQuery(".reposition").click(function(event) {
+            var page_y = jQuery(document).scrollTop();
+            if (page_y > 0) {
+                if (this.href) {
+					console.log("We click on tag with .reposition class. this.ref was "+this.href);
+                    var url = new URL(this.href, window.location.origin);
+                    url.searchParams.delete("page_y");		/* remove page_y param if already present */
+                    url.searchParams.set("page_y", page_y);
+                    this.href = url.toString();
+					console.log("We click on tag with .reposition class. this.ref is now "+this.href);
+                } else {
+					console.log("We click on tag with .reposition class but element is not an <a> html tag, so we try to update input form field with name=page_y with value "+page_y);
+                    jQuery("input[type=hidden][name=page_y]").val(page_y);
+                }
+            }
+        });
+    });
+' . "\n";
 
 // Code to manage Copy To Clipboard click
 print "\n/* JS CODE TO ENABLE ClipBoard copy paste */\n";

From fc0e5c510ff5b9ff31b5aaf39a5aec3b20550fbf Mon Sep 17 00:00:00 2001
From: Francis Appels <francis.appels@yahoo.com>
Date: Thu, 28 Nov 2024 11:07:15 +0100
Subject: [PATCH 37/45] Fix upgrade2, migrate_productlot_path() need $user.
 (#32125)

* Fix upgrade2, migrate_productlot_path() need $user.

* Fix stan

* Revert "Fix stan"

This reverts commit 5fff7013d32c8601911833c0f9a12852f787a4cf.

* Revert "Fix upgrade2, migrate_productlot_path() need $user."

This reverts commit faf40eeab4e9835a84020c253ba221c54679e890.

* Fix upgrade2, migrate_productlot_path() need $user.
---
 htdocs/install/upgrade2.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/htdocs/install/upgrade2.php b/htdocs/install/upgrade2.php
index 507cf9cdc414c..c612d5367f8c4 100644
--- a/htdocs/install/upgrade2.php
+++ b/htdocs/install/upgrade2.php
@@ -4401,6 +4401,11 @@ function migrate_productlot_path()
 {
 	global $conf, $db, $langs, $user;
 
+	if (!is_object($user)) {
+		include_once DOL_DOCUMENT_ROOT.'/user/class/user.class.php';
+		$user = new User($db);	// To avoid error during migration
+	}
+
 	print '<tr><td colspan="4">';
 
 	print '<b>'.$langs->trans('MigrationProductLotPath')."</b><br>\n";

From 38da445ff73e290d7ba4b9aa000835d0f5419ab9 Mon Sep 17 00:00:00 2001
From: Zephyriony <142790847+zephyriony@users.noreply.github.com>
Date: Thu, 28 Nov 2024 11:08:50 +0100
Subject: [PATCH 38/45] FIX loading object (#32114)

Useless and unoptimized code:

- Object already loaded at top of page, reloads a second time
- Prevents object from being loaded with doActions hook, since it overwrites it
---
 htdocs/compta/facture/card.php | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/htdocs/compta/facture/card.php b/htdocs/compta/facture/card.php
index 251485126bb94..027443ade23f4 100644
--- a/htdocs/compta/facture/card.php
+++ b/htdocs/compta/facture/card.php
@@ -4254,15 +4254,6 @@ function setRadioForTypeOfInvoice() {
 	 * Show object in view mode
 	 */
 
-	$result = $object->fetch($id, $ref);
-	if ($result <= 0) {
-		dol_print_error($db, $object->error, $object->errors);
-		exit();
-	}
-
-	// fetch optionals attributes and labels
-	$extrafields->fetch_name_optionals_label($object->table_element);
-
 	if ($user->socid > 0 && $user->socid != $object->socid) {
 		accessforbidden('', 0, 1);
 	}

From 1b6ee9e6542ae3c94f06fb30fde789fba5b8d580 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?=
 <frederic34@users.noreply.github.com>
Date: Thu, 28 Nov 2024 11:15:56 +0100
Subject: [PATCH 39/45] fix phpdoc (#32097)

* fix phpdoc

* Update accountancycategory.class.php

* fix phpstan

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
---
 build/phpstan/phpstan-baseline.neon           | 200 +-----------------
 .../class/accountancycategory.class.php       |   4 +-
 htdocs/admin/mails.php                        |  10 +-
 htdocs/contact/perso.php                      |   2 +-
 .../core/tpl/object_currency_amount.tpl.php   |   7 +-
 .../template/myobject_agenda.php              |   2 +-
 .../modulebuilder/template/myobject_card.php  |   2 +-
 .../template/myobject_contact.php             |   2 +-
 .../template/myobject_document.php            |   2 +-
 .../modulebuilder/template/myobject_list.php  |   4 +-
 .../modulebuilder/template/myobject_note.php  |   2 +-
 htdocs/public/payment/newpayment.php          |  70 +++---
 htdocs/societe/paymentmodes.php               |  30 +--
 htdocs/societe/price.php                      |   1 +
 .../productattributevalueline_create.tpl.php  |  14 +-
 .../productattributevalueline_title.tpl.php   |   8 +-
 16 files changed, 93 insertions(+), 267 deletions(-)

diff --git a/build/phpstan/phpstan-baseline.neon b/build/phpstan/phpstan-baseline.neon
index 027b03a0df4bc..ddc424d9d08dd 100644
--- a/build/phpstan/phpstan-baseline.neon
+++ b/build/phpstan/phpstan-baseline.neon
@@ -312,12 +312,6 @@ parameters:
 			count: 4
 			path: ../../htdocs/accountancy/class/accountancycategory.class.php
 
-		-
-			message: '#^Property AccountancyCategory\:\:\$sdcpermonth type has no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: ../../htdocs/accountancy/class/accountancycategory.class.php
-
 		-
 			message: '#^Property AccountancyCategory\:\:\$sens \(int\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -1488,18 +1482,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/admin/mails.php
 
-		-
-			message: '#^Right side of && is always true\.$#'
-			identifier: booleanAnd.rightAlwaysTrue
-			count: 3
-			path: ../../htdocs/admin/mails.php
-
-		-
-			message: '#^Ternary operator condition is always false\.$#'
-			identifier: ternary.alwaysFalse
-			count: 3
-			path: ../../htdocs/admin/mails.php
-
 		-
 			message: '#^Variable \$text in empty\(\) always exists and is not falsy\.$#'
 			identifier: empty.variable
@@ -17382,24 +17364,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/core/tpl/list_print_total.tpl.php
 
-		-
-			message: '#^Variable \$action might not be defined\.$#'
-			identifier: variable.undefined
-			count: 5
-			path: ../../htdocs/core/tpl/object_currency_amount.tpl.php
-
-		-
-			message: '#^Variable \$object might not be defined\.$#'
-			identifier: variable.undefined
-			count: 3
-			path: ../../htdocs/core/tpl/object_currency_amount.tpl.php
-
-		-
-			message: '#^Variable \$usercancreate might not be defined\.$#'
-			identifier: variable.undefined
-			count: 4
-			path: ../../htdocs/core/tpl/object_currency_amount.tpl.php
-
 		-
 			message: '#^Left side of && is always true\.$#'
 			identifier: booleanAnd.leftAlwaysTrue
@@ -25026,18 +24990,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/modulebuilder/template/myobject_agenda.php
 
-		-
-			message: '#^If condition is always false\.$#'
-			identifier: if.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_agenda.php
-
-		-
-			message: '#^Negated boolean expression is always false\.$#'
-			identifier: booleanNot.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_agenda.php
-
 		-
 			message: '#^Negated boolean expression is always true\.$#'
 			identifier: booleanNot.alwaysTrue
@@ -25059,19 +25011,7 @@ parameters:
 		-
 			message: '#^If condition is always false\.$#'
 			identifier: if.alwaysFalse
-			count: 3
-			path: ../../htdocs/modulebuilder/template/myobject_card.php
-
-		-
-			message: '#^If condition is always true\.$#'
-			identifier: if.alwaysTrue
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_card.php
-
-		-
-			message: '#^Negated boolean expression is always false\.$#'
-			identifier: booleanNot.alwaysFalse
-			count: 1
+			count: 2
 			path: ../../htdocs/modulebuilder/template/myobject_card.php
 
 		-
@@ -25104,30 +25044,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/modulebuilder/template/myobject_card.php
 
-		-
-			message: '#^Right side of && is always true\.$#'
-			identifier: booleanAnd.rightAlwaysTrue
-			count: 5
-			path: ../../htdocs/modulebuilder/template/myobject_card.php
-
-		-
-			message: '#^Variable \$permissiontoadd in empty\(\) always exists and is not falsy\.$#'
-			identifier: empty.variable
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_card.php
-
-		-
-			message: '#^If condition is always false\.$#'
-			identifier: if.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_contact.php
-
-		-
-			message: '#^Negated boolean expression is always false\.$#'
-			identifier: booleanNot.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_contact.php
-
 		-
 			message: '#^Negated boolean expression is always true\.$#'
 			identifier: booleanNot.alwaysTrue
@@ -25146,24 +25062,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/modulebuilder/template/myobject_contact.php
 
-		-
-			message: '#^Right side of && is always true\.$#'
-			identifier: booleanAnd.rightAlwaysTrue
-			count: 2
-			path: ../../htdocs/modulebuilder/template/myobject_contact.php
-
-		-
-			message: '#^If condition is always false\.$#'
-			identifier: if.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_document.php
-
-		-
-			message: '#^Negated boolean expression is always false\.$#'
-			identifier: booleanNot.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_document.php
-
 		-
 			message: '#^Negated boolean expression is always true\.$#'
 			identifier: booleanNot.alwaysTrue
@@ -25194,18 +25092,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/modulebuilder/template/myobject_list.php
 
-		-
-			message: '#^If condition is always false\.$#'
-			identifier: if.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_list.php
-
-		-
-			message: '#^Negated boolean expression is always false\.$#'
-			identifier: booleanNot.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_list.php
-
 		-
 			message: '#^Negated boolean expression is always true\.$#'
 			identifier: booleanNot.alwaysTrue
@@ -25224,24 +25110,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/modulebuilder/template/myobject_list.php
 
-		-
-			message: '#^Variable \$permissiontodelete in empty\(\) always exists and is not falsy\.$#'
-			identifier: empty.variable
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_list.php
-
-		-
-			message: '#^If condition is always false\.$#'
-			identifier: if.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_note.php
-
-		-
-			message: '#^Negated boolean expression is always false\.$#'
-			identifier: booleanNot.alwaysFalse
-			count: 1
-			path: ../../htdocs/modulebuilder/template/myobject_note.php
-
 		-
 			message: '#^Negated boolean expression is always true\.$#'
 			identifier: booleanNot.alwaysTrue
@@ -32688,24 +32556,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/societe/paymentmodes.php
 
-		-
-			message: '#^Parameter \#4 \$month of function dol_mktime expects int, array\<mixed\>\|string given\.$#'
-			identifier: argument.type
-			count: 3
-			path: ../../htdocs/societe/paymentmodes.php
-
-		-
-			message: '#^Parameter \#5 \$day of function dol_mktime expects int, array\<mixed\>\|string given\.$#'
-			identifier: argument.type
-			count: 3
-			path: ../../htdocs/societe/paymentmodes.php
-
-		-
-			message: '#^Parameter \#6 \$year of function dol_mktime expects int, array\<mixed\>\|string given\.$#'
-			identifier: argument.type
-			count: 3
-			path: ../../htdocs/societe/paymentmodes.php
-
 		-
 			message: '#^Ternary operator condition is always true\.$#'
 			identifier: ternary.alwaysTrue
@@ -32748,12 +32598,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/societe/price.php
 
-		-
-			message: '#^Variable \$extrafields might not be defined\.$#'
-			identifier: variable.undefined
-			count: 14
-			path: ../../htdocs/societe/price.php
-
 		-
 			message: '#^Variable \$prodcustprice might not be defined\.$#'
 			identifier: variable.undefined
@@ -34686,48 +34530,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/variants/list.php
 
-		-
-			message: '#^Cannot access property \$lines on mixed\.$#'
-			identifier: property.nonObject
-			count: 1
-			path: ../../htdocs/variants/tpl/productattributevalueline_create.tpl.php
-
-		-
-			message: '#^Variable \$action might not be defined\.$#'
-			identifier: variable.undefined
-			count: 1
-			path: ../../htdocs/variants/tpl/productattributevalueline_create.tpl.php
-
-		-
-			message: '#^Variable \$hookmanager might not be defined\.$#'
-			identifier: variable.undefined
-			count: 1
-			path: ../../htdocs/variants/tpl/productattributevalueline_create.tpl.php
-
-		-
-			message: '#^Variable \$langs might not be defined\.$#'
-			identifier: variable.undefined
-			count: 2
-			path: ../../htdocs/variants/tpl/productattributevalueline_create.tpl.php
-
-		-
-			message: '#^Variable \$this might not be defined\.$#'
-			identifier: variable.undefined
-			count: 1
-			path: ../../htdocs/variants/tpl/productattributevalueline_create.tpl.php
-
-		-
-			message: '#^Variable \$action might not be defined\.$#'
-			identifier: variable.undefined
-			count: 1
-			path: ../../htdocs/variants/tpl/productattributevalueline_title.tpl.php
-
-		-
-			message: '#^Variable \$langs might not be defined\.$#'
-			identifier: variable.undefined
-			count: 2
-			path: ../../htdocs/variants/tpl/productattributevalueline_title.tpl.php
-
 		-
 			message: '#^Call to function is_numeric\(\) with int will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType
diff --git a/htdocs/accountancy/class/accountancycategory.class.php b/htdocs/accountancy/class/accountancycategory.class.php
index d71dc306478c1..379e2b802e152 100644
--- a/htdocs/accountancy/class/accountancycategory.class.php
+++ b/htdocs/accountancy/class/accountancycategory.class.php
@@ -2,7 +2,7 @@
 /* Copyright (C) 2016		Jamal Elbaz			<jamelbaz@gmail.pro>
  * Copyright (C) 2016-2017	Alexandre Spangaro	<aspangaro@open-dsi.fr>
  * Copyright (C) 2018-2024	Frédéric France     <frederic.france@free.fr>
- * Copyright (C) 2024		MDW							<mdeweerd@users.noreply.github.com>
+ * Copyright (C) 2024		MDW					<mdeweerd@users.noreply.github.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -129,7 +129,7 @@ class AccountancyCategory // extends CommonObject
 	public $sdc;
 
 	/**
-	 * @var array Sum debit credit per month
+	 * @var array<string,float> Sum debit credit per month
 	 */
 	public $sdcpermonth;
 
diff --git a/htdocs/admin/mails.php b/htdocs/admin/mails.php
index 02714bc87df7a..c54ca5dc0f4a8 100644
--- a/htdocs/admin/mails.php
+++ b/htdocs/admin/mails.php
@@ -55,7 +55,7 @@
 
 $usersignature = $user->signature;
 // For action = test or send, we ensure that content is not html, even for signature, because for this we want a test with NO html.
-if ($action == 'test' || ($action == 'send' && $trackid = 'test')) {
+if ($action == 'test' || ($action == 'send' && $trackid == 'test')) {
 	$usersignature = dol_string_nohtmltag($usersignature, 2);
 }
 
@@ -1003,7 +1003,7 @@ function change_smtp_auth_method() {
 
 	if (!getDolGlobalString('MAIN_DISABLE_ALL_MAILS')) {
 		if (getDolGlobalString('MAIN_MAIL_SENDMODE', 'mail') != 'mail' || !$linuxlike) {
-			if (function_exists('fsockopen') && $port && $server) {
+			if (function_exists('fsockopen') /* && $port && $server */) { // $port and $server can't be empty
 				print '<a class="butAction" href="'.$_SERVER["PHP_SELF"].'?action=testconnect&token='.newToken().'&date='.dol_now().'#formmailaftertstconnect">'.$langs->trans("DoTestServerAvailability").'</a>';
 			}
 		} else {
@@ -1044,19 +1044,19 @@ function change_smtp_auth_method() {
 			// mthode php mail
 			if (getDolGlobalString('MAIN_EXTERNAL_MAIL_SPF_STRING_TO_ADD')) {	// Not defined by default. Depend on platform.
 				// List of string to add in SPF if the setup use the mail method. Example 'include:sendgrid.net include:spf.mydomain.com'
-				$text .= ($text ? '<br><br>' : '').$langs->trans("WarningPHPMailSPFDMARC");
+				$text .= /* ($text ? '<br><br>' : ''). */$langs->trans("WarningPHPMailSPFDMARC");
 			} else {
 				// MAIN_EXTERNAL_SMTP_CLIENT_IP_ADDRESS is list of IPs where email is sent from. Example: '1.2.3.4, [aaaa:bbbb:cccc:dddd]'.
 				if (getDolGlobalString('MAIN_EXTERNAL_SMTP_CLIENT_IP_ADDRESS')) {
 					// List of IP shown as record to add in SPF if we use the mail method
-					$text .= ($text ? '<br><br>' : '').$langs->trans("WarningPHPMailSPFDMARC");
+					$text .= /* ($text ? '<br><br>' : ''). */$langs->trans("WarningPHPMailSPFDMARC");
 				}
 			}
 		} else {
 			// method smtps or swiftmail
 			if (getDolGlobalString('MAIN_EXTERNAL_SMTP_SPF_STRING_TO_ADD')) {	// Should be required only if you have preset the Dolibarr to use your own SMTP and you want to warn users to update their domain name to match your SMTP server.
 				// List of string to add in SPF if we use the smtp method. Example 'include:spf.mydomain.com'
-				$text .= ($text ? '<br><br>' : '').$langs->trans("WarningPHPMailSPF", getDolGlobalString('MAIN_EXTERNAL_SMTP_SPF_STRING_TO_ADD'));
+				$text .= /* ($text ? '<br><br>' : ''). */$langs->trans("WarningPHPMailSPF", getDolGlobalString('MAIN_EXTERNAL_SMTP_SPF_STRING_TO_ADD'));
 			}
 			if (getDolGlobalString('MAIN_EXTERNAL_SMTP_CLIENT_IP_ADDRESS')) {	// Not defined by default. Depend on platform.
 				// List of IP shown as record to add as allowed IP if we use the smtp method. Value is '1.2.3.4, [aaaa:bbbb:cccc:dddd]'
diff --git a/htdocs/contact/perso.php b/htdocs/contact/perso.php
index 9316a38927b74..bb4027978b164 100644
--- a/htdocs/contact/perso.php
+++ b/htdocs/contact/perso.php
@@ -75,7 +75,7 @@
 
 	$result = $object->update_perso($id, $user);
 	if ($result > 0) {
-		$object->oldcopy = dol_clone($object, 2);  // @phan-suppres-current-line PhanTypeMismatchProperty
+		$object->oldcopy = dol_clone($object, 2);  // @phan-suppress-current-line PhanTypeMismatchProperty
 
 		// Logo/Photo save
 		$dir = $conf->societe->dir_output.'/contact/'.get_exdir($object->id, 0, 0, 1, $object, 'contact').'/photos';
diff --git a/htdocs/core/tpl/object_currency_amount.tpl.php b/htdocs/core/tpl/object_currency_amount.tpl.php
index 73e7d78069f7d..5465d1d55e5c9 100644
--- a/htdocs/core/tpl/object_currency_amount.tpl.php
+++ b/htdocs/core/tpl/object_currency_amount.tpl.php
@@ -1,5 +1,5 @@
 <?php
-/* Copyright (C) 2024  Laurent Destailleur	<eldy@users.sourceforge.net>
+/* Copyright (C) 2024       Laurent Destailleur	    <eldy@users.sourceforge.net>
  * Copyright (C) 2024       Frédéric France         <frederic.france@free.fr>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -24,8 +24,13 @@
  * $langs
  */
 /**
+ * @var CommonObject $object
+ * @var Conf $conf
  * @var Form $form
  * @var Translate $langs
+ *
+ * @var string $action
+ * @var int $usercancreate
  */
 // Protection to avoid direct call of template
 if (empty($conf) || !is_object($conf)) {
diff --git a/htdocs/modulebuilder/template/myobject_agenda.php b/htdocs/modulebuilder/template/myobject_agenda.php
index 05f1c17156c23..e1333cec3bc1f 100644
--- a/htdocs/modulebuilder/template/myobject_agenda.php
+++ b/htdocs/modulebuilder/template/myobject_agenda.php
@@ -146,7 +146,7 @@
 
 // There is several ways to check permission.
 // Set $enablepermissioncheck to 1 to enable a minimum low level of checks
-$enablepermissioncheck = 0;
+$enablepermissioncheck = getDolGlobalInt('MYMODULE_ENABLE_PERMISSION_CHECK');
 if ($enablepermissioncheck) {
 	$permissiontoread = $user->hasRight('mymodule', 'myobject', 'read');
 	$permissiontoadd = $user->hasRight('mymodule', 'myobject', 'write');
diff --git a/htdocs/modulebuilder/template/myobject_card.php b/htdocs/modulebuilder/template/myobject_card.php
index 5b783ddbdcbc4..bcd37702167e4 100644
--- a/htdocs/modulebuilder/template/myobject_card.php
+++ b/htdocs/modulebuilder/template/myobject_card.php
@@ -150,7 +150,7 @@
 
 // There is several ways to check permission.
 // Set $enablepermissioncheck to 1 to enable a minimum low level of checks
-$enablepermissioncheck = 0;
+$enablepermissioncheck = getDolGlobalInt('MYMODULE_ENABLE_PERMISSION_CHECK');
 if ($enablepermissioncheck) {
 	$permissiontoread = $user->hasRight('mymodule', 'myobject', 'read');
 	$permissiontoadd = $user->hasRight('mymodule', 'myobject', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_lineupdown.inc.php
diff --git a/htdocs/modulebuilder/template/myobject_contact.php b/htdocs/modulebuilder/template/myobject_contact.php
index 01e33e87a09d7..71082d7bb77d5 100644
--- a/htdocs/modulebuilder/template/myobject_contact.php
+++ b/htdocs/modulebuilder/template/myobject_contact.php
@@ -93,7 +93,7 @@
 
 // There is several ways to check permission.
 // Set $enablepermissioncheck to 1 to enable a minimum low level of checks
-$enablepermissioncheck = 0;
+$enablepermissioncheck = getDolGlobalInt('MYMODULE_ENABLE_PERMISSION_CHECK');
 if ($enablepermissioncheck) {
 	$permissiontoread = $user->hasRight('mymodule', 'myobject', 'read');
 	$permissiontoadd = $user->hasRight('mymodule', 'myobject', 'write');
diff --git a/htdocs/modulebuilder/template/myobject_document.php b/htdocs/modulebuilder/template/myobject_document.php
index 9a9143c8392a1..c443e300e9cb2 100644
--- a/htdocs/modulebuilder/template/myobject_document.php
+++ b/htdocs/modulebuilder/template/myobject_document.php
@@ -140,7 +140,7 @@
 // Permissions
 // (There are several ways to check permission.)
 // Set $enablepermissioncheck to 1 to enable a minimum low level of checks
-$enablepermissioncheck = 0;
+$enablepermissioncheck = getDolGlobalInt('MYMODULE_ENABLE_PERMISSION_CHECK');
 if ($enablepermissioncheck) {
 	$permissiontoread = $user->hasRight('mymodule', 'myobject', 'read');
 	$permissiontoadd  = $user->hasRight('mymodule', 'myobject', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_linkedfiles.inc.php
diff --git a/htdocs/modulebuilder/template/myobject_list.php b/htdocs/modulebuilder/template/myobject_list.php
index 2dd29e4144f04..6bde6bf10d175 100644
--- a/htdocs/modulebuilder/template/myobject_list.php
+++ b/htdocs/modulebuilder/template/myobject_list.php
@@ -203,7 +203,7 @@
 
 // There is several ways to check permission.
 // Set $enablepermissioncheck to 1 to enable a minimum low level of checks
-$enablepermissioncheck = 0;
+$enablepermissioncheck = getDolGlobalInt('MYMODULE_ENABLE_PERMISSION_CHECK');
 if ($enablepermissioncheck) {
 	$permissiontoread = $user->hasRight('mymodule', 'myobject', 'read');
 	$permissiontoadd = $user->hasRight('mymodule', 'myobject', 'write');
@@ -274,6 +274,8 @@
 	$objectclass = 'MyObject';
 	$objectlabel = 'MyObject';
 	$uploaddir = $conf->mymodule->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	// You can add more action here
diff --git a/htdocs/modulebuilder/template/myobject_note.php b/htdocs/modulebuilder/template/myobject_note.php
index eada8fdd0d26c..8d9f974a526eb 100644
--- a/htdocs/modulebuilder/template/myobject_note.php
+++ b/htdocs/modulebuilder/template/myobject_note.php
@@ -118,7 +118,7 @@
 
 // There is several ways to check permission.
 // Set $enablepermissioncheck to 1 to enable a minimum low level of checks
-$enablepermissioncheck = 0;
+$enablepermissioncheck = getDolGlobalInt('MYMODULE_ENABLE_PERMISSION_CHECK');
 if ($enablepermissioncheck) {
 	$permissiontoread = $user->hasRight('mymodule', 'myobject', 'read');
 	$permissiontoadd = $user->hasRight('mymodule', 'myobject', 'write');
diff --git a/htdocs/public/payment/newpayment.php b/htdocs/public/payment/newpayment.php
index 6549601154234..275b4f6bb27d8 100644
--- a/htdocs/public/payment/newpayment.php
+++ b/htdocs/public/payment/newpayment.php
@@ -2182,7 +2182,7 @@
 							});
 							$("#dopayment_paybox").click(function(e){
 								$("#div_dopayment_paybox").css( \'cursor\', \'wait\' );
-							    e.stopPropagation();
+								e.stopPropagation();
 							});
 						});
 					  </script>
@@ -2212,7 +2212,7 @@
 								});
 								$("#dopayment_stripe").click(function(e){
 									$("#div_dopayment_stripe").css( \'cursor\', \'wait\' );
-								    e.stopPropagation();
+									e.stopPropagation();
 									return true;
 								});
 							});
@@ -2254,7 +2254,7 @@
 								});
 								$("#dopayment_paypal").click(function(e){
 									$("#div_dopayment_paypal").css( \'cursor\', \'wait\' );
-								    e.stopPropagation();
+									e.stopPropagation();
 									return true;
 								});
 							});
@@ -2296,32 +2296,32 @@
 	if (GETPOST('dopayment_stripe', 'alpha')) {
 		// Personalized checkout
 		print '<style>
-	    /**
-	     * The CSS shown here will not be introduced in the Quickstart guide, but shows
-	     * how you can use CSS to style your Element s container.
-	     */
-	    .StripeElement {
-	        background-color: white;
-	        padding: 8px 12px;
-	        border-radius: 4px;
-	        border: 1px solid transparent;
-	        box-shadow: 0 1px 3px 0 #e6ebf1;
-	        -webkit-transition: box-shadow 150ms ease;
-	        transition: box-shadow 150ms ease;
-	    }
-
-	    .StripeElement--focus {
-	        box-shadow: 0 1px 3px 0 #cfd7df;
-	    }
-
-	    .StripeElement--invalid {
-	        border-color: #fa755a;
-	    }
-
-	    .StripeElement--webkit-autofill {
-	        background-color: #fefde5 !important;
-	    }
-	    </style>';
+		/**
+		 * The CSS shown here will not be introduced in the Quickstart guide, but shows
+		 * how you can use CSS to style your Element s container.
+		 */
+		.StripeElement {
+			background-color: white;
+			padding: 8px 12px;
+			border-radius: 4px;
+			border: 1px solid transparent;
+			box-shadow: 0 1px 3px 0 #e6ebf1;
+			-webkit-transition: box-shadow 150ms ease;
+			transition: box-shadow 150ms ease;
+		}
+
+		.StripeElement--focus {
+			box-shadow: 0 1px 3px 0 #cfd7df;
+		}
+
+		.StripeElement--invalid {
+			border-color: #fa755a;
+		}
+
+		.StripeElement--webkit-autofill {
+			background-color: #fefde5 !important;
+		}
+		</style>';
 
 		//print '<br>';
 
@@ -2380,8 +2380,8 @@
 		// $conf->global->STRIPE_USE_INTENT_WITH_AUTOMATIC_CONFIRMATION = 2 = use payment object (suggest both card payment mode but also sepa, ...)
 
 		print '
-        <table id="dolpaymenttable" summary="Payment form" class="center centpercent">
-        <tbody><tr><td class="textpublicpayment">';
+		<table id="dolpaymenttable" summary="Payment form" class="center centpercent">
+		<tbody><tr><td class="textpublicpayment">';
 
 		if (getDolGlobalString('STRIPE_USE_INTENT_WITH_AUTOMATIC_CONFIRMATION')) {
 			print '<div id="payment-request-button"><!-- A Stripe Element will be inserted here. --></div>';
@@ -2395,8 +2395,8 @@
 
 		if (getDolGlobalInt('STRIPE_USE_INTENT_WITH_AUTOMATIC_CONFIRMATION') == 1) {
 			print '<div id="card-element">
-	        <!-- a Stripe Element will be inserted here. -->
-    	    </div>';
+			<!-- a Stripe Element will be inserted here. -->
+			</div>';
 		}
 		if (getDolGlobalInt('STRIPE_USE_INTENT_WITH_AUTOMATIC_CONFIRMATION') == 2) {
 			print '<div id="payment-element">
@@ -2405,8 +2405,8 @@
 		}
 
 		print '<!-- Used to display form errors -->
-        <div id="card-errors" role="alert"></div>
-        </div>';
+		<div id="card-errors" role="alert"></div>
+		</div>';
 
 		print '<br>';
 		print '<button class="button buttonpayment" style="text-align: center; padding-left: 0; padding-right: 0;" id="buttontopay" data-secret="'.(is_object($paymentintent) ? $paymentintent->client_secret : '').'">'.$langs->trans("ValidatePayment").'</button>';
diff --git a/htdocs/societe/paymentmodes.php b/htdocs/societe/paymentmodes.php
index 595943b584568..cacc2c3e002b3 100644
--- a/htdocs/societe/paymentmodes.php
+++ b/htdocs/societe/paymentmodes.php
@@ -1,15 +1,15 @@
 <?php
-/* Copyright (C) 2002-2004  Rodolphe Quiedeville <rodolphe@quiedeville.org>
- * Copyright (C) 2003       Jean-Louis Bergamo   <jlb@j1b.org>
- * Copyright (C) 2004-2022  Laurent Destailleur  <eldy@users.sourceforge.net>
- * Copyright (C) 2005-2009  Regis Houssin        <regis.houssin@inodbox.com>
- * Copyright (C) 2013       Peter Fontaine       <contact@peterfontaine.fr>
- * Copyright (C) 2015-2016  Marcos García        <marcosgdf@gmail.com>
- * Copyright (C) 2017       Ferran Marcet        <fmarcet@2byte.es>
- * Copyright (C) 2018-2023  Thibault FOUCART     <support@ptibogxiv.net>
- * Copyright (C) 2021       Alexandre Spangaro   <aspangaro@open-dsi.fr>
- * Copyright (C) 2024		MDW							<mdeweerd@users.noreply.github.com>
- * Copyright (C) 2024       Frédéric France             <frederic.france@free.fr>
+/* Copyright (C) 2002-2004  Rodolphe Quiedeville    <rodolphe@quiedeville.org>
+ * Copyright (C) 2003       Jean-Louis Bergamo      <jlb@j1b.org>
+ * Copyright (C) 2004-2022  Laurent Destailleur     <eldy@users.sourceforge.net>
+ * Copyright (C) 2005-2009  Regis Houssin           <regis.houssin@inodbox.com>
+ * Copyright (C) 2013       Peter Fontaine          <contact@peterfontaine.fr>
+ * Copyright (C) 2015-2016  Marcos García           <marcosgdf@gmail.com>
+ * Copyright (C) 2017       Ferran Marcet           <fmarcet@2byte.es>
+ * Copyright (C) 2018-2023  Thibault FOUCART        <support@ptibogxiv.net>
+ * Copyright (C) 2021       Alexandre Spangaro      <aspangaro@open-dsi.fr>
+ * Copyright (C) 2024		MDW						<mdeweerd@users.noreply.github.com>
+ * Copyright (C) 2024       Frédéric France         <frederic.france@free.fr>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -199,7 +199,7 @@
 			$companybankaccount->owner_address   = GETPOST('owner_address', 'alpha');
 			$companybankaccount->frstrecur       = GETPOST('frstrecur', 'alpha');
 			$companybankaccount->rum             = GETPOST('rum', 'alpha');
-			$companybankaccount->date_rum        = dol_mktime(0, 0, 0, GETPOST('date_rummonth'), GETPOST('date_rumday'), GETPOST('date_rumyear'));
+			$companybankaccount->date_rum = GETPOSTDATE('date_rum', '00:00:00');
 			if (empty($companybankaccount->rum)) {
 				$companybankaccount->rum = $prelevement->buildRumNumber($object->code_client, $companybankaccount->datec, $companybankaccount->id);
 			}
@@ -331,7 +331,7 @@
 			$companybankaccount->owner_address   = GETPOST('owner_address', 'alpha');
 			$companybankaccount->frstrecur       = GETPOST('frstrecur', 'alpha');
 			$companybankaccount->rum             = GETPOST('rum', 'alpha');
-			$companybankaccount->date_rum        = dol_mktime(0, 0, 0, GETPOSTINT('date_rummonth'), GETPOSTINT('date_rumday'), GETPOSTINT('date_rumyear'));
+			$companybankaccount->date_rum        = GETPOSTDATE('date_rum', '00:00:00');
 			$companybankaccount->datec           = dol_now();
 
 			//$companybankaccount->clos          = GETPOSTINT('clos');
@@ -2088,7 +2088,7 @@
 		print '<tr><td class="titlefield">'.$langs->trans("RUM").'</td>';
 		print '<td><input class="minwidth300" type="text" name="rum" value="'.dol_escape_htmltag($companybankaccount->rum).'"></td></tr>';
 
-		$date_rum = dol_mktime(0, 0, 0, GETPOST('date_rummonth'), GETPOST('date_rumday'), GETPOST('date_rumyear'));
+		$date_rum = GETPOSTDATE('date_rum', '00:00:00');
 
 		print '<tr><td class="titlefield">'.$langs->trans("DateRUM").'</td>';
 		print '<td>'.$form->selectDate($date_rum ? $date_rum : $companybankaccount->date_rum, 'date_rum', 0, 0, 1, 'date_rum', 1, 1).'</td></tr>';
@@ -2257,7 +2257,7 @@
 		print '<tr><td class="titlefieldcreate">'.$form->textwithpicto($langs->trans("RUM"), $langs->trans("RUMLong").'<br>'.$langs->trans("RUMWillBeGenerated")).'</td>';
 		print '<td colspan="4"><input type="text" class="minwidth300" name="rum" value="'.GETPOST('rum', 'alpha').'"></td></tr>';
 
-		$date_rum = dol_mktime(0, 0, 0, GETPOST('date_rummonth'), GETPOST('date_rumday'), GETPOST('date_rumyear'));
+		$date_rum = GETPOSTDATE('date_rum', '00:00:00');
 
 		print '<tr><td class="titlefieldcreate">'.$langs->trans("DateRUM").'</td>';
 		print '<td colspan="4">'.$form->selectDate($date_rum, 'date_rum', 0, 0, 1, 'date_rum', 1, 1).'</td></tr>';
diff --git a/htdocs/societe/price.php b/htdocs/societe/price.php
index 5ae56bdd3d59a..24a7f838ad881 100644
--- a/htdocs/societe/price.php
+++ b/htdocs/societe/price.php
@@ -40,6 +40,7 @@
 /**
  * @var Conf $conf
  * @var DoliDB $db
+ * @var ExtraFields $extrafields
  * @var HookManager $hookmanager
  * @var Societe $mysoc
  * @var Translate $langs
diff --git a/htdocs/variants/tpl/productattributevalueline_create.tpl.php b/htdocs/variants/tpl/productattributevalueline_create.tpl.php
index 0d5ee24fc8481..17d0824331889 100644
--- a/htdocs/variants/tpl/productattributevalueline_create.tpl.php
+++ b/htdocs/variants/tpl/productattributevalueline_create.tpl.php
@@ -1,5 +1,6 @@
 <?php
-/* Copyright (C) 2022   Open-Dsi		<support@open-dsi.fr>
+/* Copyright (C) 2022       Open-Dsi				<support@open-dsi.fr>
+ * Copyright (C) 2024       Frédéric France         <frederic.france@free.fr>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -24,13 +25,22 @@
  * $inputalsopricewithtax (0 by default, 1 to also show column with unit price including tax)
  */
 
+/**
+ * @var CommonObject $this
+ * @var CommonObject $object
+ * @var HookManager $hookmanager
+ * @var Translate $langs
+ *
+ * @var string $action
+ */
+
 // Protection to avoid direct call of template
 if (empty($object) || !is_object($object)) {
 	print "Error: this template page cannot be called directly as an URL";
 	exit;
 }
 
-'@phan-var-force CommonObject $this
+'@phan-var-force CommonObject $object
  @phan-var-force CommonObject $this';
 
 global $forcetoshowtitlelines;
diff --git a/htdocs/variants/tpl/productattributevalueline_title.tpl.php b/htdocs/variants/tpl/productattributevalueline_title.tpl.php
index 79d4034422b5a..b970a1513a3b8 100644
--- a/htdocs/variants/tpl/productattributevalueline_title.tpl.php
+++ b/htdocs/variants/tpl/productattributevalueline_title.tpl.php
@@ -1,5 +1,6 @@
 <?php
-/* Copyright (C) 2022   Open-Dsi		<support@open-dsi.fr>
+/* Copyright (C) 2022       Open-Dsi				<support@open-dsi.fr>
+ * Copyright (C) 2024       Frédéric France         <frederic.france@free.fr>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -31,6 +32,11 @@
 	print "Error, template page can't be called as URL";
 	exit(1);
 }
+/**
+ * @var Translate $langs
+ *
+ * @var string $action
+ */
 
 print "<!-- BEGIN PHP TEMPLATE productattributevalueline_title.tpl.php -->\n";
 

From d343807a049738131711f20ee5bd24d99f310ec5 Mon Sep 17 00:00:00 2001
From: Zephyriony <142790847+zephyriony@users.noreply.github.com>
Date: Thu, 28 Nov 2024 11:16:34 +0100
Subject: [PATCH 40/45] FIX Linked elements not up to date (#32118)

* FIX Linked elements not up to date

If you add a linked element, it won't appear without this correction, and if you delete an element, it won't disappear. You're forced to refresh the page to have the links updated, which is rather unpleasant.

* Update actions_dellink.inc.php

* Update actions_dellink.inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
---
 htdocs/core/actions_dellink.inc.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/htdocs/core/actions_dellink.inc.php b/htdocs/core/actions_dellink.inc.php
index cf8b361461761..36959569502b3 100644
--- a/htdocs/core/actions_dellink.inc.php
+++ b/htdocs/core/actions_dellink.inc.php
@@ -50,6 +50,7 @@
 	foreach ($addlinkids as $addlinkid) {
 		$result = $object->add_object_linked($addlink, $addlinkid);
 	}
+	$object->clearObjectLinkedCache();
 }
 
 // Link by reference
@@ -69,6 +70,7 @@
 			if (isset($_POST['reftolinkto'])) {
 				unset($_POST['reftolinkto']);
 			}
+			$object->clearObjectLinkedCache();
 		} elseif ($ret < 0) {
 			setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
 		} else {
@@ -81,6 +83,7 @@
 // Delete link in table llx_element_element
 if ($action == 'dellink' && !empty($permissiondellink) && !$cancellink && $dellinkid > 0) {
 	$result = $object->deleteObjectLinked(0, '', 0, '', $dellinkid);
+	$object->clearObjectLinkedCache();
 	if ($result < 0) {
 		setEventMessages($object->error, $object->errors, 'errors');
 	}

From d823f3281d544104eb51e1d9576223f0f4247cff Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Thu, 28 Nov 2024 11:36:13 +0100
Subject: [PATCH 41/45] Update README.md

---
 dev/setup/pre-commit/README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev/setup/pre-commit/README.md b/dev/setup/pre-commit/README.md
index d4bbb8013f553..f256cbf26e8f2 100644
--- a/dev/setup/pre-commit/README.md
+++ b/dev/setup/pre-commit/README.md
@@ -96,6 +96,6 @@ CI also runs pre-commit to help maintain code quality.
 
 Note:
 Code for precommits are saved into:
-.cache/pre-commit/repo*/pre_commit_hooks/php-*.sh
+.cache/pre-commit/repo.../pre_commit_hooks/php-....sh
 and
-.cache/pre-commit/repo*/py_env-python3/lib/python*/site-packages/pre_commit_hooks/no_commit_to_branch.py
+.cache/pre-commit/repo.../py_env-python3/lib/python.../site-packages/pre_commit_hooks/no_commit_to_branch.py

From 16cbc512a278168eb4f877ca300829b80b0b2b91 Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Thu, 28 Nov 2024 11:38:07 +0100
Subject: [PATCH 42/45] Doc

---
 htdocs/core/lib/functions.lib.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/htdocs/core/lib/functions.lib.php b/htdocs/core/lib/functions.lib.php
index 01e906dbc5402..06ce0567f5300 100644
--- a/htdocs/core/lib/functions.lib.php
+++ b/htdocs/core/lib/functions.lib.php
@@ -1145,8 +1145,9 @@ function GETPOSTFLOAT($paramname, $rounding = '')
  * optionally hour, minute, second) fields to return a timestamp.
  *
  * @param 	string 		$prefix 	Prefix used to build the date selector (for instance using Form::selectDate)
- * @param 	string 		$hourTime	'getpost' to include hour, minute, second values from the HTTP request, 'XX:YY:ZZ' to set
- *                      		    hour, minute, second respectively (for instance '23:59:59')
+ * @param 	string 		$hourTime	'getpost' to include hour, minute, second values from the HTTP request,
+ * 									or 'XX:YY:ZZ' to set hour, minute, second respectively (for instance '23:59:59')
+ * 									or '' means '00:00:00' (default)
  * @param 	string 		$gm 		Passed to dol_mktime
  * @return 	int|string  			Date as a timestamp, '' or false if error
  */

From c06a4746512abc3554347c29ec70dcc8bc82cb3a Mon Sep 17 00:00:00 2001
From: "Laurent Destailleur (aka Eldy)" <eldy@destailleur.fr>
Date: Thu, 28 Nov 2024 11:54:55 +0100
Subject: [PATCH 43/45] Rename and move conf file

---
 dev/tools/apstats.php                                        | 2 +-
 phpstan.v1.neon => dev/tools/phpstan/phpstan_v1_apstats.neon | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
 rename phpstan.v1.neon => dev/tools/phpstan/phpstan_v1_apstats.neon (99%)

diff --git a/dev/tools/apstats.php b/dev/tools/apstats.php
index b6fd7ed4adbcf..fa27133329a5a 100755
--- a/dev/tools/apstats.php
+++ b/dev/tools/apstats.php
@@ -149,7 +149,7 @@
 
 $output_arrtd = array();
 if ($dirphpstan != 'disabled') {
-	$commandcheck = ($dirphpstan ? $dirphpstan.'/' : '').'phpstan --level='.$PHPSTANLEVEL.' -v analyze -a build/phpstan/bootstrap.php --memory-limit 8G --error-format=github -c ~/preview.dolibarr.org/dolibarr/phpstan.v1.neon';
+	$commandcheck = ($dirphpstan ? $dirphpstan.'/' : '').'phpstan --level='.$PHPSTANLEVEL.' -v analyze -a build/phpstan/bootstrap.php --memory-limit 8G --error-format=github -c ~/preview.dolibarr.org/dolibarr/dev/tools/phpstan/phpstan_v1_apstats.neon';
 	print 'Execute PHPStan to get the technical debt: '.$commandcheck."\n";
 	$resexectd = 0;
 	exec($commandcheck, $output_arrtd, $resexectd);
diff --git a/phpstan.v1.neon b/dev/tools/phpstan/phpstan_v1_apstats.neon
similarity index 99%
rename from phpstan.v1.neon
rename to dev/tools/phpstan/phpstan_v1_apstats.neon
index b4c987d2c410f..6b59956030956 100644
--- a/phpstan.v1.neon
+++ b/dev/tools/phpstan/phpstan_v1_apstats.neon
@@ -48,6 +48,7 @@ parameters:
 	treatPhpDocTypesAsCertain: false
 	ignoreErrors:
 		- '#.*phan-var#'
+		- '#is always#'
 	internalErrorsCountLimit: 50
 	cache:
 		nodesByFileCountMax: 512

From 76d4a8766659a22c3b9458b0f2dec0ba1abc30b1 Mon Sep 17 00:00:00 2001
From: Mohamed DAOUD <daoud.mouhamed@gmail.com>
Date: Thu, 28 Nov 2024 12:00:36 +0100
Subject: [PATCH 44/45] Fix hook doAddButton (#32116)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
---
 htdocs/public/payment/newpayment.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/htdocs/public/payment/newpayment.php b/htdocs/public/payment/newpayment.php
index 275b4f6bb27d8..d901413cf1723 100644
--- a/htdocs/public/payment/newpayment.php
+++ b/htdocs/public/payment/newpayment.php
@@ -2166,7 +2166,7 @@
 			$reshook = $hookmanager->executeHooks('doAddButton', $parameters, $object, $action);
 			if ($reshook < 0) {
 				setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
-			} elseif ($reshook > 0) {
+			} elseif ($reshook >= 0) {
 				print $hookmanager->resPrint;
 			}
 

From 286c3d1093e31c88a041c3af2fa4250792720f33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20FRANCE?=
 <frederic34@users.noreply.github.com>
Date: Thu, 28 Nov 2024 12:11:50 +0100
Subject: [PATCH 45/45] fix sql ticket list (#32080)

* fix sql ticket list

* fix sql ticket list

* fix phpstan

* fix

* fix
---
 build/phpstan/phpstan-baseline.neon           | 102 ---------------
 htdocs/accountancy/bookkeeping/list.php       |   2 +
 .../accountancy/bookkeeping/listbyaccount.php |   2 +
 htdocs/commande/class/commande.class.php      |   1 +
 htdocs/core/actions_massactions.inc.php       |   1 +
 htdocs/core/class/commonobject.class.php      |   2 +-
 htdocs/expedition/class/expedition.class.php  |   5 -
 htdocs/projet/list.php                        |   2 +
 htdocs/reception/class/reception.class.php    |   4 -
 htdocs/salaries/payments.php                  |   2 +
 .../class/companybankaccount.class.php        |   6 -
 htdocs/societe/list.php                       |   4 +-
 htdocs/ticket/class/ticket.class.php          |   3 +-
 htdocs/ticket/list.php                        | 117 +++++++++---------
 htdocs/user/list.php                          |  74 +++++------
 15 files changed, 111 insertions(+), 216 deletions(-)

diff --git a/build/phpstan/phpstan-baseline.neon b/build/phpstan/phpstan-baseline.neon
index ddc424d9d08dd..192a9985d69a0 100644
--- a/build/phpstan/phpstan-baseline.neon
+++ b/build/phpstan/phpstan-baseline.neon
@@ -228,12 +228,6 @@ parameters:
 			count: 4
 			path: ../../htdocs/accountancy/bookkeeping/export.php
 
-		-
-			message: '#^Negated boolean expression is always true\.$#'
-			identifier: booleanNot.alwaysTrue
-			count: 1
-			path: ../../htdocs/accountancy/bookkeeping/list.php
-
 		-
 			message: '#^Variable \$contextpage in empty\(\) always exists and is not falsy\.$#'
 			identifier: empty.variable
@@ -252,12 +246,6 @@ parameters:
 			count: 3
 			path: ../../htdocs/accountancy/bookkeeping/list.php
 
-		-
-			message: '#^Negated boolean expression is always true\.$#'
-			identifier: booleanNot.alwaysTrue
-			count: 1
-			path: ../../htdocs/accountancy/bookkeeping/listbyaccount.php
-
 		-
 			message: '#^Variable \$contextpage in empty\(\) always exists and is not falsy\.$#'
 			identifier: empty.variable
@@ -4572,12 +4560,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/comm/propal/class/propal.class.php
 
-		-
-			message: '#^Property CommonObject\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/comm/propal/class/propal.class.php
-
 		-
 			message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -4974,12 +4956,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/commande/class/commande.class.php
 
-		-
-			message: '#^Property CommonObject\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/commande/class/commande.class.php
-
 		-
 			message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -6174,12 +6150,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/compta/facture/class/facture.class.php
 
-		-
-			message: '#^Property CommonObject\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 3
-			path: ../../htdocs/compta/facture/class/facture.class.php
-
 		-
 			message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -19368,12 +19338,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/expedition/class/expedition.class.php
 
-		-
-			message: '#^Property Expedition\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/expedition/class/expedition.class.php
-
 		-
 			message: '#^Property Expedition\:\:\$ref_customer \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -20742,12 +20706,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/fourn/class/fournisseur.commande.class.php
 
-		-
-			message: '#^Property CommonObject\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/fourn/class/fournisseur.commande.class.php
-
 		-
 			message: '#^Property CommonObject\:\:\$ref_ext \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -20982,12 +20940,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/fourn/class/fournisseur.facture.class.php
 
-		-
-			message: '#^Property CommonObject\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/fourn/class/fournisseur.facture.class.php
-
 		-
 			message: '#^Property CommonObject\:\:\$ref_ext \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -28758,12 +28710,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/projet/list.php
 
-		-
-			message: '#^Negated boolean expression is always true\.$#'
-			identifier: booleanNot.alwaysTrue
-			count: 1
-			path: ../../htdocs/projet/list.php
-
 		-
 			message: '#^Ternary operator condition is always false\.$#'
 			identifier: ternary.alwaysFalse
@@ -30654,12 +30600,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/reception/class/reception.class.php
 
-		-
-			message: '#^Property Reception\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/reception/class/reception.class.php
-
 		-
 			message: '#^Property Reception\:\:\$ref_supplier \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -31914,12 +31854,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/salaries/payments.php
 
-		-
-			message: '#^Negated boolean expression is always true\.$#'
-			identifier: booleanNot.alwaysTrue
-			count: 1
-			path: ../../htdocs/salaries/payments.php
-
 		-
 			message: '#^Ternary operator condition is always false\.$#'
 			identifier: ternary.alwaysFalse
@@ -32334,12 +32268,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/societe/class/companybankaccount.class.php
 
-		-
-			message: '#^Property CompanyBankAccount\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/societe/class/companybankaccount.class.php
-
 		-
 			message: '#^Call to function method_exists\(\) with \$this\(Societe\) and ''getLibStatut'' will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType
@@ -33738,18 +33666,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/ticket/class/ticket.class.php
 
-		-
-			message: '#^Property CommonObject\:\:\$entity \(int\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 1
-			path: ../../htdocs/ticket/class/ticket.class.php
-
-		-
-			message: '#^Property CommonObject\:\:\$model_pdf \(string\) in isset\(\) is not nullable\.$#'
-			identifier: isset.property
-			count: 2
-			path: ../../htdocs/ticket/class/ticket.class.php
-
 		-
 			message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#'
 			identifier: isset.property
@@ -33960,18 +33876,6 @@ parameters:
 			count: 1
 			path: ../../htdocs/ticket/index.php
 
-		-
-			message: '#^Negated boolean expression is always true\.$#'
-			identifier: booleanNot.alwaysTrue
-			count: 3
-			path: ../../htdocs/ticket/list.php
-
-		-
-			message: '#^Variable \$contextpage in empty\(\) always exists and is not falsy\.$#'
-			identifier: empty.variable
-			count: 1
-			path: ../../htdocs/ticket/list.php
-
 		-
 			message: '#^If condition is always false\.$#'
 			identifier: if.alwaysFalse
@@ -34320,12 +34224,6 @@ parameters:
 			count: 2
 			path: ../../htdocs/user/home.php
 
-		-
-			message: '#^Negated boolean expression is always true\.$#'
-			identifier: booleanNot.alwaysTrue
-			count: 2
-			path: ../../htdocs/user/list.php
-
 		-
 			message: '#^Offset ''u\.salary'' on array\{u\.salary\: \(float\|int\)\} in isset\(\) always exists and is not nullable\.$#'
 			identifier: isset.offset
diff --git a/htdocs/accountancy/bookkeeping/list.php b/htdocs/accountancy/bookkeeping/list.php
index ebf0dec33965b..60409e47f0f68 100644
--- a/htdocs/accountancy/bookkeeping/list.php
+++ b/htdocs/accountancy/bookkeeping/list.php
@@ -495,6 +495,8 @@
 	$permissiontodelete = $user->hasRight('societe', 'supprimer');
 	$permissiontoadd = $user->hasRight('societe', 'creer');
 	$uploaddir = $conf->societe->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	if (!$error && $action == 'deletebookkeepingwriting' && $confirm == "yes" && $user->hasRight('accounting', 'mouvements', 'supprimer')) {
diff --git a/htdocs/accountancy/bookkeeping/listbyaccount.php b/htdocs/accountancy/bookkeeping/listbyaccount.php
index 62c058fbf958c..7834b2a6d0fd2 100644
--- a/htdocs/accountancy/bookkeeping/listbyaccount.php
+++ b/htdocs/accountancy/bookkeeping/listbyaccount.php
@@ -459,6 +459,8 @@
 	$permissiontodelete = $user->hasRight('societe', 'supprimer');
 	$permissiontoadd = $user->hasRight('societe', 'creer');
 	$uploaddir = $conf->societe->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	if (!$error && $action == 'deletebookkeepingwriting' && $confirm == "yes" && $user->hasRight('accounting', 'mouvements', 'supprimer')) {
diff --git a/htdocs/commande/class/commande.class.php b/htdocs/commande/class/commande.class.php
index 4a6d220c49c32..24532b36ba0a1 100644
--- a/htdocs/commande/class/commande.class.php
+++ b/htdocs/commande/class/commande.class.php
@@ -947,6 +947,7 @@ public function create($user, $notrigger = 0)
 			$this->fk_multicurrency = 0;
 			$this->multicurrency_tx = 1;
 		}
+		// setEntity will set entity with the right value if empty or change it for the right value if multicompany module is active
 		$this->entity = setEntity($this);
 
 		dol_syslog(get_class($this)."::create user=".$user->id);
diff --git a/htdocs/core/actions_massactions.inc.php b/htdocs/core/actions_massactions.inc.php
index 872aa9ae73a2c..94964dfae8e68 100644
--- a/htdocs/core/actions_massactions.inc.php
+++ b/htdocs/core/actions_massactions.inc.php
@@ -59,6 +59,7 @@
  * @var string $objectclass
  * @var string $uploaddir
  * @var string $confirm
+ * @var int $error
  */
 '
 @phan-var-force ?string $permissiontoread
diff --git a/htdocs/core/class/commonobject.class.php b/htdocs/core/class/commonobject.class.php
index 8fe7db58b7281..7ad7702b9df3f 100644
--- a/htdocs/core/class/commonobject.class.php
+++ b/htdocs/core/class/commonobject.class.php
@@ -546,7 +546,7 @@ abstract class CommonObject
 	public $multicurrency_total_localtax2;	// not in database
 
 	/**
-	 * @var string
+	 * @var ?string
 	 * @see SetDocModel()
 	 */
 	public $model_pdf;
diff --git a/htdocs/expedition/class/expedition.class.php b/htdocs/expedition/class/expedition.class.php
index f7b5c2aeb3b3f..f80e6e5d8c753 100644
--- a/htdocs/expedition/class/expedition.class.php
+++ b/htdocs/expedition/class/expedition.class.php
@@ -136,11 +136,6 @@ class Expedition extends CommonObject
 	 */
 	public $billed;
 
-	/**
-	 * @var string name of pdf model
-	 */
-	public $model_pdf;
-
 	/**
 	 * @var int|string
 	 */
diff --git a/htdocs/projet/list.php b/htdocs/projet/list.php
index da8c2b669b049..9170ba31ed3bc 100644
--- a/htdocs/projet/list.php
+++ b/htdocs/projet/list.php
@@ -445,6 +445,8 @@
 	$permissiontodelete = $user->hasRight('projet', 'supprimer');
 	$permissiontoadd = $user->hasRight('projet', 'creer');
 	$uploaddir = $conf->project->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	// Close records
diff --git a/htdocs/reception/class/reception.class.php b/htdocs/reception/class/reception.class.php
index 71d4a47cafffa..86e8d046ff987 100644
--- a/htdocs/reception/class/reception.class.php
+++ b/htdocs/reception/class/reception.class.php
@@ -99,10 +99,6 @@ class Reception extends CommonObject
 	 * @var int<0,1>
 	 */
 	public $billed;
-	/**
-	 * @var string
-	 */
-	public $model_pdf;
 
 	/**
 	 * @var int|float
diff --git a/htdocs/salaries/payments.php b/htdocs/salaries/payments.php
index cc51621c14a37..f91b5b3e566cd 100644
--- a/htdocs/salaries/payments.php
+++ b/htdocs/salaries/payments.php
@@ -214,6 +214,8 @@
 	$objectclass = 'PaymentSalary';
 	$objectlabel = 'SalariesPayments';
 	$uploaddir = $conf->salaries->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	// Validate records
diff --git a/htdocs/societe/class/companybankaccount.class.php b/htdocs/societe/class/companybankaccount.class.php
index a27f7c3504a8c..a50c111dbfbc4 100644
--- a/htdocs/societe/class/companybankaccount.class.php
+++ b/htdocs/societe/class/companybankaccount.class.php
@@ -329,12 +329,6 @@ class CompanyBankAccount extends Account
 	 */
 	public $datem;
 
-	/**
-	 * @var string
-	 * @see SetDocModel()
-	 */
-	public $model_pdf;
-
 	/**
 	 * @var string TRIGGER_PREFIX  Dolibarr 16.0 and above use the prefix to prevent the creation of inconsistently
 	 *                             named triggers
diff --git a/htdocs/societe/list.php b/htdocs/societe/list.php
index e5508c334e7d7..a8167de49da42 100644
--- a/htdocs/societe/list.php
+++ b/htdocs/societe/list.php
@@ -480,9 +480,11 @@
 	$permissiontodelete = $user->hasRight('societe', 'supprimer');
 	$permissiontoadd = $user->hasRight("societe", "creer");
 	$uploaddir = $conf->societe->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
-	if ($action == 'setstcomm' && $permissiontoadd) {
+	if (!$error && $action == 'setstcomm' && $permissiontoadd) {
 		$object = new Client($db);
 		$result = $object->fetch(GETPOST('stcommsocid'));
 		$object->stcomm_id = dol_getIdFromCode($db, GETPOST('stcomm', 'alpha'), 'c_stcomm');
diff --git a/htdocs/ticket/class/ticket.class.php b/htdocs/ticket/class/ticket.class.php
index 56cfb53ef9a94..b2eb7d56f7bad 100644
--- a/htdocs/ticket/class/ticket.class.php
+++ b/htdocs/ticket/class/ticket.class.php
@@ -510,7 +510,8 @@ public function create($user, $notrigger = 0)
 		$result = $this->verify();
 
 		if ($result >= 0) {
-			$this->entity = ((isset($this->entity) && is_numeric($this->entity)) ? $this->entity : $conf->entity);
+			// setEntity will set entity with the right value if empty or change it for the right value if multicompany module is active
+			$this->entity = setEntity($this);
 
 			// Insert request
 			$sql = "INSERT INTO ".MAIN_DB_PREFIX."ticket(";
diff --git a/htdocs/ticket/list.php b/htdocs/ticket/list.php
index ec492d679363d..d9c8203034437 100644
--- a/htdocs/ticket/list.php
+++ b/htdocs/ticket/list.php
@@ -250,83 +250,81 @@
 	$objectclass = 'Ticket';
 	$objectlabel = 'Ticket';
 	$uploaddir = $conf->ticket->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	// Close records
 	if (!$error && $massaction == 'close' && $permissiontoadd) {
-		$objecttmp = new $objectclass($db);
-		if (!$error) {
-			$db->begin();
-
-			$nbok = 0;
-			foreach ($toselect as $toselectid) {
-				$result = $objecttmp->fetch($toselectid);
-				if ($result > 0) {
-					$result = $objecttmp->close($user);
-					if ($result < 0) {
-						setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
-						$error++;
-						break;
-					} else {
-						$nbok++;
-					}
-				} else {
+		$objecttmp = new Ticket($db);
+		$db->begin();
+
+		$nbok = 0;
+		foreach ($toselect as $toselectid) {
+			$result = $objecttmp->fetch($toselectid);
+			if ($result > 0) {
+				$result = $objecttmp->close($user);
+				if ($result < 0) {
 					setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
 					$error++;
 					break;
+				} else {
+					$nbok++;
 				}
-			}
-
-			if (!$error) {
-				setEventMessages($langs->trans("RecordsModified", $nbok), null, 'mesgs');
-				$db->commit();
 			} else {
-				$db->rollback();
+				setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
+				$error++;
+				break;
 			}
-			//var_dump($listofobjectthirdparties);exit;
 		}
+
+		if (!$error) {
+			setEventMessages($langs->trans("RecordsModified", $nbok), null, 'mesgs');
+			$db->commit();
+		} else {
+			$db->rollback();
+		}
+		//var_dump($listofobjectthirdparties);exit;
 	}
 
 	// Reopen records
 	if (!$error && $massaction == 'reopen' && $permissiontoadd) {
-		$objecttmp = new $objectclass($db);
-		if (!$error) {
-			$db->begin();
-
-			$nbok = 0;
-			foreach ($toselect as $toselectid) {
-				$result = $objecttmp->fetch($toselectid);
-				if ($result > 0) {
-					if ($objecttmp->status == Ticket::STATUS_CLOSED || $objecttmp->status == Ticket::STATUS_CANCELED) {
-						$result = $objecttmp->setStatut(Ticket::STATUS_ASSIGNED);
-						if ($result < 0) {
-							setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
-							$error++;
-							break;
-						} else {
-							$nbok++;
-						}
-					} else {
-						$langs->load("errors");
-						setEventMessages($langs->trans("ErrorObjectMustHaveStatusClosedToBeReOpened", $objecttmp->ref), null, 'errors');
+		$objecttmp = new Ticket($db);
+		$db->begin();
+
+		$nbok = 0;
+		foreach ($toselect as $toselectid) {
+			$result = $objecttmp->fetch($toselectid);
+			if ($result > 0) {
+				if ($objecttmp->status == Ticket::STATUS_CLOSED || $objecttmp->status == Ticket::STATUS_CANCELED) {
+					$result = $objecttmp->setStatut(Ticket::STATUS_ASSIGNED);
+					if ($result < 0) {
+						setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
 						$error++;
 						break;
+					} else {
+						$nbok++;
 					}
 				} else {
-					setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
+					$langs->load("errors");
+					setEventMessages($langs->trans("ErrorObjectMustHaveStatusClosedToBeReOpened", $objecttmp->ref), null, 'errors');
 					$error++;
 					break;
 				}
-			}
-
-			if (!$error) {
-				setEventMessages($langs->trans("RecordsModified", $nbok), null, 'mesgs');
-				$db->commit();
 			} else {
-				$db->rollback();
+				setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
+				$error++;
+				break;
 			}
-			//var_dump($listofobjectthirdparties);exit;
 		}
+
+		if (!$error) {
+			setEventMessages($langs->trans("RecordsModified", $nbok), null, 'mesgs');
+			$db->commit();
+		} else {
+			$db->rollback();
+		}
+		//var_dump($listofobjectthirdparties);exit;
 	}
 }
 
@@ -393,6 +391,7 @@
 }
 
 foreach ($search as $key => $val) {
+	$tmpkey = 't.' . $key;
 	if ($key == 'fk_statut' && !empty($search['fk_statut'])) {
 		$newarrayofstatus = array();
 		foreach ($search['fk_statut'] as $key2 => $val2) {
@@ -414,18 +413,18 @@
 			$newarrayofstatus[] = Ticket::STATUS_CANCELED;
 		}
 		if (count($newarrayofstatus)) {
-			$sql .= natural_search($key, implode(',', $newarrayofstatus), 2);
+			$sql .= natural_search($tmpkey, implode(',', $newarrayofstatus), 2);
 		}
 		continue;
 	} elseif ($key == 'fk_user_assign' || $key == 'fk_user_create' || $key == 'fk_project' || $key == 'fk_contract') {
 		if ($search[$key] > 0) {
-			$sql .= natural_search($key, $search[$key], 2);
+			$sql .= natural_search($tmpkey, $search[$key], 2);
 		}
 		continue;
 	} elseif ($key == 'type_code') {
 		$newarrayoftypecodes = is_array($search[$key]) ? $search[$key] : (!empty($search[$key]) ? explode(',', $search[$key]) : array());
 		if (count($newarrayoftypecodes)) {
-			$sql .= natural_search($key, implode(',', $newarrayoftypecodes), 3);
+			$sql .= natural_search($tmpkey, implode(',', $newarrayoftypecodes), 3);
 		}
 		continue;
 	}
@@ -433,7 +432,7 @@
 	$mode_search = ((!empty($object->fields[$key]) && ($object->isInt($object->fields[$key]) || $object->isFloat($object->fields[$key]))) ? 1 : 0);
 	// $search[$key] can be an array of values, or a string. We add filter if array not empty or if it is a string.
 	if ((is_array($search[$key]) && !empty($search[$key])) || (!is_array($search[$key]) && $search[$key] != '')) {
-		$sql .= natural_search($key, $search[$key], $mode_search);
+		$sql .= natural_search($tmpkey, $search[$key], $mode_search);
 	}
 }
 if ($search_all) {
@@ -443,10 +442,10 @@
 	$sql .= natural_search('s.nom', $search_societe);
 }
 if ($search_fk_project > 0) {
-	$sql .= natural_search('fk_project', (string) $search_fk_project, 2);
+	$sql .= natural_search('t.fk_project', (string) $search_fk_project, 2);
 }
 if ($search_fk_contract > 0) {
-	$sql .= natural_search('fk_contract', (string) $search_fk_contract, 2);
+	$sql .= natural_search('t.fk_contract', (string) $search_fk_contract, 2);
 }
 if ($search_date_start) {
 	$sql .= " AND t.datec >= '".$db->idate($search_date_start)."'";
@@ -661,7 +660,7 @@
 if (!empty($mode)) {
 	$param .= '&mode='.urlencode($mode);
 }
-if (!empty($contextpage) && $contextpage != $_SERVER["PHP_SELF"]) {
+if (/* !empty($contextpage) && */ $contextpage != $_SERVER["PHP_SELF"]) { // $contextpage can't be empty
 	$param .= '&contextpage='.urlencode($contextpage);
 }
 if ($limit > 0 && $limit != $conf->liste_limit) {
diff --git a/htdocs/user/list.php b/htdocs/user/list.php
index 36d0a7df8d91b..fb0712c74822c 100644
--- a/htdocs/user/list.php
+++ b/htdocs/user/list.php
@@ -304,62 +304,62 @@
 	$objectclass = 'User';
 	$objectlabel = 'User';
 	$uploaddir = $conf->user->dir_output;
+
+	global $error;
 	include DOL_DOCUMENT_ROOT.'/core/actions_massactions.inc.php';
 
 	// Disable or Enable records
 	if (!$error && ($massaction == 'disable' || $massaction == 'reactivate') && $permissiontoadd) {
 		$objecttmp = new User($db);
 
-		if (!$error) {
-			$db->begin();
+		$db->begin();
+
+		$nbok = 0;
+		foreach ($toselect as $toselectid) {
+			if ($toselectid == $user->id) {
+				setEventMessages($langs->trans($massaction == 0 ? 'CantDisableYourself' : 'CanEnableYourself'), null, 'errors');
+				$error++;
+				break;
+			}
 
-			$nbok = 0;
-			foreach ($toselect as $toselectid) {
-				if ($toselectid == $user->id) {
-					setEventMessages($langs->trans($massaction == 0 ? 'CantDisableYourself' : 'CanEnableYourself'), null, 'errors');
+			$result = $objecttmp->fetch($toselectid);
+			if ($result > 0) {
+				if ($objecttmp->admin) {
+					setEventMessages($langs->trans($massaction == 0 ? 'CantDisableAnAdminUserWithMassActions' : 'CantEnableAnAdminUserWithMassActions', $objecttmp->login), null, 'errors');
 					$error++;
 					break;
 				}
 
-				$result = $objecttmp->fetch($toselectid);
-				if ($result > 0) {
-					if ($objecttmp->admin) {
-						setEventMessages($langs->trans($massaction == 0 ? 'CantDisableAnAdminUserWithMassActions' : 'CantEnableAnAdminUserWithMassActions', $objecttmp->login), null, 'errors');
-						$error++;
-						break;
-					}
-
-					$result = $objecttmp->setstatus($massaction == 'disable' ? 0 : 1);
-					if ($result == 0) {
-						// Nothing is done
-					} elseif ($result < 0) {
-						setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
-						$error++;
-						break;
-					} else {
-						$nbok++;
-					}
-				} else {
+				$result = $objecttmp->setstatus($massaction == 'disable' ? 0 : 1);
+				if ($result == 0) {
+					// Nothing is done
+				} elseif ($result < 0) {
 					setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
 					$error++;
 					break;
+				} else {
+					$nbok++;
 				}
+			} else {
+				setEventMessages($objecttmp->error, $objecttmp->errors, 'errors');
+				$error++;
+				break;
 			}
+		}
 
-			if (!$error && !empty($conf->file->main_limit_users)) {
-				$nb = $object->getNbOfUsers("active");
-				if ($nb >= $conf->file->main_limit_users) {
-					$error++;
-					setEventMessages($langs->trans("YourQuotaOfUsersIsReached"), null, 'errors');
-				}
+		if (!$error && !empty($conf->file->main_limit_users)) {
+			$nb = $object->getNbOfUsers("active");
+			if ($nb >= $conf->file->main_limit_users) {
+				$error++;
+				setEventMessages($langs->trans("YourQuotaOfUsersIsReached"), null, 'errors');
 			}
+		}
 
-			if (!$error) {
-				setEventMessages($langs->trans("RecordsModified", $nbok), null, 'mesgs');
-				$db->commit();
-			} else {
-				$db->rollback();
-			}
+		if (!$error) {
+			setEventMessages($langs->trans("RecordsModified", $nbok), null, 'mesgs');
+			$db->commit();
+		} else {
+			$db->rollback();
 		}
 	}
 }