fix CI phpstan (#32032)

* fix CI phpstan * Update interface_50_modTicket_TicketEmail.class.php * Update interface_50_modTicket_TicketEmail.class.php
Dolibarr · Nov 21, 2024 · 2832654 · 2832654
1 parent 4bc1eeb
commit 2832654
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/htdocs/core/lib/bank.lib.php b/htdocs/core/lib/bank.lib.php
@@ -54,7 +54,7 @@ function bank_prepare_head(Account $object)
 	$h++;
 
 	if ($object->canBeConciliated() > 0) {
-		$allowautomaticconciliation = false; // TODO
+		$allowautomaticconciliation = getDolGlobalBool('MAIN_ALLOW_AUTOMATIC_CONCILIATION'); // TODO
 		$titletoconciliatemanual = $langs->trans("Conciliate");
 		$titletoconciliateauto = $langs->trans("Conciliate");
 		if ($allowautomaticconciliation) {

diff --git a/htdocs/core/triggers/interface_50_modTicket_TicketEmail.class.php b/htdocs/core/triggers/interface_50_modTicket_TicketEmail.class.php
@@ -164,9 +164,9 @@ public function runTrigger($action, $object, User $user, Translate $langs, Conf
 				// $object->context['createdfrompublicinterface'] may also be defined when creation done from public interface
 				if (getDolGlobalString('TICKET_NOTIFICATION_EMAIL_TO') && empty($object->context['disableticketemail'])) {
 					$sendto = getDolGlobalString('TICKET_NOTIFICATION_EMAIL_TO');
-					if ($sendto) {
-						$this->composeAndSendAdminMessage($sendto, $subject_admin, $body_admin, $object, $langs);
-					}
+					// if ($sendto) { // already test, can't be empty
+					$this->composeAndSendAdminMessage($sendto, $subject_admin, $body_admin, $object, $langs);
+					// }
 				}
 
 				// Send email to assignee if an assignee was set at creation
@@ -251,9 +251,9 @@ public function runTrigger($action, $object, User $user, Translate $langs, Conf
 				// Note: $object->context['disableticketemail'] is set to 1 by public interface at creation but not at closing
 				if (getDolGlobalString('TICKET_NOTIFICATION_EMAIL_TO') && empty($object->context['disableticketemail'])) {
 					$sendto = getDolGlobalString('TICKET_NOTIFICATION_EMAIL_TO');
-					if ($sendto) {
-						$this->composeAndSendAdminMessage($sendto, $subject_admin, $body_admin, $object, $langs);
-					}
+					// if ($sendto) { // already test, can't be empty
+					$this->composeAndSendAdminMessage($sendto, $subject_admin, $body_admin, $object, $langs);
+					// }
 				}
 
 				// Send email to customer.