Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use that many State Attributes #71

Open
3 tasks done
mawoka-myblock opened this issue Dec 26, 2023 · 7 comments
Open
3 tasks done

Don't use that many State Attributes #71

mawoka-myblock opened this issue Dec 26, 2023 · 7 comments
Assignees
Labels
Home Assistant Stuff that is related to home assistant and the integration of services improvement Anything that affects parts which can be made better refactoring Needs a refactoring

Comments

@mawoka-myblock
Copy link

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

The usage of state attributes could make the database size increase quickly.

Describe the solution you'd like

Create dedicated sensors, especially for remaining and used weight, since that is update pretty frequently

Describe alternatives you've considered

Maybe not that important?

Additional context

https://developers.home-assistant.io/docs/core/entity/#generic-properties

@Disane87
Copy link
Owner

That's a good hint, will dig into this. Thank you!

@Disane87 Disane87 self-assigned this Feb 1, 2024
@Disane87 Disane87 added good first issue Good for newcomers improvement Anything that affects parts which can be made better Home Assistant Stuff that is related to home assistant and the integration of services labels Feb 1, 2024
@Disane87
Copy link
Owner

Disane87 commented Mar 8, 2024

@mawoka-myblock I thought about this but the Create dedicated sensors, especially for remaining and used weight part makes me some headache. because I want to group these information together with the spool itself. If I break them up, these information would fragemented IMHO. Do you have any other idea?

The usage of state attributes could make the database size increase quickly.
I already have this integration running with around 20 spools and an update interval of 1 Minute and I can't see any significant growing.

But we should keep that in mind when someone have this issue.

I gonna pin that issue for further references.

@Disane87 Disane87 pinned this issue Mar 8, 2024
@mawoka-myblock
Copy link
Author

maybe create a "device" per spool?

@mawoka-myblock
Copy link
Author

Oh, I'd also suggest removing the good first issue label, as I'd say that this isn't one.

@Disane87 Disane87 removed the good first issue Good for newcomers label Mar 8, 2024
@Disane87
Copy link
Owner

Disane87 commented Mar 8, 2024

maybe create a "device" per spool?

That could be indeed a reasonable alternative. I will consider this!

@Disane87
Copy link
Owner

Currently I'm evaluating the possibility to create "Hubs" für every storage location and within that a device per spool and for every attribute an own entity. Something like Meross Integration is doing here:
image

But at the moment we're pretty busy with renovating our kitchen so that need some time. But with that refactoring I gonna address this problem #103 as well.

@Disane87 Disane87 added the refactoring Needs a refactoring label May 21, 2024
@mawoka-myblock
Copy link
Author

tbh, I don't even use your integration, just stumbled upon it, so take your time. If you should still need help, feel free to ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Home Assistant Stuff that is related to home assistant and the integration of services improvement Anything that affects parts which can be made better refactoring Needs a refactoring
Projects
None yet
Development

No branches or pull requests

2 participants