Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bytes32[] parameter in swap() #23

Open
yisiliu opened this issue May 7, 2021 · 0 comments
Open

Add a bytes32[] parameter in swap() #23

yisiliu opened this issue May 7, 2021 · 0 comments
Assignees

Comments

@yisiliu
Copy link
Member

yisiliu commented May 7, 2021

I am thinking about if it's a good idea to add bytes32[] data to swap() to add more expressiveness, e.g. a merkle-proof based whitelist. The reason why I haven't added it to our contract is that, all the merkle proofs need to be stored somewhere other than a blockchain since it's way too expensive and useless to do so.

However, if we store them in a third-party storage, we are taking the risk of an unstable connection to that endpoint(e.g. AWS S3), causing some of our users not to be able to get the proof to participate in the ITO in time. What do you think what we should do here?

I can definitely add it here but I am afraid it'll add too much complexity to the whole process towards an unstable state for our users.

@yisiliu yisiliu self-assigned this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant