Add an endpoint to initialize the GUI #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
commented
May 16, 2023
| # On Linux, this should typically resolve to "/" | ||
| root_directory = Path.cwd().root | ||
|
|
||
| # TODO: FastAPI has a bug where a URL object can't be directly returned here |
There was a problem hiding this comment.
@brianhelba TODO: report this.
There was a problem hiding this comment.
I'm going to file local and upstream issues, then delete this code comment.
brianhelba
force-pushed
the
home-endpoint
branch
2 times, most recently
from
41c5ac5 to
bef41c2
Compare
brianhelba
commented
May 16, 2023
| def test_gui_select_directory(client: TestClient) -> None: | ||
| response = client.get("/") | ||
| def test_gui_home(client: TestClient) -> None: | ||
| response = client.get(app.url_path_for("home"), follow_redirects=True) | ||
|
|
||
| assert response.status_code == 200 |
There was a problem hiding this comment.
Maybe we could put some more specific assertions in here, to ensure it really is the root that's being redirected to. I believe that was the problem raised in #59.
|
@marySalvi Beyond the two issues I've self-identified, can you review this and let me know if it's a reasonable approach? |
|
@marySalvi @brianhelba what is the status of this PR? Can it be closed? |
|
This doesn't seem necessary with the current behavior on Windows. We can reopen it if we decide it is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve how we handle default directories on Windows. It also provides a better separation of concerns (GUI initialization vs actual directory selection), which should make future development and testing easier.
Fixes #59.