Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for TYPE command and add tests for all supported types #1340

Open
arpitbbhayani opened this issue Nov 27, 2024 · 5 comments · May be fixed by #1366
Open

Add tests for TYPE command and add tests for all supported types #1340

arpitbbhayani opened this issue Nov 27, 2024 · 5 comments · May be fixed by #1366
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

No description provided.

@pankajjs
Copy link
Contributor

@arpitbbhayani @lucifercr07 Can I work on this ticket?

@arpitbbhayani
Copy link
Contributor Author

@pankajjs go for it. Thanks for taking this up.

@lucifercr07
Copy link
Contributor

@arpitbbhayani We do have tests for TYPE command. However, It does not have support for few types.

https://github.com/DiceDB/dice/blob/master/integration_tests/commands/resp/type_test.go https://github.com/DiceDB/dice/blob/master/integration_tests/commands/http/type_test.go https://github.com/DiceDB/dice/blob/master/integration_tests/commands/websocket/type_test.go

@pankajjs please add tests for missing types. Please let me know if you're facing any issue, we can sync up. Thanks for contributing.

@pankajjs
Copy link
Contributor

pankajjs commented Dec 4, 2024

The type commands supports
Screenshot 2024-12-04 at 1 55 25 PM
these many data types. So, we need to add support for missing data types from this list only.
Let me know if I understood the task correctly.
@lucifercr07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants