Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command GEORADIUS #1250

Open
arpitbbhayani opened this issue Nov 7, 2024 · 4 comments · May be fixed by #1321
Open

Add support for command GEORADIUS #1250

arpitbbhayani opened this issue Nov 7, 2024 · 4 comments · May be fixed by #1321
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the GEORADIUS command in DiceDB similar to the GEORADIUS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@c-harish
Copy link
Contributor

c-harish commented Nov 7, 2024

Hi @arpitbbhayani . Can I pick this up?

@apoorvyadav1111
Copy link
Contributor

Hi @c-harish , Assigned. Thanks for contributing to DiceDB.

@shah-nirmit
Copy link

shah-nirmit commented Nov 21, 2024

Can I take this up, if no one is working on it?

@c-harish
Copy link
Contributor

Can I take this up, if no one is working on it?

Hi, @shah-nirmit. I will raise one tonight. Thanks.

@c-harish c-harish linked a pull request Nov 22, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants