Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptive tasks #10

Closed
benscott opened this issue Apr 21, 2021 · 6 comments
Closed

Descriptive tasks #10

benscott opened this issue Apr 21, 2021 · 6 comments
Assignees
Labels
backlog Unlikely to be done in SYNTHESYS+ funding Galaxy question Further information is requested wontfix This will not be worked on

Comments

@benscott
Copy link
Contributor

Each pipeline component needs to be self-descriptive and self-validating.

  • Component API will return input schema
  • Input schema will identify required & optional fields
  • Component API to return output schema
  • Component will validate input schema
  • On validation failure, component will update object processing log

Processing will be the same across each component and we do not want to reinvent the wheel. Write a wrapper where the component returns just the input/output schema, and the API & validation is handled by the wrapper.

Questions to be discussed with @PaulBrack

  • Will each specimen object be treated as an individual within the workflow?
  • Does Galaxy have preprocessing wrappers around components?
  • Does Galaxy have input/output requirements/validation per component, dictating how the workflows can be constructed?
  • Should this be outside of Galaxy, and in the docker image? Probably not, but if it's not possible in Galaxy, could there be a wrapper around the docker image?

Need to consider these while developing #8

@yvanlebras
Copy link

yvanlebras commented May 10, 2021

Hi Ben,

Here some tests to give some content, I hope I am not totally out of scope ;)

To see existing "dummy" Gaalxy tools to treat images, you can have a look at this imaging dedicated instance: https://imaging.usegalaxy.eu/

Galaxy have preprocessing wrappers around components if you are thinking about abilities to use tools/scripts to pre-process data in the workflow.

Galaxy input/output requirements/validation per component is related to 1/ data types (so the data types used by the tools/workflow have to be specified as Galaxy datatype) and 2/ stdout/stderr and if there is an error, so stderr populated, the workflow stop.

@llivermore llivermore added this to the Proof of Concept milestone Jul 23, 2021
@PaulBrack
Copy link
Contributor

Removed POC milestone as this will require further work past the milestone

@llivermore
Copy link
Contributor

Considered a "could" have feature in the latest review of MVP - review in July

@llivermore llivermore added the D8.4 Work associated with final deliverable - e.g. testing, sustainability, and documentation. label May 31, 2022
@llivermore llivermore added backlog Unlikely to be done in SYNTHESYS+ funding and removed D8.4 Work associated with final deliverable - e.g. testing, sustainability, and documentation. labels Oct 26, 2022
@llivermore llivermore assigned llivermore and unassigned PaulBrack and llivermore Oct 26, 2022
@llivermore
Copy link
Contributor

@stain and @OliverWoolland I think we should discuss some of the broader issues around handling FDOs in Galaxy and how we could handle validation between tools. Not sure there is a simple answer but certainly not something we can address before the end of SYNTHESYS+.

@llivermore llivermore added the question Further information is requested label Oct 26, 2022
@stain stain added the wontfix This will not be worked on label Nov 2, 2022
@stain
Copy link
Collaborator

stain commented Nov 2, 2022

We've agreed that to make FDO tooling for Galaxy will not be planned for this project as it is still too unclear from DiSSCO where/how openDS FDOs should be stored/retrieved. Using FDO as a data layer should also be further integrated in Galaxy side rather than in each of the SDR tools (e.g. caching).

SDR tools now have brief descriptions in their Galaxy tool registration. Technical documentation #111 will cover more details of how components shall be used.

Closing for now.

@stain stain closed this as completed Nov 2, 2022
@stain stain closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
@OliverWoolland
Copy link
Collaborator

This functionality is not planned during the current development cycle.

We have identified some challenges with implementing incremental Fair Digital Objects within workflows.

To fully achieve this aim, it is likely that changes would need to be made to Galaxy itself. To allow the specification of FDOs and profiles in a tool's description to have meaningful inputs and output connections, as well as permitting validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Unlikely to be done in SYNTHESYS+ funding Galaxy question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

6 participants