Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub models don't cover upstream ends of first order tributaries #218

Open
sclaw opened this issue Oct 3, 2024 · 0 comments
Open

sub models don't cover upstream ends of first order tributaries #218

sclaw opened this issue Oct 3, 2024 · 0 comments

Comments

@sclaw
Copy link
Collaborator

sclaw commented Oct 3, 2024

When a source model fully covers a first-order NWM reach, the generated sub model does not include cross-sections upstream of the NWM reach limit. This leads to incomplete FIM coverage.

Collection: mip_17090003
Model: uw_group27
Sub model: 23765425

image
Black pixels are FIM, but they stop at RS 13309. RS 14277 should be included in sub model to provide full FIM coverage.

Suggested fix: when a NWM reach has no NWM reaches upstream of it, add logic to make us_xs one section higher.

@sclaw sclaw changed the title sub models don sub models don't cover upstream ends of first order tributaries Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant