Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcafe wrongly shows "filter" warning #6620

Closed
di5ko opened this issue Oct 18, 2021 · 3 comments · Fixed by #6795
Closed

Testcafe wrongly shows "filter" warning #6620

di5ko opened this issue Oct 18, 2021 · 3 comments · Fixed by #6795
Assignees
Labels
FREQUENCY: level 1 SYSTEM: configuration storage TYPE: bug The described behavior is considered as wrong (bug).

Comments

@di5ko
Copy link

di5ko commented Oct 18, 2021

What is your Test Scenario?

Run a test with a --fixture-meta flag or with a .filter() directive in a test runner file, without having any filter directives set up in .testcaferc.json.

What is the Current behavior?

Testcafe shows a The "filter" option from the configuration file will be ignored. warning above and below each test run.

What is the Expected behavior?

This warning not to show up.

What is your web application and your TestCafe test code?

See MWE: https://github.com/di5ko/testcafe-filter-warning

Steps to Reproduce:

Run the test from above MWE. Also see #5544 (comment).

Your Environment details:

  • testcafe version: 1.16.1
  • node.js version: v14.15.1
  • command-line arguments: npx testcafe chromium:headless filterissue.test.js --fixture-meta issue=true
  • browser name and version: Chrome 93.0.4577.0
  • platform and version: macOS 10.15.7
  • other: n/a
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 18, 2021
@AlexKamaev
Copy link
Contributor

Thank you for reporting this issue. I was able to reproduce it. This behavior is incorrect.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 20, 2021
@AlexKamaev AlexKamaev added TYPE: bug The described behavior is considered as wrong (bug). FREQUENCY: level 1 SYSTEM: configuration storage labels Oct 20, 2021
@miherlosev miherlosev self-assigned this Dec 22, 2021
miherlosev added a commit to miherlosev/testcafe that referenced this issue Dec 23, 2021
@di5ko
Copy link
Author

di5ko commented Jan 3, 2022

@AlexKamaev filter warning is still shown for me in v1.18.1:

....

 7 passed (43s)

 Warnings (1):
 --
  The "filter" option from the configuration file will be ignored.
[RUN-TESTS] All tests done!
~/git/e2e-testing [2021-01-03-hotfix-pipeline*] $ cat .testcaferc.json 
{
    "selectorTimeout": 20000,
    "assertionTimeout": 20000,
    "pageLoadTimeout": 20000,
    "stopOnFirstFail": true,
    "skipUncaughtErrors": true,
    "disablePageCaching": true
}

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 3, 2022
@AlexanderMoiseev
Copy link
Contributor

Hi,

The fix is available but not yet released. Please wait for the next Testcafe release or get changes from the master branch.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FREQUENCY: level 1 SYSTEM: configuration storage TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants