Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PivotGrid - OLAP - The E4000 error occurs if filterValues contains an item with the "unknown member" value (T1236954) #27952

Merged
merged 7 commits into from
Sep 9, 2024
Merged

PivotGrid - OLAP - The E4000 error occurs if filterValues contains an item with the "unknown member" value (T1236954) #27952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
980d042
refactor
pomahtri Aug 25, 2024
fdddc00
fix
pomahtri Aug 25, 2024
2bdd348
test
pomahtri Aug 25, 2024
5794b84
review fix
pomahtri Sep 2, 2024
0c417ea
Revert "review fix"
pomahtri Sep 2, 2024
f2b9c6a
fix: naming
pomahtri Sep 4, 2024
56d5ef1
fix
pomahtri Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/devextreme/js/__internal/grids/pivot_grid/xmla_store/m_xmla_store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,10 @@ const XmlaStore = Class.inherit((function () {

function preparePathValue(pathValue, dataField?) {
if (pathValue) {
pathValue = isString(pathValue) && pathValue.includes('&') ? pathValue : `[${pathValue}]`;
const shouldSkipWrappingPathValue = isString(pathValue) && (
pathValue.includes('&') || pathValue.startsWith(`${dataField}.`)
);
pathValue = shouldSkipWrappingPathValue ? pathValue : `[${pathValue}]`;

if (dataField && pathValue.indexOf(`${dataField}.`) === 0) {
pathValue = pathValue.slice(dataField.length + 1, pathValue.length);
Expand Down
21 changes: 21 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/store.xmla.common.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,28 @@ QUnit.module('Misc', stubsEnvironment, () => {
assert.deepEqual(filterExpr, ['(SELECT {[Product].[Category].[Product].[Category]&}on 0']);
});

QUnit.test('T1236954. Build a correct filter query when a member has unknown member', function(assert) {
this.store.load({
values: [{
dataField: '[Measures].[Calculated Cost]',
}],
columns: [{
dataField: '[Activities - Activities].[Activities]',
filterValues: ['[Activities - Activities].[Activities].[All].UNKNOWNMEMBER',
'[Activities - Activities].[Activities].&[24]',
'[Activities - Activities].[Activities].&[21]'],
}],
rows: [{
dataField: '[Departments - Activities].[Departments]',
}],
});

const filterExpr = this.getQuery().match(/\(select(.+?)on 0/gi);

assert.deepEqual(filterExpr, [
'(SELECT {[Activities - Activities].[Activities].[All].UNKNOWNMEMBER,[Activities - Activities].[Activities].&[24],[Activities - Activities].[Activities].&[21]}on 0',
]);
});
});

QUnit.module('getDrillDownItems', stubsEnvironment, () => {
Expand Down
Loading