Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curate the Live Channels display on the Homepage #35

Open
benrick opened this issue Feb 23, 2019 · 2 comments
Open

Curate the Live Channels display on the Homepage #35

benrick opened this issue Feb 23, 2019 · 2 comments
Labels
✨ enhancement New feature or request 📚 good first issue Good for newcomers
Milestone
MVP

Comments

@benrick
Copy link
Member

benrick commented Feb 23, 2019

For the live channels on the homepage, we want to show in order:

  1. the ones that you follow (if logged in)
  2. the most popular ones
  3. random assortment of others

Limit to 10 showing at a time. Button to see paged view of all live channels.
@benrick benrick added ✨ enhancement New feature or request 📚 good first issue Good for newcomers TwitchAPI labels Feb 23, 2019
@benrick benrick added this to the MVP milestone Feb 24, 2019
@benrick benrick changed the title Show Live Channels on Homepage Curate the Live Channels display on the Homepage Mar 29, 2019
@benrick benrick removed the TwitchAPI label Apr 18, 2019
@CodeItQuick
Copy link
Contributor

Can I claim this one?

CodeItQuick added a commit to CodeItQuick/DevStreams that referenced this issue Apr 28, 2019
@CodeItQuick
Issue DevChatter#35 Curate the Live Channels Display on Hompage
33ab04d 
PR for Issue DevChatter#35. I completed 2 and 3, but not 1 as I ran into issues with having to change even more classes (there are a lot in this PR changed already).
CodeItQuick added a commit to CodeItQuick/DevStreams that referenced this issue Apr 28, 2019
@CodeItQuick
Issue DevChatter#35 Curate the Live Channels Display on Hompage
508a0d8 
Additional Changes that were accidentally not included in first PR
CodeItQuick added a commit to CodeItQuick/DevStreams that referenced this issue Apr 28, 2019
@CodeItQuick
Issue DevChatter#35 Curate the Live Channels Display on Hompage
a0c672a 
Changes made to show live channels sorted by view count, also displaying time online. Modified the Feeling Lucky button to display a random live channel.
@CodeItQuick
Copy link
Contributor

Review commit a0c672a please. Ignore/reject commits 33ab04d and 508a0d8.

CodeItQuick added a commit to CodeItQuick/DevStreams that referenced this issue Apr 30, 2019
@CodeItQuick
Issue DevChatter#35 Curate the Live Channels Display on Hompage
f4e1bdf 
Requested updates to the pull request. Moved the getall method to the channelaggregateservices where it should be. Also changed the properties to Camel Casing
CodeItQuick added a commit to CodeItQuick/DevStreams that referenced this issue Apr 30, 2019
@CodeItQuick
Issue DevChatter#35 Curate the Live Channels Display on Homepage
fc983d1 
Updated a missed camal case.
benrick added a commit that referenced this issue May 14, 2019
@benrick
Merge pull request #77 from CodeItQuick/dev_original
2c4bd31 
Issue #35 Curate the Live Channels Display on Homepage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request 📚 good first issue Good for newcomers
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@benrick @CodeItQuick