Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email field validation and auto-fill in Login/Signup forms #1024

Open
Tong-Ding opened this issue Aug 27, 2023 · 2 comments · May be fixed by #1042
Open

Email field validation and auto-fill in Login/Signup forms #1024

Tong-Ding opened this issue Aug 27, 2023 · 2 comments · May be fixed by #1042
Assignees
@Tong-Ding
Labels
Front End Primarily front-end (react/javascript)

Comments

@Tong-Ding
Copy link
Collaborator

Tong-Ding commented Aug 27, 2023 •
edited
Loading

Before the design team tests the new layout updates for the signup and login website, there are verification issues with these two forms that can be dealt with:

For the login form:

  • The “Email” field lacks a proper verification policy. If users input '3' as their email address, an error message appears, but if they enter '3@1', the error message does not appear. Additionally, when users provide an incorrect email, the page refreshes without autofilling data.

For the signup form:

  • The “Email” field also lacks a verification policy immediately. If users provide an incorrect email, the page refreshes without autofilling data.
@Tong-Ding Tong-Ding self-assigned this Aug 27, 2023
@Tong-Ding Tong-Ding added the Front End Primarily front-end (react/javascript) label Aug 27, 2023
@PeterBreen
Copy link
Collaborator

Before you get too deep into this, please drop into #design on slack and ask if there's any login form or newsletter signup design work that's been done. I know we've done some things to both of these based on UX concerns, but I don't know if there's more design wanted or not.

One thing - the account signup form is our own code limited by what our db expects, the newsletter one is limited by what mailchimp expects. We may have to live with some differences, but 👍 to trying to reduce them.

@Tong-Ding
Copy link
Collaborator Author

Before you get too deep into this, please drop into #design on slack and ask if there's any login form or newsletter signup design work that's been done. I know we've done some things to both of these based on UX concerns, but I don't know if there's more design wanted or not.

One thing - the account signup form is our own code limited by what our db expects, the newsletter one is limited by what mailchimp expects. We may have to live with some differences, but 👍 to trying to reduce them.

Thanks for the info! I'll check with the #design team on Slack regarding any designs.

@Tong-Ding Tong-Ding changed the title Refine the signup and newsletter subscription forms Refine the signup form Sep 8, 2023
@Tong-Ding Tong-Ding changed the title Refine the signup form Refine the signup and login forms Sep 8, 2023
@Tong-Ding Tong-Ding changed the title Refine the signup and login forms Email field validation and auto-fill in Login/Signup forms Sep 20, 2023
@Tong-Ding Tong-Ding linked a pull request Sep 20, 2023 that will close this issue
1024 Add email field validation and auto-fill in Login/Signup forms #1042
Open
@ddfridley ddfridley moved this from Backlog to Needs review in DemocracyLab Development and Release May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tong-Ding Tong-Ding

Labels
Front End Primarily front-end (react/javascript)
Projects
DemocracyLab Development and Release
Status: Needs review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1024 Add email field validation and auto-fill in Login/Signup forms DemocracyLab/CivicTechExchange
2 participants
@PeterBreen @Tong-Ding