Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement getter to fetch ballot creation info from Ethereum and IPFS #50

Open
3 of 4 tasks
virgile-dev opened this issue Apr 22, 2018 · 9 comments
Open
3 of 4 tasks
Assignees

Comments

@virgile-dev
Copy link
Member

virgile-dev commented Apr 22, 2018

Ballot information that we need to query:

  • title
  • author name
  • date of creation
  • transaction status

The transaction status is only needed when the user creates the ballot. I'm thinking to construct the page we don't really have to get title, author name, date of creation if we just cache them and construct the page with the info. That way the only getter we'd need would be the transaction status. What do you think @LucasIsasmendi @aecc ?

@virgile-dev virgile-dev changed the title implement getter to get ballot creation transaction status from Ethereum implement getter to fetch ballot info from Ethereum Apr 22, 2018
@virgile-dev
Copy link
Member Author

The ballot page when just created:
capture d ecran 2018-04-22 a 12 48 03

@virgile-dev virgile-dev changed the title implement getter to fetch ballot info from Ethereum implement getter to fetch ballot creation info from Ethereum Apr 22, 2018
@virgile-dev virgile-dev changed the title implement getter to fetch ballot creation info from Ethereum implement getter to fetch ballot creation info from Ethereum and IPFS Apr 22, 2018
@virgile-dev virgile-dev modified the milestones: Contracts v0.1.1, Dapp v0.2 Apr 22, 2018
@AlexJupiter
Copy link
Member

If the proposed changes are implemented in #51 I think this issue is redundant right?

@aecc
Copy link
Collaborator

aecc commented May 14, 2018

Still the we need to implement fetching title, author, date from the blockchain. I'll be working on this soon

@LucasIsasmendi
Copy link
Member

title, author and date are not coming from IPFS?

@AlexJupiter AlexJupiter removed this from the Dapp v0.2 milestone May 19, 2018
@aecc
Copy link
Collaborator

aecc commented May 23, 2018

yes, I meant from IPFS, through the blockchain first. As I see only author name is missing. The rest, title and date seem implemented

@AlexJupiter
Copy link
Member

@aecc @LucasIsasmendi there seem to be some duplicates of the points here in DemocracyEarth/wallet#49, should this issue be closed and we just refer to #49 ?

Also, is this in "in progress", and if so, which one of you is working on this?

@LucasIsasmendi
Copy link
Member

There is a pending "author name" implementation, the trick here is if we should rely on IPFS or ETH for that. But yes, we can close this because we changed the view model of this ballot detail page

@aecc
Copy link
Collaborator

aecc commented May 29, 2018

@AlexJupiter @LucasIsasmendi I thought the #49 was a pure UI or UX task. There is work to do about the author unrelated to UX. @LucasIsasmendi as you already closed the issue, wanna add it somewhere else so it's not forgotten?

@LucasIsasmendi
Copy link
Member

You are right @aecc , reopening this to complete pending task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants