Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out minimum React version #9

Open
saxoncameron opened this issue Dec 2, 2019 · 1 comment
Open

Figure out minimum React version #9

saxoncameron opened this issue Dec 2, 2019 · 1 comment
Labels
consensus item Requires consensus about fundamental package architecture. documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.0.0

Comments

@saxoncameron
Copy link

This will better inform our react version listed in peerDependencies. We're not using anything too cutting edge React-wise, so it's unclear to me how we'd best figure this out.

Likely we'll first need a complete unit and integration test suite - and from there progressively decrease the React version until the tests fail? Or maybe there's a sane "minimum React version" consensus in the industry?
@saxoncameron saxoncameron added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 2, 2019
@saxoncameron
Copy link
Author

Eventually it'd be nice to also include this peerDependency and version in the README, under the install instructions.

@saxoncameron saxoncameron added the consensus item Requires consensus about fundamental package architecture. label Dec 20, 2019
@saxoncameron saxoncameron added this to the 1.0.0 milestone Dec 20, 2019
@saxoncameron saxoncameron added the help wanted Extra attention is needed label Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus item Requires consensus about fundamental package architecture. documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@saxoncameron