Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate bpSize param #16

Open
saxoncameron opened this issue Dec 20, 2019 · 1 comment
Open

Deprecate bpSize param #16

saxoncameron opened this issue Dec 20, 2019 · 1 comment
Assignees
@saxoncameron
Labels
consensus item Requires consensus about fundamental package architecture. deprecation Concerns deprecating some part of the package. not before tests Test and integration tests should exist before this issue is actioned.
Milestone
1.0.0

Comments

@saxoncameron
Copy link

Would solve #13

I'm not sure what the use-case for providing individual per-pixel sizes would be, given the library is built around the concept of named breakpoints.
@saxoncameron saxoncameron added invalid This doesn't seem right consensus item Requires consensus about fundamental package architecture. deprecation Concerns deprecating some part of the package. and removed invalid This doesn't seem right labels Dec 20, 2019
@saxoncameron
Copy link
Author

Maybe a middleground here could be to expose as a prop so bpSize doesnt otherwise trigger a re-render all the time, but still allows one to exhume bpSize if they really want it.

@saxoncameron saxoncameron added this to the 1.0.0 milestone Dec 20, 2019
@saxoncameron saxoncameron self-assigned this Dec 20, 2019
@saxoncameron saxoncameron added the not before tests Test and integration tests should exist before this issue is actioned. label Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saxoncameron saxoncameron

Labels
consensus item Requires consensus about fundamental package architecture. deprecation Concerns deprecating some part of the package. not before tests Test and integration tests should exist before this issue is actioned.
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@saxoncameron