Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if/else BreakpointContainer render pattern to README examples #15

Open
saxoncameron opened this issue Dec 20, 2019 · 0 comments
Open
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@saxoncameron
Copy link

Something like this:

<BreakpointContainer>
    {bpName => resolveBp(bpName, 's') ? <p>One</p> : <p>two</p>}
</BreakpointContainer>

Is superior to:

<Breakpoint query="0,s">
    <p>One</p>
</Breakpoint>
<Breakpoint query="s">
    <p>Two</p>
</Breakpoint>

But not intuitive for first-time users. Should find an appropriate place for this in the README amongst the other patterns. Maybe the way the patterns are currently presented is a little verbose.

@saxoncameron saxoncameron added the documentation Improvements or additions to documentation label Dec 20, 2019
@saxoncameron saxoncameron added this to the 1.0.0 milestone Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant