feat: Added a simple caching feature for access tokens #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pacificcode I will verify the caching functionality on my end. |
Signed-off-by: Bill Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Access token caching feature
about: Added a simple caching feature for access tokens
Pull request checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Please describe the current behavior that you are modifying, and link its a relevant issue
Request for access token to made prior to every request for a secret
Issue Number: Add the issue number this PR address here.
https://thycotic.visualstudio.com/Delinea.Work/_workitems/edit/608727
What is the new behavior?
Access token is cached as an ENV variable. Expiration is based on ExpiresIn attribute received with the access token i.e.
ExpiresIn * .9 = cache expiration time
Does this introduce a breaking change?
If yes, please describe...
Other relevant information
e.g. does this PR require another PR to be merged first?
No