Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request builder should give preview of types-publisher results #16014

Closed
efokschaner opened this issue Apr 20, 2017 · 2 comments
Closed

Comments

@efokschaner
Copy link
Contributor

efokschaner commented Apr 20, 2017

@andy-ms @RyanCavanaugh
I recently submitted a PR that had some unexpected results when run through the types-publisher. See this follow-up PR for context and an attempted fix.

This made me realise it would be nice to get more feedback from the types-publisher step as part of the pull request build. Maybe something as far-fetched as having the PRB generate a real pre-release package on npm so that end-to-end testing with the PR's npm package can be done?

@ghost
Copy link

ghost commented Apr 20, 2017

I don't think this will be necessary if we properly ban a .d.ts from appearing in a test folder (microsoft/types-publisher#339). Then the publish will just be the files you wrote plus a package.json and README.md generated automatically.

@efokschaner
Copy link
Contributor Author

Thanks @andy-ms, that would definitely help in the specific situation i was in. Feel free to close this issue if there's nothing else we want to do on this matter.

@ghost ghost closed this as completed Apr 20, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant