Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File merging broken on tip-d3 (0ab1a8e) #205

Open
evanhanders opened this issue Jun 16, 2022 · 2 comments
Open

File merging broken on tip-d3 (0ab1a8e) #205

evanhanders opened this issue Jun 16, 2022 · 2 comments
Milestone

Comments

@evanhanders
Copy link
Contributor

Just wanted to make a quick note that file merging (at least for virtual files) is broken on commit 0ab1a8e, probably before that. This generally makes sense; there seem to have been a lot of changes for how virtual files' scales and metadata are handled recently. I'll work on investigating this more soon and try to get a PR with fixes together ~this week.

@jsoishi
Copy link
Member

jsoishi commented Jun 16, 2022

The idea of the recent changes is to eliminate the need for merging virtual files. Do you have a use case for fixing this? It might not be worth the effort.

@evanhanders
Copy link
Contributor Author

evanhanders commented Jun 16, 2022

I think we're talking about two different processes when we talk about merging. Here, I'm talking about combining the data distributed across many files for a virtual file into one file. So (slices_s1/ & slices_s1.h5) => slices_s1.h5. There are two use cases for this:

  1. Decreasing number of files used to store data by orders of magnitude to stay under file quotas
  2. Increasing ease of moving data between computers (only having to move one file vs. a virtual file + many partials).

These are functionalities that I need in my research.

But you're right, the recent changes do make it so that all file outputs are immediately registered into virtual files, so there is no need for 'merging' from partial files, which is nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants