Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review GCP #214

Merged
merged 23 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "^.secrets.baseline$",
"lines": null
},
"generated_at": "2024-11-22T11:14:58Z",
"generated_at": "2024-11-13T08:35:31Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -1340,15 +1340,15 @@
"hashed_secret": "dc081999b19ee322ee45e3d4451246b7c449db0a",
"is_secret": false,
"is_verified": false,
"line_number": 134,
"line_number": 143,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "5a2ea68e9ea943ea31948fe51388c798e13346a9",
"is_secret": false,
"is_verified": false,
"line_number": 181,
"line_number": 185,
"type": "Secret Keyword",
"verified_result": null
}
Expand All @@ -1363,7 +1363,7 @@
"verified_result": null
},
{
"hashed_secret": "8ce7feb4d1c89d5611541bafa8f7ea83a4039665",
"hashed_secret": "e6a8430b6dc3747f44d258a127b11f4705d9ee01",
"is_secret": false,
"is_verified": false,
"line_number": 20,
Expand Down
202 changes: 103 additions & 99 deletions platform/gcloud/README.md

Large diffs are not rendered by default.

12 changes: 8 additions & 4 deletions platform/gcloud/README_NGINX.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ For reference, see the Google Cloud documentation https://cloud.google.com/commu

### 1. Create a NGINX Ingress controller

Refer to the [Create a NGINX Ingress controller](README.md#a-create-a-nginx-ingress-controller) section if you have not created it already.
- Use Helm to deploy the NGINX Ingress controller:

```shell
helm upgrade --install ingress-nginx ingress-nginx --repo https://kubernetes.github.io/ingress-nginx --namespace ingress-nginx --create-namespace
```

### 2. Install the ODM release

Expand All @@ -27,10 +31,10 @@ The secured HTTPS communication is managed by the NGINX ingress controller. So,

Replace the placeholders in the [gcp-values.yaml](./gcp-values.yaml) file and install the chart:

```
```shell
helm install mycompany ibm-helm/ibm-odm-prod --version 24.1.0 \
-f gcp-values.yaml \
--set service.ingress.annotations={"kubernetes.io/ingress.class: nginx"}
--set service.ingress.class=nginx
```

> **Note**
Expand All @@ -44,6 +48,6 @@ Refer to the [the main README](README.md#b-check-the-topology) to check the depl

If your ODM instances are not running properly, please refer to [our dedicated troubleshooting page](https://www.ibm.com/docs/en/odm/9.0.0?topic=900-troubleshooting-support).

# License
## License

[Apache 2.0](/LICENSE)
10 changes: 5 additions & 5 deletions platform/gcloud/gcp-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,24 @@ usersPassword: "odmAdmin"
image:
repository: cp.icr.io/cp/cp4a/odm
pullSecrets:
- <REGISTRY_SECRET>
- registrysecret

service:
enableTLS: false
ingress:
enabled: true
tlsSecretRef: mynicecompany-crt-secret
tlsSecretRef: mynicecompany-tls-secret
host: mynicecompany.com
tlsHosts:
- mynicecompany.com

externalDatabase:
type: postgres
secretCredentials: <ODM_DB_SECRET>
secretCredentials: odmdbsecret
port: 5432
serverName: <DB_ENDPOINT>
databaseName: <DATABASE_NAME>
databaseName: postgres
# You can get the last Google Cloud SQL PostgreSQL driver version
# at https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/releases
driversUrl:
- https://storage.googleapis.com/cloud-sql-java-connector/v1.7.1/postgres-socket-factory-1.7.1-jar-with-driver-and-dependencies.jar
- https://storage.googleapis.com/cloud-sql-connectors-java/v1.13.1/postgres-socket-factory-1.13.1-jar-with-driver-and-dependencies.jar
Binary file removed platform/gcloud/images/database_changepassword.png
Binary file not shown.
Binary file modified platform/gcloud/images/dc_sessionaffinity.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platform/gcloud/images/lb_resources.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platform/gcloud/images/lb_rewrite.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 17 additions & 0 deletions platform/gcloud/licensing-instance-NGINX.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
apiVersion: operator.ibm.com/v1alpha1
kind: IBMLicensing
metadata:
name: instance
spec:
apiSecretToken: ibm-licensing-token
datasource: datacollector
httpsEnable: false
ingressEnabled: true
ingressOptions:
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /$2
path: /ibm-licensing-service-instance(/|$)(.*)
instanceNamespace: ibm-licensing
license:
accept: true
10 changes: 6 additions & 4 deletions platform/gcloud/licensing-instance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ kind: IBMLicensing
metadata:
name: instance
spec:
apiSecretToken: ibm-licensing-token
datasource: datacollector
instanceNamespace: ibm-common-services
httpsEnable: false
ingressEnabled: true
ingressOptions:
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: '/$2'
path: /ibm-licensing-service-instance(/|$)(.*)
ingress.kubernetes.io/rewrite-target: /
path: /ibm-licensing-service-instance/*
instanceNamespace: ibm-licensing
license:
accept: true
Loading