Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't insert hologram lines at the end using the index #267

Open
NonSwag opened this issue Dec 14, 2024 · 1 comment · May be fixed by #268
Open

Can't insert hologram lines at the end using the index #267

NonSwag opened this issue Dec 14, 2024 · 1 comment · May be fixed by #268

Comments

@NonSwag
Copy link

NonSwag commented Dec 14, 2024

In HologramPage the insertLine(int, HologramLine) method checks whether the index is bigger or equal to the size
This should only check for bigger indexes because the index of the size itself appends it to the list
https://github.com/DecentSoftware-eu/DecentHolograms/blob/main/src/main/java/eu/decentsoftware/holograms/api/holograms/HologramPage.java#L176

@NonSwag
Copy link
Author

NonSwag commented Dec 14, 2024

@NonSwag NonSwag linked a pull request Dec 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant