Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Inconsistency #265

Open
NonSwag opened this issue Dec 7, 2024 · 0 comments · May be fixed by #269
Open

API Inconsistency #265

NonSwag opened this issue Dec 7, 2024 · 0 comments · May be fixed by #269

Comments

@NonSwag
Copy link

NonSwag commented Dec 7, 2024

Hologram#saveToFile can be set via its public method but config can't causing a NPE when invoking save
My suggestion would be assigning an object to config even if saveToFile is false and setting the field in the constructor accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Hologram constructors to enforce non-null config NonSwag/DecentHolograms
1 participant
@NonSwag