Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple flake8 refactoring #108

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Conversation

nkhaldi
Copy link
Contributor

@nkhaldi nkhaldi commented Jan 4, 2024

Updated .flake8 file:

  • Added .venv to flake8 exceptions, because that's often the default path when you create it via IDE
  • Added D100-type exceptions to extend-ignore (Missing docstring)
  • Added empty lines to prettify the code

Fixed D200 and D400 flake8 exceptions for docstrings.

Copy link
Owner

@DavidRomanovizc DavidRomanovizc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good!

nit: Just translate some docstring to eng, because somewhere docstring is in ru and somewhere in eng.

functions/event/extra_features.py Outdated Show resolved Hide resolved
functions/event/extra_features.py Outdated Show resolved Hide resolved
functions/event/extra_features.py Outdated Show resolved Hide resolved
functions/event/extra_features.py Outdated Show resolved Hide resolved
functions/event/extra_features.py Outdated Show resolved Hide resolved
functions/main_app/auxiliary_tools.py Show resolved Hide resolved
functions/main_app/auxiliary_tools.py Show resolved Hide resolved
utils/db_api/db_commands.py Outdated Show resolved Hide resolved
utils/db_api/db_commands.py Outdated Show resolved Hide resolved
functions/main_app/determin_location.py Outdated Show resolved Hide resolved
@DavidRomanovizc DavidRomanovizc added the Status: Completed No further action needed. Awaiting closure by requester or project member label Jan 4, 2024
@DavidRomanovizc DavidRomanovizc merged commit dd94d39 into DavidRomanovizc:main Jan 5, 2024
2 checks passed
DavidRomanovizc added a commit to nkhaldi/DatingBot that referenced this pull request Jan 8, 2024
* added .venv to flake8 excludes

* added fixed flake D-type exception

* Update functions/event/extra_features.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/event/extra_features.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/event/extra_features.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/event/extra_features.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/event/extra_features.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/main_app/auxiliary_tools.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/main_app/auxiliary_tools.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update utils/db_api/db_commands.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update utils/db_api/db_commands.py

Signed-off-by: David Dzhalaev <[email protected]>

* Update functions/main_app/determin_location.py

Signed-off-by: David Dzhalaev <[email protected]>

---------

Signed-off-by: David Dzhalaev <[email protected]>
Co-authored-by: David Dzhalaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed No further action needed. Awaiting closure by requester or project member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants