Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write to settings #9

Open
melvyn-apryl opened this issue May 24, 2021 · 0 comments
Open

Don't write to settings #9

melvyn-apryl opened this issue May 24, 2021 · 0 comments

Comments

@melvyn-apryl
Copy link
Contributor

melvyn-apryl commented May 24, 2021 •
edited
Loading

The package writes to settings, which is discouraged by Django.

The proper way to do this, is to have an "app_settings", that hydrates from Django's settings and uses that throughout the application. I'll put up a PR for you to consider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@melvyn-apryl