[CONTP-437] Add check_cardinality to nginx #1246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuminyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A follow up for recent feature in 7.60: DataDog/datadog-agent#29984
which allows user to configure the cardinality of check instance via annotation check config.
This PR set nginx check cardinality to low.
Which scenarios this will impact?
https://github.com/DataDog/datadog-agent/blob/main/test/new-e2e/tests/containers/k8s_test.go#L442
will be affected, container_id, name will be disabled in the tags.
Motivation
Additional Notes
E2e test needs to be updated as well. However, since AcceptUnexpectedTags is set to true, this PR is expected to be not breaking current e2e test.