-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Debugger] Refactoring #3616
[Debugger] Refactoring #3616
Conversation
66c2b4d
to
c6b9d83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, ALGTM. You can rebase your branch to fix the issue in open telemetry.
I've also added some lint tules, so you may have to fix one or two lints after the rebase.
7df28e5
to
7a64c5b
Compare
No conflicts, but still decided to rebase to double check everything is okay. It's huge PR, a lot of changes. Want to be sure nothing is going to be broken. |
Motivation
Makes the debugger system tests easier to understand for new developers.
Fix bugs and ensures the tests work more reliably.
Changes
Expanded Data Collection
Collecting all spans, snapshots, and metrics related to the debugger.
Refactored Methods
Moved and standardized "wait for" and "collect" methods to base utility, instead of test specific.
Probe Enrichment Refactor
Moved enrichment of probes fields (types, language, etc.) from the RC module to the debugger utility.
Exception Replay